Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

On 11/4/21 3:59 PM, Thomas Monjalon wrote:
> 04/11/2021 12:03, Ferruh Yigit:
>> On 11/3/2021 10:48 PM, Ferruh Yigit wrote:
>>> Old macros kept for backward compatibility, but this cause old macro
>>> usage to sneak in silently.
>>>
>>> Marking old macros as deprecated. Downside is this will cause some noise
>>> for applications that are using old macros.
>>>
>>> Fixes: 295968d17407 ("ethdev: add namespace")
>>>
>>> Signed-off-by: Ferruh Yigit<ferruh.yigit@intel.com>
>>> Acked-by: Stephen Hemminger<stephen@networkplumber.org>
>>
>> Hi Thomas, Andrew,
>>
>> What do you think about marking old macros as deprecated?
>>
>> This will cause warning in application code that is using
>> old macros, but shouldn't fail their build (unless -Werror
>> is issued).
> 
> It looks to be the right thing to do.
> I wonder whether we could wait 22.02 to apply it,
> so users of LTS are not annoyed by it.
> 

I have no strong opinion, but tend to agree with Thomas.
However, if an application jumps from LTS to LTS, these
defines will be available in 21.11 without any warnings
and simply disappear in 22.11. So, may be it is more
friendly to deprecate in 21.11.