From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 19882A0C56;
	Fri,  5 Nov 2021 14:40:14 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 09CA641159;
	Fri,  5 Nov 2021 14:40:14 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 8538640E5A
 for <dev@dpdk.org>; Fri,  5 Nov 2021 14:40:12 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 2492C7F53A;
 Fri,  5 Nov 2021 16:40:12 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 2492C7F53A
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1636119612;
 bh=b/68hAMxdU7VREd2UTXIT35Mesb7wa4PrctjPHJEAk4=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=hL/d+tDdVjAOL6Vojb5XtiSgQQNhVRSNmjveWneArVYXG84cMr2qIBYdGNkctR72u
 dmDBB1vTJjV1+H/c4TkVK1Hbu/cSj7COC0bkTfkEycD066E7rO3Sz0gPALA875O4Bu
 6HJUYTKiYce0zXn9+54lxEHDkS1/eb096/cMARzs=
To: Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
 David Marchand <david.marchand@redhat.com>,
 Olivier Matz <olivier.matz@6wind.com>
References: <20211102234434.2639807-1-ferruh.yigit@intel.com>
 <20211103224835.3407994-1-ferruh.yigit@intel.com>
 <36cd56b2-2388-7924-a10f-9b5c05242d64@intel.com> <2611380.4jmpmGm5TL@thomas>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <0db26ffd-1c1c-e920-0390-ee863862b071@oktetlabs.ru>
Date: Fri, 5 Nov 2021 16:40:12 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <2611380.4jmpmGm5TL@thomas>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/4/21 3:59 PM, Thomas Monjalon wrote:
> 04/11/2021 12:03, Ferruh Yigit:
>> On 11/3/2021 10:48 PM, Ferruh Yigit wrote:
>>> Old macros kept for backward compatibility, but this cause old macro
>>> usage to sneak in silently.
>>>
>>> Marking old macros as deprecated. Downside is this will cause some noise
>>> for applications that are using old macros.
>>>
>>> Fixes: 295968d17407 ("ethdev: add namespace")
>>>
>>> Signed-off-by: Ferruh Yigit<ferruh.yigit@intel.com>
>>> Acked-by: Stephen Hemminger<stephen@networkplumber.org>
>>
>> Hi Thomas, Andrew,
>>
>> What do you think about marking old macros as deprecated?
>>
>> This will cause warning in application code that is using
>> old macros, but shouldn't fail their build (unless -Werror
>> is issued).
> 
> It looks to be the right thing to do.
> I wonder whether we could wait 22.02 to apply it,
> so users of LTS are not annoyed by it.
> 

I have no strong opinion, but tend to agree with Thomas.
However, if an application jumps from LTS to LTS, these
defines will be available in 21.11 without any warnings
and simply disappear in 22.11. So, may be it is more
friendly to deprecate in 21.11.