From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0054.outbound.protection.outlook.com [104.47.38.54]) by dpdk.org (Postfix) with ESMTP id 85CF0107A for ; Mon, 11 Dec 2017 14:43:45 +0100 (CET) Received: from CY4PR03CA0012.namprd03.prod.outlook.com (10.168.162.22) by BN6PR03MB2689.namprd03.prod.outlook.com (10.173.144.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Mon, 11 Dec 2017 13:43:44 +0000 Received: from BN1BFFO11FD027.protection.gbl (2a01:111:f400:7c10::1:164) by CY4PR03CA0012.outlook.office365.com (2603:10b6:903:33::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Mon, 11 Dec 2017 13:43:44 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD027.mail.protection.outlook.com (10.58.144.90) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.282.5 via Frontend Transport; Mon, 11 Dec 2017 13:43:38 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vBBDhfT5012796; Mon, 11 Dec 2017 06:43:42 -0700 To: Gaetan Rivet References: CC: From: Shreyansh Jain Message-ID: <0dc86df7-a083-6b8f-bca9-52fba273e348@nxp.com> Date: Mon, 11 Dec 2017 19:27:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131574734186723982; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(336005)(346002)(39860400002)(39380400002)(376002)(2980300002)(1109001)(1110001)(339900001)(189003)(199004)(24454002)(36756003)(81166006)(2906002)(498600001)(81156014)(53936002)(58126008)(6246003)(68736007)(8676002)(65806001)(77096006)(2486003)(65956001)(230700001)(229853002)(305945005)(47776003)(67846002)(83506002)(23676004)(105606002)(356003)(316002)(76176011)(104016004)(97736004)(85426001)(5660300001)(106466001)(65826007)(31686004)(33646002)(2950100002)(6916009)(50466002)(64126003)(4326008)(86362001)(8936002)(31696002)(6666003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2689; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD027; 1:HK9zj0EPfLxzbaBPtNXQDebJGA6UHZrDldVlFu93mfpT5ZVwxXnhoZB8T/qAdMvpbWHtDaOeafYYPsRGwdOFec39rYaSfVVatFY2qlk+wNXCGGs9UQQyJfyWpyRx7bYN X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c4742e4-3156-494a-ba8e-08d5409d2f14 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603307); SRVR:BN6PR03MB2689; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2689; 3:Z45j4FMTIUAcLJbTGBaBf6CrT2liqnnBzMZ07Et0a5uv5ubw2KzmbCFc+sRzDgUAd8tMSj7Y+JmjQrT2KEdDDJIfyqsEFn1sckbIQaoj/DNPHUxaWJY4wUYqVCco7ADEI4wnXOn/meQFsqexlGz50Gx9+H6wp17+W9YaS+50D9idRcx6Y8o7R5iO0cBtL8f753Kxdbhfm+6I2uQoKiNlvlHZrv7PCD91B/dXW///NV6beuXVKcn+sJlp1j342jjQ2ONXOLSkyRZ17eb/Kzeh6DcuqMdosR+0mSSvqTSrkAdHTUu0iqeREbiIspUtpOROiluOWvGcs1GMQX+0ZYOLWlGG4IYRGMpfUV30CpCyBjc=; 25:x5qfOemXzt3UiZYni1uKkUV40AVmfkb8wifRKMRurec4WmNfVoEBagLM2COAN58joMUbZtwG9+3eIy68mankjEOY+MUswT64UEFLGfcw/hOFP+Zb8ErVJ+tR8nZ6jkjVRUbCwD4LS80RH+JZLyhGIWcN/y+MANUhWBlkuMp/NXtbF99W29AEpLouZiHuV30OFuQBfDqf8MeZ50PHPuq8ggMNNrSaom52jyJ2wWmLQL4zzylo41RgRVAGmN3NTTpoRPWg0mOakndXjt6PP7IcF+OcJo+a5Ga+jSTgT8NfPpxqK47QHQohk029tjoiaqwXITZLgK1g/tTLOL57AS4KXw== X-MS-TrafficTypeDiagnostic: BN6PR03MB2689: X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2689; 31:PXm7VMdcHanD/Dw41xaQSR6PTFbQme8Iptb+42ciL8O2UAi/jxHIZMTFyxiwfjGqUlsZUVMhBI/QIVbWf46zNWqzximtwfiRC25eXnHxt7Y+o2gEHpMdC3gizNVYSH/6Xhn0Seogbhnz4oZbcB9wEPgzYAZXu4Vwyp+LyyDDMOR1UAGu5R/Kq7l8OvWQGvvMAhEu+xIE0D3EjI4ONVI8fdlDj64MwQD4m0qvqMTViu8=; 4:KhYkYbpj4rgygXjD34/xw0AvOLtQh4VemVHlMlPsCLLRaKbif61i590Xj2zXFqtXfQ+9n5OTy75AA9CARYoi0S31Ab0xGYv91MH9258a1KIw7cnzDZDs0B28bCrrbJMRdFiNro+gBPvG1Xlypvp9s4Q94NorZ1pq8xNU25ZxZz0pFLRvSAUizxZlKi6Oc0Rg3/kZ5tXRmzghQ+6wFkwN8sMvEnSbpuOftnP2eq8kYGEvZOzOginw39GQdM2hT0ZivyK8uk8V9s0oNeN7VNVgbQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231022)(3002001)(6055026)(6096035)(20161123561025)(20161123556025)(20161123565025)(20161123563025)(20161123559100)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(201708071742011); SRVR:BN6PR03MB2689; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:BN6PR03MB2689; X-Forefront-PRVS: 0518EEFB48 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyNjg5OzIzOnFKNWMvU01sNTF5S01ST0E4NkR5UHlpSUVB?= =?utf-8?B?bFNzaktoMDBnOEFOaDFyY3BWZTZRUm5aYmhMNjQyWllQWnY3SEFJSlRZdVpG?= =?utf-8?B?RWJ3bmdjUnpGNU1BV3RzRFA5cG0vNFI0SHZiR2tWVlhWc3k4cHVPWVVOdFVl?= =?utf-8?B?bFlZMzFjQVhpeFZ6V3JMQ2hSRHNkWGxMWFdWZElndTQ3bnR0RmRKNXR5Qjhh?= =?utf-8?B?WlBZR0pLM09sUzRWSUR5WEUwaXZBTDVxVEJFQTlkYjhIUmtlclU2d0QyNGhp?= =?utf-8?B?ckloYmFMMGhTN3h0L3BkYTl5dUs1L0xaeUhxd1ErUmlkcS9hZ2JuUlRlM2E4?= =?utf-8?B?VEwvN3J0SFlDZmVLQ3BPZTcvbVpLT1ROTlpSRktkSFBEdnZXK1FCSzFMbGlC?= =?utf-8?B?MC9rKzFUdldtRzVxbTgxcjFJWGErYURxelUwOWVrS3A3WGVsZkdocVRCb2FM?= =?utf-8?B?QStwK2dDRm5vLzZ3OHV3MllEdHM2WnFSSUlGOFMwdWFBQkxaeVQ0S3FVZnNX?= =?utf-8?B?eGRHSDZoZ3krNHVjTnhxL2kyK1JsY093Q3FHMklvSEdaMzNpemhTbHhPeDA3?= =?utf-8?B?L254Um9zSkJkYXFPdHZPbWQyVVNmUlBKa3Y0WWtmOEVPMDNwWGhaejJUY3da?= =?utf-8?B?aTg4NnpVVXcvOGhLL1dkcXI5ckNicGNRbVJESGFackpzcW8zTVVBc3hZUUFw?= =?utf-8?B?WnNxKzluVlZ0ZnJ3MDRjVHZHMGVoSktjUVhjdDRMOE01ZUFFMWVTZFhxM2M5?= =?utf-8?B?OUQ0bjlqV1hZVEh3Y2RkSndhWVpDK094M0tJdEY1TmJxbEZiRDNTakRoY3pD?= =?utf-8?B?aDZ0WjlUYWw3QXJVQ0RpR0Q1SWxvZFBKSUdKWDg2QWZRWlVUenpQSHFLcEFq?= =?utf-8?B?SjBqVm9yd0VpSzN2ckxvSlZrT1U4cDcyRVJqeU1VaHRlS0FZb0RyYzBFT1lJ?= =?utf-8?B?NVI4MmFyQWxNaGFRditSclVsVnRIUyswSHA1RHBuTzRIVm9LcWdiRXBobjZm?= =?utf-8?B?SDlZRWl2bThDVS9oZ3hhS2VqTUNKZjZWNlczNEQxWnZFS2lSQnRsdlB1OFBB?= =?utf-8?B?SVZVZDlHMzRMS2lWR3NoYTU5NWROdGN5YXBBRHJxSVZObjg4RkhGanVsVVRB?= =?utf-8?B?bFIxaG5BOTlscVRmdXFNK2JyRGFJaWlDbElRYmozcDJyUXNjTUVoR292SWVO?= =?utf-8?B?T0tSait3Y2ttbG1CenZORHhxck5iZGhDeU9EVk9UR2xEcFBCS3dQSHorQlhv?= =?utf-8?B?Z2FjTlozVEFHSmx3K3pUcEFxbnRlOS9HcGcwL05LRUdqSXV0TXJ5cmZTOVZ5?= =?utf-8?B?MmtRMVh2K3FtVzIvQ2c3dVZGSlFFL05BeHlmRXFsOTFQdGRDb0RRRHE3NmNB?= =?utf-8?B?VTJ5elQ4OTNmZ05LTTBWeTVTOE9NdmF4VSt4ZTFNVEV4VXFBK3gxdHIrSjJR?= =?utf-8?B?RGFzaW1IejFFL1dLdWNMbmRGZGQ0VEVuT3VnV1l0UHo4cDFiTE5tMkMwc0NI?= =?utf-8?B?eEJrcWdXWWJkU0UyMlVGVmIwUzN6c3hONEtwMVBEa2dEa1VHZ1d6U0d1YmFh?= =?utf-8?B?L1QvRFV2VXdROU1Sa1hkeWNJZnlXWUxkTU5rZmtLdWhGV09aUlV6UWw2SnBX?= =?utf-8?B?OWJnQ3I0eTNnWjNicTVZMWJjNVU2c3hsZ1FkSG1VSU1yQ0xnY2ZWeXlGRUY2?= =?utf-8?Q?bzYR1Wrd+elQR5YyMA+nYMzdWU8TLLT8iNtKrw9?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2689; 6:e6zfHGQbDgSBmzOF5PmOW57VCfn8d1ZunMSEcyRoE/CqrOqjHmimF5Tg9OwPjLB2cafSHx1WbKTaa8iBvUBotQPuIDEy71SeJgN3efTrPT7yLqgejvlTyrbWFO0CW7tpSA2tTeQkI4AFx4nbG6g0/Q1FYtUvIYEM2TdSAr0+Fz3vAkACviBJgJwv21KVJfQKswhR0R3n+sBW1E/CgNBmr4oSBKNfTuBPdvIotmihVLxrwegUF5oOPtQb/7LSw0EsHtrqy36TaLQvQxpa3NflX4j5wd06/dsIq/kDI38KGIs+y4rLZ6FyIm3e63f1R28vJbuGtJ22hMuRSkXkjXBY4MsylrNxnMazfl3ZjHcPxSI=; 5:0jEquCH3FLLERmu+5CNVHvYNf/tlCniUT48hw05J3folxc5spi2tEN2c6ESdXiGTaj09re7YGJZj4Xuf2hag6omRDxVVwZxAnnRnXKA9KrXxJ8tQaCLTMiIgzNstdPrmI+jDjgnVKlXs/uA/kDsz8mTDym/BUfBbTMhpBKpr750=; 24:xtNPKNRvat1clNQNbrhb/1Ofyo/k5cVk7hQN2VFxUIZXppf9RfvKLvYh1cIOdeTyKpR/9yvPJ7tCkGrulXKG+3MI6LbvwUyj3GrQt8Am5S0=; 7:vHQUQCAUyhB7rHRfHIrpnCqHSHZN4fKAPjtAaD6lnnX0TbZ3UXIfqIHr0zEmJ84RzcRrkjXUyt+z5mHu43yrKLdROZwHr2JRaIZCiKaFsrtexXEJP+sFf4y9Z0Cco/7RncrT3E5WtkrgdRTQymBzOvYyyjn96JHnlO6vvuwRuE8VUZZPpZtca1lA/BWjvS50kW4sLgQ79hGT9bzK98/wj8qtykkYZZ17x41dRlIY0sNXlfziT+w0fXdBf6YahkLF SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2017 13:43:38.5007 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c4742e4-3156-494a-ba8e-08d5409d2f14 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2689 Subject: Re: [dpdk-dev] [PATCH v2 01/18] eal: prepend busname on legacy device declaration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 13:43:45 -0000 One very quick comment: On Thursday 12 October 2017 01:51 PM, Gaetan Rivet wrote: > Legacy device options (-b, -w, --vdev) need to prepend their bus name to > user parameters for backward compatibility. > > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/common/eal_common_options.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index 630c9d2..d57cb5d 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -143,13 +143,16 @@ static int mem_parsed; > static int core_parsed; > > static int > -eal_option_device_add(enum rte_devtype type, const char *optarg) > +eal_option_device_add(enum rte_devtype type, > + const char *busname, const char *optarg) > { > struct device_option *devopt; > size_t optlen; > int ret; > > optlen = strlen(optarg) + 1; > + if (busname != NULL) > + optlen += strlen(optarg) + 1; I think you want "optlen += strlen(busname) + 1"; > devopt = calloc(1, sizeof(*devopt) + optlen); > if (devopt == NULL) { > RTE_LOG(ERR, EAL, "Unable to allocate device option\n"); [...]