From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E06AA04AD; Fri, 1 May 2020 15:15:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 102001D97E; Fri, 1 May 2020 15:15:48 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 798161D905 for ; Fri, 1 May 2020 15:15:46 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.64]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 035F460093; Fri, 1 May 2020 13:15:46 +0000 (UTC) Received: from us4-mdac16-73.ut7.mdlocal (unknown [10.7.64.192]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 02349200A4; Fri, 1 May 2020 13:15:46 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.66.34]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 56D8E220059; Fri, 1 May 2020 13:15:45 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 02A8E600097; Fri, 1 May 2020 13:15:45 +0000 (UTC) Received: from [127.0.0.27] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 May 2020 14:15:36 +0100 To: Thomas Monjalon , , , , , , , References: <4816966.qqrk5fENW1@thomas> <20200427095737.11082-1-i.dyukov@samsung.com> <20200427095737.11082-4-i.dyukov@samsung.com> From: Andrew Rybchenko Message-ID: <0deb10b5-2ea0-e319-a23d-893b0c625e1f@solarflare.com> Date: Fri, 1 May 2020 16:15:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200427095737.11082-4-i.dyukov@samsung.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1020-25388.003 X-TM-AS-Result: No-7.857400-8.000000-10 X-TMASE-MatchedRID: +c13yJDs903mLzc6AOD8DfHkpkyUphL9Y/L2/AZJAWSYkF7ZtFfCU3Io zGa69omdrdoLblq9S5rMJYD0aRF0Re3NIrNSYNRXXtKrRcqgYevdhJoeWdkvzRlLPW+8b7SaXVn JfW955om1QZE1sK93/TKHYLsR4q0LTX7PJ/OU3vKDGx/OQ1GV8rHlqZYrZqdI+gtHj7OwNO1YN8 MGeZojKwWSbbrNzj5DOeJ5FCWW8keDgY4CJb7pJaACrwClvLapR+BJpFvaPFSDrTj4P0+NLNOGx 4p4UOZfV2q33m3K5S6RY3PXn4zv2b7xfffy7VaIN8GqyktuUIeQs4WQlGKyYyiQcCX/jvbPwL6S xPpr1/I= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.857400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1020-25388.003 X-MDID: 1588338945-yozKYwR0yiHY Subject: Re: [dpdk-dev] [PATCH v1 3/6] ethdev: remove extra 'new line' in output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/27/20 12:57 PM, Ivan Dyukov wrote: > Signed-off-by: Ivan Dyukov > --- > app/test-pmd/testpmd.c | 2 +- > app/test/test_pmd_perf.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 99bacddbf..d4df23a93 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3005,7 +3005,7 @@ check_all_ports_link_status(uint32_t port_mask) > "Port%d Link Up. speed %u Mbps- %s\n", > portid, link.link_speed, > (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? > - ("full-duplex") : ("half-duplex\n")); > + ("full-duplex") : ("half-duplex")); > else > printf("Port %d Link Down\n", portid); > continue; > diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c > index d61be58bb..352cd4715 100644 > --- a/app/test/test_pmd_perf.c > +++ b/app/test/test_pmd_perf.c > @@ -151,7 +151,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) > "Port%d Link Up. Speed %u Mbps - %s\n", > portid, link.link_speed, > (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? > - ("full-duplex") : ("half-duplex\n")); > + ("full-duplex") : ("half-duplex")); > if (link_mbps == 0) > link_mbps = link.link_speed; > } else > I think Fixes: tag is required here. Acked-by: Andrew Rybchenko