From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0077.outbound.protection.outlook.com [104.47.33.77]) by dpdk.org (Postfix) with ESMTP id 6604C5593 for ; Sun, 4 Feb 2018 07:35:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ly5Aj3ZwiVzA5uPoX8o0HBEyRchhxoCItzwoiPuqTFg=; b=WG22b1/CUxyDMqfDWTqPj4daRp/0BVXrCgQXgfXMgFauwCSqKOJGISCluDcZESzCQC21chmnz4t+E5npK/sj3BR9wLt7JWu/6cgNsU0HeeckhpSoLSxtlyTSF7D8ja6xVjiL28oHlg+VrDI2AeKnlJg7fyutcGP+8/qZlizpRxU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [10.89.1.18] (115.113.156.3) by BY1PR0701MB1894.namprd07.prod.outlook.com (2a01:111:e400:51ab::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Sun, 4 Feb 2018 06:34:56 +0000 To: Hemant Agrawal , dev References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-2-git-send-email-hemant.agrawal@nxp.com> Cc: Olivier MATZ , Jerin Jacob , nipun.gupta@nxp.com From: santosh Message-ID: <0e0099bc-99f5-bd41-cc53-b0ea9ded2f53@caviumnetworks.com> Date: Sun, 4 Feb 2018 12:04:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0047.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::33) To BY1PR0701MB1894.namprd07.prod.outlook.com (2a01:111:e400:51ab::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3f53b7c-6d6f-4d6d-7802-08d56b996975 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:BY1PR0701MB1894; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1894; 3:RPMvdS8N/A0JFq4dakd/leUJHbBizu/kmdIgrVas8PQXFjgTc86hrzenDaVi5gpMZxcl1C5+jxpCfLuY7BtBjQ5XCL2Gkq25zUQWNLFEZUhhHgtpuYrZRWDB/4hDhO1REVqaGbrefxLsq/XSKYmZNRfrAtpwCHYQXCaA7t9O5Y4lQlMYmC4H+boAs1hYisE0lB/bPkr5ty6iLVFyNmUF4g8gxUnAouVAFkdm89vYdSsVbv1jlHT8QHK9sHVsiSXA; 25:LPX8G7RhzdLsvdv4nElN+rZQHsv9qRyBm8bsFu34rRjsE/lTtBe8MsHDqWv6b/1oCWjDD2+z6fCB01wkhHsNRkGfBeuIWGawf8vXCQe066FH2k0RXsca5k9Wx1qBWu6NBH9SmfgzeAMaPVbZD8YNEfWWnKG6FfhvdG0yrcwuAowZdtLFnuRPD1lJUcha4MVvpf/c5pJpsW8SqpgJOp09fkPYefKal2y45aGEhYhm020QrKZyokOsonjoyhVYHjVBcE87KH73q+Ic/9YMLlS1Sukedn2CLqXIy8W97fU+VjxQclJNdfNJCiqv7pmk+26zqEPllJ6eftfBQNATCs5lBg==; 31:RT0pL7AzKLZbuh3OKk0yu+GmwRDrmW3jxsb1q3uy5Ao8EEWrjyE/1FdB6X5Tl2oJl9Ngx6/LfjwXJ1XaVICspJgNTj13TU+s9sgo38gXFfXGdHr7CESnB2mhd3rh4N6mBhVCSGlqPQTuNPU3lPgjbmjVBzfVWZJtEK1WhOW4QvqbcGv/U02m+vaYyOe3+/23oiDuAySY4JOQq5B9YrgFNwkH89pWT7puCHzur+uQMx4= X-MS-TrafficTypeDiagnostic: BY1PR0701MB1894: X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1894; 20:In5p9YI8tEmZ888d1TATwdF1nFHOICRSd1mwdEviqdZqzmmOLMSeC0IIVRU+zG30RXYIX+i67TPQOnNGXsTZsLtE3lINBgdo67r7rHQVtmqRLwITAHFE4EK75dfODVY7o53aZqF2H07oKDiR4Y6GKZxj6joUBoXaT+09e2uK/x67h8DpnsTtkXBLuAl32QVqtgaKg+hgpE91hX2Bzrf2d4oQXiHl4/vnz+25D4qWFrRez5T++tlIdfcsXQJeMGYA8DT59NHk/l+vVfRySsB9fJy73DVir+8OD3igk8LVL32oKM+pcqY8tUpZw3sOOVY5T0ghxYea3aIspmESMAns0r+hQbW+kmUlrcE/Q8pYHBOs29BnRZLkb9ngDl3sFy1FLk7q4dZfaCIy/1EH6AAqQnShFAFsO7Y8z2iUGB8xC1/C6wLO8E27kyzkG2PVQmvJwEjSibmoW8UUlZwBptK678Zs5VhxQ0If18LgpSut1jPffXoWuB3xDSBdCPrVtwqS7IWrjgl3Il6xg3cA5c/KpISdPKjqHqD/FLcSiGRqyYWwUbMvMs7XePEJnGBgrYEIO20567tH6OOqUzJqCJN/BrzacFGBoEZzAq641J7yHfQ=; 4:XeMNyAshG/uX2PJ5XTeCHTTO6p9t1Ylg1sWKcR7eFzD8gYr8EvP+IOAPpDsGXgR0KTDtSGm5Crv1pl+rwp8lCe4pcqhHfUinih5h9C1kYb72+6oj4B9L/oWLkVm98xS2rFktRYft8iuHrdBaLLlsRkCmoYw3G+t/WTkVNxXz1U8vs+nKJOG/lTHspE2nYEfZXKHkuLhjtNhcXnIWM50qlNqSATkdyzNN89pan/UGSuV1vn6KX78OR4QL2sxtNfhlJ4CLxNTVPaMiYI9mwlqKCyC4l3x3MVc2WaB1gYj7sR1lkjwXfLp4E9xF+rHhZhAm X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(3231101)(2400082)(944501161)(6041288)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:BY1PR0701MB1894; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1894; X-Forefront-PRVS: 05739BA1B5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39380400002)(366004)(39850400004)(376002)(346002)(396003)(189003)(199004)(478600001)(77096007)(72206003)(68736007)(6486002)(186003)(305945005)(26005)(4326008)(7736002)(229853002)(65826007)(8936002)(81166006)(8676002)(230700001)(42882006)(2950100002)(6666003)(5660300001)(81156014)(53936002)(83506002)(8656006)(2906002)(3846002)(6116002)(110136005)(316002)(58126008)(16576012)(54906003)(50466002)(6246003)(64126003)(575784001)(106356001)(55236004)(386003)(31686004)(2486003)(105586002)(52146003)(23676004)(86152003)(52116002)(36756003)(76176011)(16526019)(97736004)(93886005)(31696002)(65806001)(65956001)(25786009)(47776003)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1894; H:[10.89.1.18]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjA3MDFNQjE4OTQ7MjM6bjc0bHZlM1RtWkcrVngxUnB5bHpNOE10?= =?utf-8?B?QXdIT2FkRlU0ZmtsMDR5STVvcmZLQ2RMc2JXQTBMd1IzVXo4Q1ViOXNaOGlk?= =?utf-8?B?ZncyNC9XKzVEQ3RhUWFaOGRFbVJvcVExNEc2SzlYWGdPaXorMHAxTVN2QUFJ?= =?utf-8?B?aHFSelRZeE1QUDNUcytYT3R1eDlETnhxRVAzQzRYcFB6M2lHR1JSWS9aaWxE?= =?utf-8?B?blRSSUtzY0JvQTh6MmFYOXFYU3lhZEtpVzRGblpIU3lmY0g3QStRd3VpUGVF?= =?utf-8?B?NXd0SzBoWTAxLzJncmUzNEZGblFsNHdmRElBdjNxbThJWGgva0YrampXSGFM?= =?utf-8?B?OGp4RnNndzZqZFJzUkJtT1h4WE1wdGNwb0I5VXhzcEIwYU5kYnBmQ1pYWm9C?= =?utf-8?B?elg5eTZ6QmFMNjRsRjJmRWc5Nzl6emRFczVKRlFTVThTRDUvc0lTWG9iWFJw?= =?utf-8?B?VUZsYWUxS3NmSGxLenZHWDBiMlJZM1ZQTG1lNGlHbWszVW9aVDZlZW9lSXFh?= =?utf-8?B?UnFNOEtLcEJKaHVySGhjcFB6d3ZBbXRRZzkzT0ZXQlJ0QTVJTHg4OVRTTktl?= =?utf-8?B?NXNSc2I5b3FaZmNaSUs1cUpoYUNzbjVIV3lHNUJwQVJkcGQvV1QvNjFWN3I5?= =?utf-8?B?Z1IxMDRKK05YbU13L0pxOWg4SUNuSVBsZDhta1c0c2JiQzZNQUR5czFzdmli?= =?utf-8?B?clhOcktPZDQ1OGVuTXdrOTRIa3FMRm5IL2pKODRabG9CdjA1SUYrdlZMYS9I?= =?utf-8?B?d2FuU3d4eXlPYmwxbmhuYmtoUjlLdG9KTmdCMDJxeFhzWjNMN3dmV1kyS0E1?= =?utf-8?B?bHluNU9Hb05qcEk2TG1vaDgrbUtxR252d2VmVS9CeENLT3h4NFJOVnFxS0Qz?= =?utf-8?B?SWZnTEJiZ1JGY1lLeUZQTVhtYW5xRlorT0grVFZUdXNXMldQZlVIblNEdk9r?= =?utf-8?B?cSsvbFZmZUpvWFhRQnBjMWVxNUpmK20vWmVmTTBwWlNrM2dUdmhwaGw5emRr?= =?utf-8?B?WnFhWnMvb1RXb3pocU01SSt5K0liQVJHOU9NZVc4cXFENXE3WGVLKy9xTEh5?= =?utf-8?B?MlgzV1liN0t2dHdjWlpRL3Q3b0xITWNPSlZKVGR3UEkxWGg4L0NKa1lyY1c3?= =?utf-8?B?TnczdS9EZ095cFJiUmtCbEszR2pGRW9PYzkyOTJqcy9YUHJscmZPajhuVGJx?= =?utf-8?B?ZnMzZ09mK0xDSTBQWDZWU001a2V5V0tKRUpnWW9pQ09SY3huYlk5OXBqcFBa?= =?utf-8?B?ZDFUcDNxREoyM01Eanh5aW1YRjVhNHBHMS9GR2MzU0NEYjl0K0RUUWF2dTVr?= =?utf-8?B?UWxRNnNwOC8wM0xkMWpjTGMwWnN6a2FCRWNQdVp0WmxOK1ZjcmJkbEl0aDQ1?= =?utf-8?B?TVorWmNXNExEWWN0Ymx1cnh3bk1GcXlwOEFiYTJGcWZYMFFPRHpEbmhDNjFL?= =?utf-8?B?VzJxUTJ2UGlMQUZDellXQ3hDY1NQTGtsM0lHOEViNEJSQ3RFRCtVd0JWZjJy?= =?utf-8?B?YnZOSmY2YXc5Rk5mN1psbjJRYytmS1NGYS8wbjFPa2p1RlVwWkVkNFVPYUkv?= =?utf-8?B?WTc0WVd2U0pCWTVEaHJFdTkvOU9RMGJvVEFSWEZuMURONWE0R2VtRG5TcGtE?= =?utf-8?B?QXVZbEpqSG5jTEl0MWo1YnB5T0NxSTdYVHRld0V2NkZVTitZb0t5Y0g2cldO?= =?utf-8?B?RWVKYzFxdFUxcGNReG9FeXY3cFFobkhZZzNxOGpzVkpVbWFGL1dZblUzSkgy?= =?utf-8?B?aXRrUEt3RFp1ajlMUXJNdDZyekkrdjFjT0lYa1dMMFl2OFd1ZElzV0NKWjZD?= =?utf-8?B?ZzNGMkNMbUVBdENXb2dKd1EwNmVxQWpYSmZNbWpaYjJIV1c3K04rY05lVVZo?= =?utf-8?B?cUpCeVdYdCtjWGtqZmVJNVZvSmNNVTVaOWNPOUdFWERzdEJqNi9wY1BROExC?= =?utf-8?B?U3BWS3MwTWZCb2hSR2w0dUFuamlEbUdxQ0l6bm4zTUZEdk1vN240R3NDTHpD?= =?utf-8?B?dndPdUpTMTlRVFcxbnNMaWZwUjlJUXJ1WGxFM0dnPT0=?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1894; 6:Fixa7pEfNZF7WmAQ+coddOpbt4oeI1cErFQ0brde7zg6aXj7b/rJd9QFFTZV6us57ThN51yfDORn2kjtWdRnQqAJwLlx8qV2jam6nv3ZgcIQIHMHYqRWuKq8bm4K+ai3Xas6UVw5bIULMF6v2PkKlWm5lAMkp2hHLTaCckvk2i5E+O6E2/uY6Nuug3hY+n6usMk8IQ0kP7I9SNhAtK48DMUzCYY3AVOcvlnKUec6yTFM2igH98XmdEkEtVTaBK3BGZoMbw6tn21ZP8GayztdjY+9UR/7PWiCGG6w/d2Nafj3B3h78c/MauKm0zFmP7nRcSE2eOWZ0JcK2KjOCMSr3yQwXBMe1M4TCuoqdKa731w=; 5:ODyunHOgO1A3naQ10wkPxM0D6aGcl8LjF1qFUX3CUjIDdOh6vFLAhNiYVY05mPPLJONeTjLxYCkrXmsZ+Ggqa7WA0FiEQtuIi60QTUyGkDvoUS4ZUQBCFA3f//zHZr5cO5nmFm/lbQGKW4lb86+qv9OnD2wM7ykzadiqjZ/Ot/A=; 24:2jeHUi1BCtF6/dlpSehrjX/BGtuem6SEuMMou/AeeV1kX4bTbr8IiwkZg3OdbmMyI2HywaHFPL1Rl1qd+bIAr2orEfwlH66yAfL1tA1XMXI=; 7:npJiRiUb2KLbeGWq4vjH15THClqB5uVJZ0PdwcJGfyRfvHRuAo+pEHGOHMbJ5wk3jdompkqO6GwO1YkeM9jybqz8Ws8hJ+bI1EHx7/RCCaFRafSp0/6p0qjx9eR3HcfqLwSG7YUiO2uYLPrZkWkUuD9I+SZm2wIo5eN396XLbcg98BMOp57MuaOAQKVk2IC5kl2wnwpH9Ly5NfeSP/uu/wdigTRZQykiVd8iaBF/NhoDh2j35cs87dpGX5BG60ER SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2018 06:34:56.7517 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b3f53b7c-6d6f-4d6d-7802-08d56b996975 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1894 Subject: Re: [dpdk-dev] Fw: [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Feb 2018 06:35:01 -0000 Hi Hemant, On Sunday 04 February 2018 11:52 AM, Shukla, Santosh wrote: > The existing rte_eal_mbuf_default mempool ops can return the compile time > default ops name if the user has not provided command line inputs for > mempool ops name. It will break the logic of best mempool ops as it will > never return platform hw mempool ops. > > This patch introduces a new API to just return the user mempool ops only. > > Fixes: 8b0f7f434132 ("mbuf: maintain user and compile time mempool ops name") > > Signed-off-by: Nipun Gupta > --- This patch introduces regression for octeontx platform. Fails with: --------- testpmd: create a new mbuf pool : n=163456, size=2176, socket=0 testpmd: preferred mempool ops selected: dpaa dpaa_mbuf_create_pool(): bman_new_pool() failed EAL: Error - exiting with code: 1 ---------- Command: ./testpmd -c 0xe00000 -n 4 -- --portmask 0x1 --nb-cores=2 --port-topology=loop --rxq=2 --txq=2 --rss-ip --no-flush-rx ------------- It's because rte_dpaa_bus_probe() sets platform mempool ops i.e. rte_mbuf_set_platform_mempool_ops(DPAA_MEMPOOL_OPS_NAME); therefore `rte_mbuf_best_mempool_ops` returns with `dpaa` ops which is incorrect mempool_ops choice for octeontx platform. We can fix such regression with following ways: # option 1) unset LIBRTE_DPAA_MEMPOOL=y from common_armv8a_linuxapp config and set at dpaa/dpaa2 specific configs commit: 1ee9569576f6 ("config: enable dpaaX drivers for generic ARMv8") # option 2) Don;t set platform mempool ops in dpaa bus layer instead defer it to driver layer. Thanks.