From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id DE4A21B107
 for <dev@dpdk.org>; Wed, 19 Sep 2018 20:04:53 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 19 Sep 2018 11:04:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.53,394,1531810800"; d="scan'208";a="74338753"
Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39])
 ([10.237.221.39])
 by orsmga007.jf.intel.com with ESMTP; 19 Sep 2018 11:04:49 -0700
To: David Marchand <david.marchand@6wind.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>,
 Thomas Monjalon <thomasm@mellanox.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <20180903144501.31373-1-ferruh.yigit@intel.com>
 <20180904101257.61129-1-ferruh.yigit@intel.com>
 <DB7PR05MB442643D0A61E46F2A9642223C3030@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <a7389432-1492-d836-5dcc-9919193b9c9c@intel.com>
 <CALwxeUuAvjjCc9CJvaWqdV0XvhmFo=yWCUK8teebu2Z4HtukMQ@mail.gmail.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Openpgp: preference=signencrypt
Message-ID: <0e066e8b-5eb2-20a5-6ce8-9af097dfad89@intel.com>
Date: Wed, 19 Sep 2018 19:04:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CALwxeUuAvjjCc9CJvaWqdV0XvhmFo=yWCUK8teebu2Z4HtukMQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip
 on Rx
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Sep 2018 18:04:54 -0000

On 9/19/2018 8:34 AM, David Marchand wrote:
> Hello Ferruh,
> 
> On Fri, Sep 14, 2018 at 1:37 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> On 9/4/2018 11:02 AM, Shahaf Shuler wrote:
>>> Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit:
>>>> Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx
>>>>
>>>> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag.
>>>> Without any specific Rx offload flag, default behavior by PMDs is to
>>>> strip CRC.
>>>>
>>>> PMDs that support keeping CRC should advertise
>>>> DEV_RX_OFFLOAD_KEEP_CRC
>>>> Rx offload capability.
>>>>
>>>> Applications that require keeping CRC should check PMD capability first
>>>> and if it is supported can enable this feature by setting
>>>> DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure()
>>>>
>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>> Acked-by: Tomasz Duszynski <tdu@semihalf.com>
>>>> ---
>>>> v2:
>>>> * fix flag check
>>>> * add KEEP_CRC flag into "show port cap #"
>>>>
>>>>   Note "show port cap #" and
>>>>   "show port # [r/t]x_offload capabilities/configuration"
>>>>   does same thing, in long term I suggest removing "show port cap" one
>>>
>>>
>>> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>>>
>>
>> Applied to dpdk-next-net/master, thanks.
> 
> Should we have a little note about this api change in 18.11 release notes ?

Right, I will send a patch for it.