From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 8BE4D532C for ; Tue, 18 Sep 2018 18:54:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 09:54:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,390,1531810800"; d="scan'208";a="258304232" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by orsmga005.jf.intel.com with ESMTP; 18 Sep 2018 09:54:12 -0700 To: Dan Gora , dev@dpdk.org Cc: Igor Ryzhov , Stephen Hemminger References: <20180911232906.18352-1-dg@adax.com> <20180911232906.18352-2-dg@adax.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <0e366549-2ae6-2e70-6e60-7e5970b1a98e@intel.com> Date: Tue, 18 Sep 2018 17:54:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180911232906.18352-2-dg@adax.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] kni: add API to set link status on kernel interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 16:54:17 -0000 On 9/12/2018 12:29 AM, Dan Gora wrote: > Add a new API function to KNI, rte_kni_update_link() to allow DPDK > applications to update the link status for KNI network interfaces in > the linux kernel. > > Signed-off-by: Dan Gora +1 to sysfs implementation. But right now this API is not used at all which makes it hard to test and catch when API broken. Can you please implement the API either on kni sample app or kni unit test? Also you need to add new API to .map file for shared library build. (you would catch this if API implemented somewhere...)