From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2B4AA0564; Fri, 12 Mar 2021 02:01:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3C484067E; Fri, 12 Mar 2021 02:01:16 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 3EF4B4014D for ; Fri, 12 Mar 2021 02:01:16 +0100 (CET) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DxSBj5y25z17Jvv for ; Fri, 12 Mar 2021 08:59:25 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Fri, 12 Mar 2021 09:01:11 +0800 To: Ferruh Yigit , References: <1615356985-24722-1-git-send-email-humin29@huawei.com> <1615356985-24722-2-git-send-email-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: <0e3706cc-634f-9d3d-185b-86ba853c36c1@huawei.com> Date: Fri, 12 Mar 2021 09:01:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 1/9] net/hns3: support runtime config to select IO burst func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/3/12 1:39, Ferruh Yigit 写道: > On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng >> >> Currently, the driver support multiple IO burst function and auto >> selection of the most appropriate function based on offload >> configuration. >> >> Most applications such as l2fwd/l3fwd don't provide the means to >> change offload configuration, so it will use the auto selection's io >> burst function. >> >> This patch support runtime config to select io burst function, which >> add two config: rx_func_hint and tx_func_hint, both could assign >> vec/sve/simple/common. >> >> The driver will use the following rules to select io burst func: >> a. if hint equal vec and meet the vec Rx/Tx usage condition then use >> the neon function. >> b. if hint equal sve and meet the sve Rx/Tx usage condition then use >> the sve function. >> c. if hint equal simple and meet the simple Rx/Tx usage condition then >> use the simple function. >> d. if hint equal common then use the common function. >> e. if hint not set then: >> e.1. if meet the vec Rx/Tx usage condition then use the neon function. >> e.2. if meet the simple Rx/Tx usage condition then use the simple >> function. >> e.3. else use the common function. >> >> Note: the sve Rx/Tx usage condition based on the vec Rx/Tx usage >> condition and runtime environment (which must support SVE). >> >> In the previous versions, driver will preferred use the sve function >> when meet the sve Rx/Tx usage condition, but in this case driver could >> get better performance if use the neon function. >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Min Hu (Connor) > > <...> > >> + >> +    rte_kvargs_process(kvlist, "rx_func_hint", &hns3_parse_io_hint_func, >> +               &rx_func_hint); >> +    rte_kvargs_process(kvlist, "tx_func_hint", &hns3_parse_io_hint_func, >> +               &tx_func_hint); >> +    rte_kvargs_free(kvlist); > > If you will continue with the device argument method, those should be > documented in the device documentation, you can have a section as > "Runtime Config Options" and can detail new devargs there. > > Also 'RTE_PMD_REGISTER_PARAM_STRING' should be added for new devargs. > . ok, I will do it in V3, thanks.