Re: [PATCH v3] ethdev: introduce dump API

["Min Hu (Connor)" <humin29@huawei.com>]

Hi, Ferruh,

在 2022/2/10 23:50, Ferruh Yigit 写道:
> On 2/10/2022 1:22 PM, Ferruh Yigit wrote:
>> On 2/10/2022 1:16 PM, Min Hu (Connor) wrote:
>>> Hi, Ferruh,
>>>
>>> 在 2022/2/10 20:37, Ferruh Yigit 写道:
>>>> On 2/9/2022 1:21 AM, Min Hu (Connor) wrote:
>>>>> Added the ethdev dump API which provides querying private info from 
>>>>> ethdev.
>>>>> There exists many private properties in different PMD drivers, such as
>>>>> adapter state, Rx/Tx func algorithm in hns3 PMD. The information of 
>>>>> these
>>>>> properties is important for debug. As the information is private, 
>>>>> the new
>>>>> API is introduced.
>>>>>
>>>>> Signed-off-by: Min Hu (Connor)<humin29@huawei.com>
>>>>> Acked-by: Morten Brørup<mb@smartsharesystems.com>
>>>>> Acked-by: Ray Kinsella<mdr@ashroe.eu>
>>>>> Acked-by: Ajit Khaparde<ajit.khaparde@broadcom.com>
>>>>> ---
>>>>> v3:
>>>>> * change 'ethdev' to 'device'
>>>>> v2:
>>>>> * fixed comments from Ferruh.
>>>>> ---
>>>>>   doc/guides/rel_notes/release_22_03.rst |  7 +++++++
>>>>>   lib/ethdev/ethdev_driver.h             | 23 +++++++++++++++++++++++
>>>>>   lib/ethdev/rte_ethdev.c                | 17 +++++++++++++++++
>>>>>   lib/ethdev/rte_ethdev.h                | 20 ++++++++++++++++++++
>>>>>   lib/ethdev/version.map                 |  3 +++
>>>>
>>>>
>>>> Btw, can you please confirm that there will be a PMD implementation
>>>> in this release, (it can be after -rc1)?
>>
>>> YES, I will send a set of patches about hns3 PMD implementation once the
>>> API is accepted.
>>
>> ack, thanks.
>>
> 
> in fact process document [1] requires at least draft PMD implementation
> ready to apply the API change [2].
> 
> Can be possible to send a draft, simple PMD implementation tomorrow, to
> justify API design? It can be improved later after -rc1 with new versions.
> 
I have sent a set of patches named 'dump device info', which includes:
a.[patch V4] ethdev: introduce dump API
b. a set of hns3 implementation:
   net/hns3: dump device basic info
   net/hns3: dump device feature capability
   net/hns3: dump device MAC info
   net/hns3: dump queue info
   net/hns3: dump VLAN configuration info
   net/hns3: dump flow director basic info
   net/hns3: dump TM configuration info
   net/hns3: dump flow control info

Please check it out, thanks.

> 
> [1]
> doc/guides/contributing/patches.rst
> 
> [2]
> * At least one PMD should implement the API.
>    It may be a draft sent in a separate series.
> .