From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D3E0A00BE; Fri, 11 Feb 2022 05:52:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BAAF41144; Fri, 11 Feb 2022 05:52:48 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id F2423410E5 for ; Fri, 11 Feb 2022 05:52:46 +0100 (CET) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Jw1Mw6b8xzZfSv; Fri, 11 Feb 2022 12:48:28 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Fri, 11 Feb 2022 12:52:43 +0800 Subject: Re: [PATCH v3] ethdev: introduce dump API To: Ferruh Yigit , CC: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Ray Kinsella , Ajit Khaparde , Thomas Monjalon , Andrew Rybchenko , David Marchand References: <20220111115437.32855-1-humin29@huawei.com> <20220209012106.23404-1-humin29@huawei.com> <60e29397-888b-0132-25b9-e9d470be3a5d@intel.com> <860bd211-e9cc-fb91-a6d5-553172f128d4@huawei.com> <3aca3a4c-3703-221b-ab88-524030ec18ab@intel.com> From: "Min Hu (Connor)" Message-ID: <0e3c3ed3-5aa0-c32a-e1d4-bcfdedf90f0d@huawei.com> Date: Fri, 11 Feb 2022 12:52:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Ferruh, 在 2022/2/10 23:50, Ferruh Yigit 写道: > On 2/10/2022 1:22 PM, Ferruh Yigit wrote: >> On 2/10/2022 1:16 PM, Min Hu (Connor) wrote: >>> Hi, Ferruh, >>> >>> 在 2022/2/10 20:37, Ferruh Yigit 写道: >>>> On 2/9/2022 1:21 AM, Min Hu (Connor) wrote: >>>>> Added the ethdev dump API which provides querying private info from >>>>> ethdev. >>>>> There exists many private properties in different PMD drivers, such as >>>>> adapter state, Rx/Tx func algorithm in hns3 PMD. The information of >>>>> these >>>>> properties is important for debug. As the information is private, >>>>> the new >>>>> API is introduced. >>>>> >>>>> Signed-off-by: Min Hu (Connor) >>>>> Acked-by: Morten Brørup >>>>> Acked-by: Ray Kinsella >>>>> Acked-by: Ajit Khaparde >>>>> --- >>>>> v3: >>>>> * change 'ethdev' to 'device' >>>>> v2: >>>>> * fixed comments from Ferruh. >>>>> --- >>>>>   doc/guides/rel_notes/release_22_03.rst |  7 +++++++ >>>>>   lib/ethdev/ethdev_driver.h             | 23 +++++++++++++++++++++++ >>>>>   lib/ethdev/rte_ethdev.c                | 17 +++++++++++++++++ >>>>>   lib/ethdev/rte_ethdev.h                | 20 ++++++++++++++++++++ >>>>>   lib/ethdev/version.map                 |  3 +++ >>>> >>>> >>>> Btw, can you please confirm that there will be a PMD implementation >>>> in this release, (it can be after -rc1)? >> >>> YES, I will send a set of patches about hns3 PMD implementation once the >>> API is accepted. >> >> ack, thanks. >> > > in fact process document [1] requires at least draft PMD implementation > ready to apply the API change [2]. > > Can be possible to send a draft, simple PMD implementation tomorrow, to > justify API design? It can be improved later after -rc1 with new versions. > I have sent a set of patches named 'dump device info', which includes: a.[patch V4] ethdev: introduce dump API b. a set of hns3 implementation: net/hns3: dump device basic info net/hns3: dump device feature capability net/hns3: dump device MAC info net/hns3: dump queue info net/hns3: dump VLAN configuration info net/hns3: dump flow director basic info net/hns3: dump TM configuration info net/hns3: dump flow control info Please check it out, thanks. > > [1] > doc/guides/contributing/patches.rst > > [2] > * At least one PMD should implement the API. >   It may be a draft sent in a separate series. > .