From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id DA13D1B37B
 for <dev@dpdk.org>; Mon,  5 Feb 2018 15:21:50 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 05 Feb 2018 06:21:49 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,464,1511856000"; d="scan'208";a="24952200"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91])
 ([10.237.220.91])
 by FMSMGA003.fm.intel.com with ESMTP; 05 Feb 2018 06:21:48 -0800
To: Yuanhan Liu <yliu@fridaylinux.org>, Stefan Hajnoczi
 <stefanha@redhat.com>, Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Junjie Chen <junjie.j.chen@intel.com>,
 Changpeng Liu <changpeng.liu@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>
References: <20180131174828.6936-1-stefanha@redhat.com>
 <20180201144742.GR29540@yliu-mob>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <0e8c66d8-3265-8088-f026-6a13f039cf47@intel.com>
Date: Mon, 5 Feb 2018 14:21:47 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180201144742.GR29540@yliu-mob>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented
 EVENT_IDX feature bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Feb 2018 14:21:51 -0000

On 2/1/2018 2:47 PM, Yuanhan Liu wrote:
> On Wed, Jan 31, 2018 at 05:48:28PM +0000, Stefan Hajnoczi wrote:
>> The vhost_scsi example application negotiates the
>> VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing
>> vrings.
>>
>> In particular, commit e37ff954405addb8ea422426a2d162d00dcad196 ("vhost:
>> support virtqueue interrupt/notification suppression") broke vring call
>> because vq->last_used_idx is never updated by vhost_scsi.  The
>> vq->last_used_idx field is not even available via the librte_vhost
>> public API, so VIRTIO_RING_F_EVENT_IDX is currently only usable by the
>> built-in virtio_net.c driver in librte_vhost.
>>
>> This patch drops VIRTIO_RING_F_EVENT_IDX from vhost_scsi so that vring
>> call works again.
>>
>> Cc: Changpeng Liu <changpeng.liu@intel.com>
>> Cc: Junjie Chen <junjie.j.chen@intel.com>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> Acked-by: Yuanhan Liu <yliu@fridaylinux.org>

Applied to dpdk-next-net/master, thanks.