From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA080A04B5; Thu, 29 Oct 2020 15:28:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB996CDF4; Thu, 29 Oct 2020 15:28:12 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A65CBCDE5 for ; Thu, 29 Oct 2020 15:28:11 +0100 (CET) IronPort-SDR: NtDBveKR/U91quqTS3xwDUroZMTucjRrbFv9a164xHgEVD9E2UJShxEjNgMTmQonaqsq8LtuvT vcthrxL8H9vQ== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="230077602" X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="230077602" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 07:28:09 -0700 IronPort-SDR: rNi6wBkmdcEa0NGsuzaP7LSZRQ3F14Fghuf8AnVG8H2FivMc9DZ/0I8x1MLki+ySH1YPRYU4GW fuw55ISEyE6A== X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="536689066" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.251.183]) ([10.213.251.183]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 07:28:07 -0700 To: Raslan Darawsheh , Bing Zhao , "viacheslavo@mellanox.com" , "matan@mellanox.com" Cc: "dev@dpdk.org" , Ori Kam , Andrey Vesnovaty References: <1603733085-271968-1-git-send-email-bingz@nvidia.com> From: Ferruh Yigit Message-ID: <0ec66de5-406f-1ca6-dfac-902af888eb60@intel.com> Date: Thu, 29 Oct 2020 14:28:04 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix bit field compiling error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/2020 6:07 PM, Raslan Darawsheh wrote: > Hi, > > >> -----Original Message----- >> From: Bing Zhao >> Sent: Monday, October 26, 2020 7:25 PM >> To: viacheslavo@mellanox.com; matan@mellanox.com >> Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh >> ; Andrey Vesnovaty >> Subject: [PATCH] net/mlx5: fix bit field compiling error >> >> Some old compilers and old specification will not support bit field >> with other types except integer or unsigned integer. >> Since the next and previous items are 64b and/or 32b aligned, bit >> field with "unsigned char" type will not save any space and the >> compiler will complain. >> Changing it to "unsigned int" type bit field will solve the issue. >> >> Fixes: f711b60d400b ("net/mlx5: modify hash Rx queue objects") >> Cc: andreyv@nvidia.com >> >> Signed-off-by: Bing Zhao >> --- >> drivers/net/mlx5/mlx5.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h >> index c537af9..e5640c1 100644 >> --- a/drivers/net/mlx5/mlx5.h >> +++ b/drivers/net/mlx5/mlx5.h >> @@ -733,7 +733,7 @@ struct mlx5_ind_table_obj { >> struct mlx5_hrxq { >> ILIST_ENTRY(uint32_t)next; /* Index to the next element. */ >> rte_atomic32_t refcnt; /* Reference counter. */ >> - uint8_t shared:1; /* This object used in shared action. */ >> + uint32_t shared:1; /* This object used in shared action. */ >> struct mlx5_ind_table_obj *ind_table; /* Indirection table. */ >> RTE_STD_C11 >> union { >> -- >> 1.8.3.1 > > Patch squashed into relevant commit in next-net-mlx, > Hi Raslan, Updating patches that has been pulled by next-net makes very hard to pull your tree. Can you please squash only ones that are still only in the mlx tree, for others I can update in the next-net which is easier than resolving conflicts on merge. Thanks, ferruh