From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2287442672; Fri, 29 Sep 2023 15:48:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B3F1402AA; Fri, 29 Sep 2023 15:48:53 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2054.outbound.protection.outlook.com [40.107.101.54]) by mails.dpdk.org (Postfix) with ESMTP id 8ED3A40287; Fri, 29 Sep 2023 15:48:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZqETz0Yeq5QVUetZM7BsOMlOJPYdVH6ij2V83tjRs1hS0iXKM+nvLyvJpoamXmwAcvkMOdFeSyJk7HlR3+Lk44nBxL48Bu8fzjAr7/pqYBV2VxYG6UUjbiO5LiPVfSGohCSwXld4Lq35/xib5mUiuZLW9tRqz/pyCMFCXA0AmhbG/T7MjTJ0c6vWqLRB8rzNnYSA/Oh5Pi32IlXuJ+iNzHyw+Qm3hXZrqKhd8cnlcjlI6Ru7g0u9bWMP3wdCDRL78dgkjTKb01xmx5yQBpL5gmeeLLWJaalkXKL6KFJEqHOrrU22rrz7nqwGOixrnkfRauxENkYElfyCksdfjGwh2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kk71PE31RL1xJ647XXWX+VVOPuXb5H+upzowHh8fY40=; b=M+LnzLFpwZNqsVH47cLgelRiAAYwGGWgaDtmiL/tYPelmnEPCR2fRTLekfQZJxeh578ckITLh1YgpRKAqG+oGpPbguaeVdN/L3BtdK/4VzKOLAABxVJGTxYYJ+hAjhpBPhxx44L9jEm3hguQ/+EVQXNfVcmY70URvfZyTBjao0dMzYjSyKRdQMse/jDAoC2L/fF+9P2BUB1Nqp0kvGActnwmiedEOaB4xsVyl2m1vx/SNRSIJg2UrCWcnb3J6qo2DwdfTVl2Tn25YWK1Ny+sc5yQ0cvMSBGAnCe6OnUSxxQZSpk5Ikezm7zg/2dfeZm1UihtdLV4xi2XbwYlgtr86w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kk71PE31RL1xJ647XXWX+VVOPuXb5H+upzowHh8fY40=; b=kW7L4lO01HXn7zgxJsqBLVHcQt12lZAvIVXiAYzB4zZGSSIO0gYr8x4zjaaiRoDwwFoh6etnXBryaajRnj4ZQ+50bPwK85LONd+OxCs6B2HFV1K5tNnjWTFRKLrebWRWVQ3pET1FYPjVkXJYJOGWYNPjNE6dJBi/kLKoCYs+uc0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY5PR12MB6081.namprd12.prod.outlook.com (2603:10b6:930:2b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.27; Fri, 29 Sep 2023 13:48:49 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6838.024; Fri, 29 Sep 2023 13:48:49 +0000 Message-ID: <0eccde0d-6fdd-4351-87c5-930b22ac2d0d@amd.com> Date: Fri, 29 Sep 2023 14:48:43 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le Content-Language: en-US From: Ferruh Yigit To: Stephen Hemminger Cc: David Christensen , dev@dpdk.org, stable@dpdk.org References: <20230322212439.524725-1-drc@linux.vnet.ibm.com> <20230323170145.129901-1-drc@linux.vnet.ibm.com> <165a233b-b41b-3a65-1866-5b7c94993b40@amd.com> <20230515162032.36a4f3ec@hermes.local> <20230515182838.08e49a7c@hermes.local> <44fb2571-8f96-570d-cb35-210fa5f52d9f@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <44fb2571-8f96-570d-cb35-210fa5f52d9f@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0038.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY5PR12MB6081:EE_ X-MS-Office365-Filtering-Correlation-Id: b010437f-d729-4cd9-f554-08dbc0f2cefa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LltrRVU2Redv976EMz9u9DVHXwYz9ClkkEbB6zIcbsFcYwYSLSXAlWRtXu9z6Z/Sd/GmVY0v/SoG372Xe98oWY7DjsWDtqnN1x9GDDFiGam0P/2bHxToOeTwwgpuyuNFUfCQx+NIrqkpoigodODsrx+8IwxymQdEIGOqI4C7X8jIHmskZooZldZrzKhjJJBIJbG0azgf2rUL0o2pc1a3uC87zj1SsqyPV/rP9gHpnqAAZ/5Zp2NoUG2hajnGGjiVeLJnIdBEr4m+eOEROpkCKvukfGV+XFeEjc8e9C8z8lkJgP/dQYjKmEF+GmesPXiAAyfFOGMqZVObWOPArU8vvjvrlG0hlbPIdG5gnhX/UKotYLr8nYEzmDpAS+RSzvBrcaZnIJMI4XRwFHi2/VBLyVfsxibEBUG/OglbfMeQ3isL7zFSW1e9RRCccpkn14qDEkQrBnCEn2bCjwvvMX1P9UFZrWtomDoIps3CQsD1KXv7AoubSPBtVMzrCIDmGjCnHmFJhIT79gUpQLXRIWSuaxbq+u/rT1iCoyXYaknKSToSn0heXZEW5a7/X8+HK0PnGfLFcB2BRrptFuglgq+cFWEXcI49OTaYPGsNi065HsIbHPS+f57ni1M4rgPqsg1O08W2KXJ8eJFtChnnFfoz6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(376002)(346002)(396003)(39860400002)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(86362001)(6916009)(66476007)(66556008)(66946007)(2906002)(36756003)(38100700002)(6666004)(478600001)(5660300002)(44832011)(31696002)(316002)(41300700001)(4326008)(8676002)(8936002)(2616005)(26005)(83380400001)(53546011)(6506007)(6486002)(6512007)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEFpS0k0bkFlMUpUTlVidFl4eTE4OHFuYVNKb05GdVZMd25adG9qcVhBVjZK?= =?utf-8?B?UVRqZVByeDdMWkZ6VW9VV3BpRHIzQ2dlQlQ5K2xyR3NacndyUGxldFZGLytN?= =?utf-8?B?MnpTc2I0U3lTTTFydThybktTM2dBOS9Uc0dwUU4xWjdzSWZhR2lCelVPdE9o?= =?utf-8?B?aHVlb2NXakprc0tkR1FaYVRXZGFWYzJmSGNSZkk1Y1pkTTA5YmR6SllQZ21u?= =?utf-8?B?d08yZlVKOThuQ1Zjc1MyNGNxcVdvcUZqY25wMjJZcFBaOVVJbEJlM3Z5dFAy?= =?utf-8?B?Ri9LRlNwdC8rL1ZHc1dOUWp0RlN2RldrbE56YklLZlpaaEZzUVJjS1QzRmZj?= =?utf-8?B?aXFGTHNHZ29tM2Q4a1Yvd3V1Sk5zMzFEVmZ3Zm10Y0JvZzI0dStGTkp4Z0pS?= =?utf-8?B?RzlkeUlZOHRkUUhBZjVKeUQyMmwxUXJqSkFuVjFURkJGS05UQm9LMHVpT0l1?= =?utf-8?B?MnJ5T2swdUxIMmNhemF0NXBMT3EyRkdub21VVExZVloyVG5pSTgwMzUzcnQ1?= =?utf-8?B?WUxtaGg2dFU0QitTdHFxWlBqMGcxRnVlVHoyR0FWb0I4YUpkUkFxNytML1dh?= =?utf-8?B?eW52OXdsNzYvdnBxYVo0Vko3Z1RTSU5WT1Ruc2o0Yk5KLzFLNEs5Y2hPSlRy?= =?utf-8?B?T1A1L0hwQ3BlRFBtaENlVDgvOS81Qm1QU2pjSklNbm9iRFZ5WU8xcmFod0ZJ?= =?utf-8?B?TlEzbHh3MEcwYnYvbnRCeVRZaUc5L0Y4b1A4YW11dGt5UEhUSFZXemRkM3Vx?= =?utf-8?B?SnFmMGRBTEo3YUlESTZDaWNodWNHdENtaXkrZnFPcmNSS1RRZVptM3UxTWVN?= =?utf-8?B?dTZzVUhZbG1MNDkxb3ZNVGxoSFRxc1F3d0JlWnJveHFOWVZzWmJEcEVBUW9K?= =?utf-8?B?dWljOU5kY05mTTNaMDJXTXBqY1ZKZlFiTS8ySzZSV2hkM2EwU1drL3BBdFp0?= =?utf-8?B?ejVqRzYvaW5keDRJL1AzV2JnK2tFM3QvV0p1cm1rcHoweFhqR3k1MEN2cUx5?= =?utf-8?B?MCtHQm1xQ21JMk1IcDZIT1Q2YUxSWXAwNlU2OTdCL1ZaNVdVT3pnYnk2cGxz?= =?utf-8?B?WmZveExndnh2cjlCMXNoZEQ1TzlZdS83NGFPNFh4TFZLNTNTUk1xR3dqRk9n?= =?utf-8?B?VmE2aGYydVVKT3ROYmZNZGUvQkwrb1hvWlpFLzBGNzB4cEZNSTR0bllBNW9k?= =?utf-8?B?MEc2bjJSN2xvUkZ5T0laSzYyWUZkSVFWQXhBYXdYcEdkYUZQY1Nac0NKNjJP?= =?utf-8?B?RWlYdzI2NUJ5cDRWREJhSGRFREE5OTZjUWoyZDcvVVE4WUpsNWw4dXZ3Yk1D?= =?utf-8?B?RE1ZL0w3blo5cHVkdHoyOWEyeTlpM1lNcE1YdS9XRjk1Nkk2TE0xTktSMXMr?= =?utf-8?B?d0dSU2tvZGoxR0tRb0Q5bTYyd3VCamhyWlBhc0VvalNFTEMwZjZpVHFsalZL?= =?utf-8?B?S1JaOU1kVFBvNE9lYjJZcHVaL2ZxSmNhVHJCbnk3RDh0bXUyM2FTOE1Gai9N?= =?utf-8?B?R1llMEx0OTdVa01pRnFqUTJSUllySkJTV3VhOXd1dHN4bU1iNnhOZCthSnNJ?= =?utf-8?B?SHcxVUZaQU54NjQwV2dFTTVhNEo5dXl6YTJuWm44YTVmbGlQUzhnUC9ZQXVy?= =?utf-8?B?c3F0SlVoYkZXenpwVGx2YkRvVkRaOTdUQTZPMldHbXRNYVVmTjRBajlMR1hl?= =?utf-8?B?aGFtdnpkM3BTQkNvbFNJY3JCbHV6REhSZVZzb3lsKzJudmkwRFlSbjU2UnAx?= =?utf-8?B?SFNMeGpVRmdyZEdQWFAvRTZ4UWtxS0tWUXNyNk94T3F1dmFDdEpkdjFxMlYv?= =?utf-8?B?UDlBTlJCb2VrZjM2NjdtNlErUGxNeklnUXprNjdrUlFFa0JlUXROZXN5eEx3?= =?utf-8?B?UU5LMTQzK2pyYm1OaFlEY1pMbWh5M001WmtyU2RkM044ZzBCbWNYdEJ3NE9G?= =?utf-8?B?dUpzVC9USHg4SmZkN080Q3U4dUt3MW5oVjl2TU1CMlZXN2RXdFRCUi9HSVFB?= =?utf-8?B?VjJERFZ6NkNveUgyMm56SEdRR1RWZFloRTFSQUtkZHdsRytpTWFYeTUrM3JI?= =?utf-8?B?WllBS21YeVVzTVQ3L25RMlhwcnpaWEZwZWdtRHdlYjlvZ1JiQWhqcjBLMmV0?= =?utf-8?Q?KdZA9QmxVTim5jUEOTdtwJ+ie?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b010437f-d729-4cd9-f554-08dbc0f2cefa X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 13:48:49.2503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IfLcqlrd6sQy+njTNamtQY1vu5Wc4Mp7RihDygx1wJ7x1sqEHA88nuMZQEijbcEc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6081 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2023 7:47 PM, Ferruh Yigit wrote: > On 5/16/2023 10:55 AM, Ferruh Yigit wrote: >> On 5/16/2023 2:28 AM, Stephen Hemminger wrote: >>> On Tue, 16 May 2023 00:35:56 +0100 >>> Ferruh Yigit wrote: >>> >>>> Yes only some scripts and possible applications that hotplug tap >>>> interface with hardcoded parameters may impacted, don't know how big is >>>> this amount but this ends up breaking something that was working before >>>> upgrading DPDK for them. >>>> >>>> And I believe the motivation is weak to break the behavior. >>>> >>>> Won't it be better to update 'rte_ether_unformat_addr()' to accept more >>>> flexible syntax, and use it? Is there any disadvantage of this approach? >>> >>> It is already more flexible than the standard ether_aton(). >> >> I mean to accept single chars, as 'tap' currently does, like "a:a:a:a:a:a". >> >> Agree that impact of tap change is small, but if we can eliminate it >> completely without any side affect, why not? >> >> >> As accepting single char will be expanding 'rte_ether_unformat_addr()' >> capability, it will be backward compatible, am I missing anything? >> > > Hi David, > > If API update is not planned, what do you think to just solve the build > error without changing functionality with a change something like below: > > ``` > - (strlen(mac_byte) == strspn(mac_byte, > - ETH_TAP_CMP_MAC_FMT))) { > + (strlen(mac_byte) == strspn(mac_byte, ETH_TAP_CMP_MAC_FMT)) && > + index < RTE_ETHER_ADDR_LEN) { > > ``` Hi David, If you can confirm above fixes the issue, I can send a patch for it.