From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB6EEA0527; Mon, 9 Nov 2020 18:44:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59CFB69A4; Mon, 9 Nov 2020 18:44:15 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 708CD6004 for ; Mon, 9 Nov 2020 18:44:13 +0100 (CET) IronPort-SDR: un6qwmYosFngQ5wzhZH4w+cJi3n4K+OyeQYO9v6H254oLs3oLGZ2CFQCOZEE3HWaqddUId0C7A MRV7gW6TdJOA== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="234008165" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="234008165" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 09:44:11 -0800 IronPort-SDR: 3hJ2nMSlM+jaNIs1XxNRJDt7nD2UBZJ94woK4mY2VWeKCJj4jQBpWeqWKQVnZrg49qB/cErziu +7qcCJ0hO6Zg== X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="530845226" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.177]) ([10.213.193.177]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 09:44:09 -0800 To: "Zhang, Qi Z" , "Guo, Jia" , Prateek Agarwal Cc: "dev@dpdk.org" References: <3f94d598668b4279a2f5fb834124f3e2@intel.com> From: Ferruh Yigit Message-ID: <0ed1c11c-095b-4f98-9074-a82e3abba900@intel.com> Date: Mon, 9 Nov 2020 17:44:06 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d... X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/9/2020 9:49 AM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: dev On Behalf Of Guo, Jia >> Sent: Monday, November 9, 2020 2:24 PM >> To: Prateek Agarwal >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern >> "C". Library headers work directly in cpp code. Linking errors thrown due to the >> absence of this change in i40e pmd header does not help in resolving the >> problem. I needed this header d... >> >> Hi, Agarwal >> >>> -----Original Message----- >>> From: Prateek Agarwal >>> Sent: Saturday, November 7, 2020 5:01 PM >>> To: Guo, Jia >>> Cc: dev@dpdk.org; Prateek Agarwal >>> Subject: [PATCH] Made i40 header CPP compatible using extern "C". >>> Library headers work directly in cpp code. Linking errors thrown due >>> to the absence of this change in i40e pmd header does not help in >>> resolving the problem. I needed this header directly to use... >>> >> >> Obviously that is not you want to merge the title and the commit log. Please >> separate it and update one new version. > > > Fixed the format during merge as below > > net/i40e: add extern "C" for cpp compile > > Add extern "C" in rte_pmd_i40e.h when be compiled with cpp. > > Applied to dpdk-next-net-intel. > Hi Prateek, In the git history, we have your name as: "Prateek Agarwal " We are trying to keep authors unique in the git history, as much as possible, will be OK to continue with the one in the git history?