From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id EE4A22AA0 for <dev@dpdk.org>; Fri, 7 Sep 2018 11:48:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Sep 2018 02:48:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,341,1531810800"; d="scan'208";a="89764021" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.152]) ([10.237.220.152]) by orsmga002.jf.intel.com with ESMTP; 07 Sep 2018 02:48:20 -0700 To: Ciara Power <ciara.power@intel.com>, harry.van.haaren@intel.com, brian.archbold@intel.com, emma.kenny@intel.com Cc: dev@dpdk.org References: <1535026093-101872-1-git-send-email-ciara.power@intel.com> <1535026093-101872-3-git-send-email-ciara.power@intel.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <0ee49eec-35d8-caa1-0e79-067ffd08e475@intel.com> Date: Fri, 7 Sep 2018 10:48:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535026093-101872-3-git-send-email-ciara.power@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 02/11] telemetry: add initial connection socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 07 Sep 2018 09:48:23 -0000 On 23-Aug-18 1:08 PM, Ciara Power wrote: > This patch adds the telemetry UNIX socket. It is used to > allow connections from external clients. > > On the initial connection from a client, ethdev stats are > registered in the metrics library, to allow for their retrieval > at a later stage. > > Signed-off-by: Ciara Power <ciara.power@intel.com> > Signed-off-by: Brian Archbold <brian.archbold@intel.com> > --- Quick question: is there really a need for a separate thread? Can't you just register the socket as an interrupt, and just get a callback when something arrives? IPC works like that right now, i see no reason to not do it this way for telemetry? -- Thanks, Anatoly