From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 520B5A00E6 for ; Fri, 12 Jul 2019 14:10:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13B581BDF5; Fri, 12 Jul 2019 14:10:00 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2A2C01BDF3 for ; Fri, 12 Jul 2019 14:09:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2019 05:09:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,482,1557212400"; d="scan'208";a="177484314" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.82]) ([10.237.220.82]) by orsmga002.jf.intel.com with ESMTP; 12 Jul 2019 05:09:52 -0700 To: Jerin Jacob Kollanukkaran , Ferruh Yigit , Vamsi Krishna Attunuru , "dev@dpdk.org" Cc: "olivier.matz@6wind.com" , "arybchenko@solarflare.com" References: From: "Burakov, Anatoly" Message-ID: <0ef0c75d-bff6-ac20-61e1-a4a2472fc7f7@intel.com> Date: Fri, 12 Jul 2019 13:09:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12-Jul-19 12:37 PM, Jerin Jacob Kollanukkaran wrote: >> -----Original Message----- >> From: Burakov, Anatoly >> Sent: Friday, July 12, 2019 4:19 PM >> To: Jerin Jacob Kollanukkaran ; Ferruh Yigit >> ; Vamsi Krishna Attunuru >> ; dev@dpdk.org >> Cc: olivier.matz@6wind.com; arybchenko@solarflare.com >> Subject: [EXT] Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI >> On 12-Jul-19 11:26 AM, Jerin Jacob Kollanukkaran wrote: >>>>>> What do you think? >>>>> >>>>> IMO, If possible we can avoid extra indirection of new config. In >>>>> worst case We can add it. How about following to not have new config >>>>> >>>>> 1) Make MEMPOOL_F_NO_PAGE_BOUND as default >>>>> http://patches.dpdk.org/patch/55277/ >>>>> There is absolutely zero overhead of this flag considering the huge >>>>> page size are minimum 2MB. Typically 512MB or 1GB. >>>>> Any one has any objection? >>>> >>>> Pretty much zero overhead in hugepage case, not so in non-hugepage >> case. >>>> It's rare, but since we support it, we have to account for it. >>> >>> That is a fair concern. >>> How about enable the flag in mempool ONLY when >> rte_eal_has_hugepages() >>> In the common layer? >> >> Perhaps it's better to check page size of the underlying memory, because 4K >> pages are not necessarily no-huge mode - they could also be external >> memory. That's going to be a bit hard because there may not be a way to >> know which memory we're allocating from in advance, aside from simple >> checks like `(rte_eal_has_hugepages() || >> rte_malloc_heap_socket_is_external(socket_id))` - but maybe those would >> be sufficient. > > Yes. > > >> >>> >>>> (also, i don't really like the name NO_PAGE_BOUND since in memzone >>>> API there's a "bounded memzone" allocation API, and this flag's name >>>> reads like objects would not be bounded by page size, not that they >>>> won't cross page >>>> boundary) >>> >>> No strong opinion for the name. What name you suggest? >> >> How about something like MEMPOOL_F_NO_PAGE_SPLIT? > > Looks good to me. > > In summary, Change wrt existing patch" > - Change NO_PAGE_BOUND to MEMPOOL_F_NO_PAGE_SPLIT > - Set this flag in rte_pktmbuf_pool_create() when rte_eal_has_hugepages() || > rte_malloc_heap_socket_is_external(socket_id)) If we are to have a special KNI allocation API, would we even need that? > > Olivier, Any objection? > Ref: http://patches.dpdk.org/patch/55277/ > -- Thanks, Anatoly