DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Hunt, David" <david.hunt@intel.com>
To: "Liang, Ma" <liang.j.ma@intel.com>, Xiao Wang <xiao.w.wang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable
Date: Fri, 14 Feb 2020 10:43:29 +0000	[thread overview]
Message-ID: <0ef2cf14-aca8-97dd-9b1d-0e4199ab9b22@intel.com> (raw)
In-Reply-To: <20200130174025.GA30906@sivswdev09.ir.intel.com>


On 30/1/2020 5:40 PM, Liang, Ma wrote:
> On 20 Jan 22:06, Xiao Wang wrote:
>> Since all related queues' interrupts are turned on before epoll, we need
>> to turn off all the interrupts after wakeup. This patch fixes the issue
>> of only turning off the interrupted queues.
>>
>> Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt when waking up")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> Hi Xiao,
>     I'm OK with the patch.
>     Reviewed-by: Liang Ma <liang.j.ma@intel.com>
> Regards
> Liang

Hi,

I've discussed the before/after testing with Liang, and the code looks 
good to me.

Acked-by: David Hunt <david.hunt@intel.com>

Also, from Liang's email above, but without the leading spaces:

Reviewed-by: Liang Ma <liang.j.ma@intel.com>

Thanks,
Dave



  reply	other threads:[~2020-02-14 10:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21  3:06 [dpdk-dev] [PATCH 0/2] l3fwd-power fixes Xiao Wang
2020-01-21  3:06 ` [dpdk-dev] [PATCH 1/2] l3fwd-power: fix a typo Xiao Wang
2020-02-14 10:46   ` Hunt, David
2020-02-14 10:46   ` Hunt, David
2020-01-21  3:06 ` [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable Xiao Wang
2020-01-22 13:30   ` Harman Kalra
2020-01-22 14:32     ` Wang, Xiao W
2020-01-23 17:42       ` [dpdk-dev] [EXT] " Harman Kalra
2020-01-30 17:40   ` [dpdk-dev] " Liang, Ma
2020-02-14 10:43     ` Hunt, David [this message]
2020-02-05 17:25   ` Liang, Ma
2020-02-14 12:46 ` [dpdk-dev] [PATCH 0/2] l3fwd-power fixes David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ef2cf14-aca8-97dd-9b1d-0e4199ab9b22@intel.com \
    --to=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=liang.j.ma@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).