From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73D33A0546; Fri, 14 Feb 2020 11:43:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4AE54100C; Fri, 14 Feb 2020 11:43:37 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AA44F3B5; Fri, 14 Feb 2020 11:43:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 02:43:34 -0800 X-IronPort-AV: E=Sophos;i="5.70,440,1574150400"; d="scan'208";a="381407259" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.237.221.40]) ([10.237.221.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Feb 2020 02:43:33 -0800 To: "Liang, Ma" , Xiao Wang Cc: dev@dpdk.org, stable@dpdk.org References: <20200121030657.39048-1-xiao.w.wang@intel.com> <20200121030657.39048-3-xiao.w.wang@intel.com> <20200130174025.GA30906@sivswdev09.ir.intel.com> From: "Hunt, David" Message-ID: <0ef2cf14-aca8-97dd-9b1d-0e4199ab9b22@intel.com> Date: Fri, 14 Feb 2020 10:43:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200130174025.GA30906@sivswdev09.ir.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 30/1/2020 5:40 PM, Liang, Ma wrote: > On 20 Jan 22:06, Xiao Wang wrote: >> Since all related queues' interrupts are turned on before epoll, we need >> to turn off all the interrupts after wakeup. This patch fixes the issue >> of only turning off the interrupted queues. >> >> Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt when waking up") >> Cc: stable@dpdk.org >> >> Signed-off-by: Xiao Wang > Hi Xiao, > I'm OK with the patch. > Reviewed-by: Liang Ma > Regards > Liang Hi, I've discussed the before/after testing with Liang, and the code looks good to me. Acked-by: David Hunt Also, from Liang's email above, but without the leading spaces: Reviewed-by: Liang Ma Thanks, Dave