From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C43784CA5 for ; Thu, 23 Aug 2018 14:10:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2018 05:10:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,278,1531810800"; d="scan'208";a="84283241" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga001.jf.intel.com with ESMTP; 23 Aug 2018 05:09:50 -0700 Cc: "Wiles, Keith" , Thomas Monjalon , Ophir Munk , "dev@dpdk.org" , Pascal Mazon , Olga Shern References: <1528733172-24747-1-git-send-email-ophirmu@mellanox.com> <48f3aef6-765d-66d4-305c-541bd2aa3eb7@intel.com> <1566202.bke8Esm90b@xps> <09D1AFC9-52F2-49D6-A54B-76F8FCFB383F@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <0f1ec67b-58f1-98ab-74bb-24e7f65f0d36@intel.com> Date: Thu, 23 Aug 2018 13:09:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <09D1AFC9-52F2-49D6-A54B-76F8FCFB383F@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 12:10:08 -0000 On 7/5/2018 1:34 PM, Wiles, Keith wrote: > > >> On Jul 4, 2018, at 3:11 PM, Thomas Monjalon wrote: >> >> 04/07/2018 21:47, Ferruh Yigit: >>> On 6/12/2018 3:02 PM, Ophir Munk wrote: >>>> Please note that other than cloning iproute2 we also need to install clang and llvm tools versions 3.7 and upper. >>>> Not sure there are clang and llvm packages of the required versions for the common distributions. >>>> I compiled the tools source code and installed them manually. >>> >>> Hi Keith, Thomas, >>> >>> What do you suggest on this patch? >>> >>> The "tap_bpf_program.c" is already withing the tap pmd this patch improves the >>> doc about how to compile it, although it may not be so user friendly as Keith >>> pointed, I believe better to get doc improvement here. >>> >>> And there is a code update "+#include "bpf_api.h", which includes a iproute2 >>> header, I am not sure about this one and how to manage this dependency. >> >> If you feel it needs some improvement, we can postpone it for 18.11. >> The most important is to have a patch to reference when somebody asks. >> >> It can be improved and merged later, no pressure. > > I agree. Hi Ophir, Are you planning a new version of patch for this release? Thanks, ferruh