From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 242E9A034F; Tue, 18 Jan 2022 22:06:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2E1D40140; Tue, 18 Jan 2022 22:06:36 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60123.outbound.protection.outlook.com [40.107.6.123]) by mails.dpdk.org (Postfix) with ESMTP id 9C2A84013F; Tue, 18 Jan 2022 22:06:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UUEeI9hL284Dr7p9DjACY2L7u7P8BKXqdKnEFXwPkODvBJjHTAyLgdx/zsnoYkfZUwTB36L9URoDP/+1Tmv5MF90Ueb++9TZXJFknKJuH8ULLOXji+UVQJ3pt1yuQJnh4l6MymeHOzYFYnrHBFAjlLHZ8rCj9hxk2jYxJsFmE2JX1IPM66mjDu2brfLyPjxL9ib+mVp45aACiXlpwS7XSv9lUHNe+SSKZUNcZWZilWuunPnqOzq4xnJnR/XHrFhlgCTuRhEKf0LjzJrht/03dzQA4NkKiQfZXtPfIGiBPliyB20w1j3LlCbkbCoIPrJlpDYnr/pdA1H+QdH2to2zKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FihZA4tu82L+pGz5oJ7lQzcUGE/BjvPGkEYLXExouRk=; b=Uz//3TlYuRaYFcxC+xTGJxDUvIw6gZfUSC7s6z4XHC8hUxgdwmyvGkmtZo9Tn0EWylc6pqRef0dHKQ3yBfDcbwmuxrkI5pJbAVr0uv2QtKXet3j5aheVuOg0qHv6o19/Hh5LJZprIjZfDL9Qtswb8cULoR/lDCWkoMR37JuQ0GqXaQAjmdeO55tzaV7G6WfJ4vSGmLK27Yj7VL1EoSh6NYc88koyDVI+fM1JiqEFdD1xkGmICiSlLmE6W0Zp9w3yhkWByBtec6tYmXaJXngFrroJJq68trBhe1SSRnoWSv2kj15Lx9tqa19uSOiBC/Qtcrm687Bd11whXizsT2PK5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FihZA4tu82L+pGz5oJ7lQzcUGE/BjvPGkEYLXExouRk=; b=OyzFuL3lZIHtxu6Kw2cHtQLT3/D8tzOuOFMVGW1tb52HtVG21myiEZnU+fQVJNFfJXKLD7jKnOoYvWEHEQ1sm0haHQs41xgc4Z48xdWXa8TwdAp81ACXB3e7jVTu9AP6EZwl62qWEe0VvuV58Flfh5YAtvQC3KGIzhlSszcd9kw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; Received: from AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29) by PA4PR04MB7744.eurprd04.prod.outlook.com (2603:10a6:102:c9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Tue, 18 Jan 2022 21:06:34 +0000 Received: from AM0PR04MB4083.eurprd04.prod.outlook.com ([fe80::c0fe:1a10:44e4:37ed]) by AM0PR04MB4083.eurprd04.prod.outlook.com ([fe80::c0fe:1a10:44e4:37ed%4]) with mapi id 15.20.4888.014; Tue, 18 Jan 2022 21:06:27 +0000 Message-ID: <0f4a78d5-df1d-fea7-6e5c-15ea07d80886@silicom-usa.com> Date: Tue, 18 Jan 2022 16:06:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write Content-Language: en-US To: "Wang, Haiyue" , =?UTF-8?Q?Morten_Br=c3=b8rup?= , "Lu, Wenzhuo" , "Zhang, Helin" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "Wang, Wen" , "stable@dpdk.org" References: <20211206221922.644187-1-stephend@silicom-usa.com> <20211206221922.644187-4-stephend@silicom-usa.com> <98CBD80474FA8B44BF855DF32C47DC35D86D8B@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D86D9B@smartserver.smartshare.dk> From: Stephen Douthit Organization: Silicom, Ltd. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BLAPR03CA0134.namprd03.prod.outlook.com (2603:10b6:208:32e::19) To AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f4ca15d-6418-41a0-02ee-08d9dac66470 X-MS-TrafficTypeDiagnostic: PA4PR04MB7744:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tJinYgP88/sogDTsukbL4MQUuX3x2fe6VpxMAIEaQBEEUAlk6qox1MbO4mOxqoS9ysS8yAAdLvvHxLfK5oT7xBJT5DT4fu8d33ZGADZBhVDafDCnQBNBpCQwgA8N/Le8/q0ao8ta/XrSqgdu161QtVWVxkDmNu6C0JacRHcvUtf+iRgsf2tNUskaw8LDJ0pi/dSdecYAMpheT9GgNYIhi9JZX/PzxBB7rj7N/IFPq2oieycSpxRV15GdJRzAC+PbM3+yBPi9kL3IkzBx9AhBL8Me54PGgsnXHMfj5xJ4VpCdEDLJL7I/8u8kB7n+qz5N/qT6nho1ReZeh9vKkJtc805Heu7RYXQu7m0FeL11rP9LpRxAyRX+mSPW5z37dTZcjmsrMQvRBdX4qzSZrgw6+MGJIQ+r5xuGuiNidNipJUkVjFnVmnZYfb7JmnkBeBIfR0MMbmj7EDoScPYtX5vNAOjS7+u+30UXdfOj9raEy7WJ6bYH+CO4sAnuD1cBSMhx5D7ztNabdgVFxWVSs5ieKBqx7A2jbWevwgNDYN7iRsRiz87NfWCGoWU6YiBQu5B4xSj1uGJV061U6E6gwmMgLLfbTGaLzFYt+NqR9axB9j6RoAPrEUY96i7d/CNRjVbiRtr4b/z6E64e2r6NU9Wssi+YTrviMYPkXxAb0GEJeQI+qhJrAFxXcSFsENLZd1R5RxaPDX1iTAm7BF3vMkguK8e+mQ3bta75xT0DB1hhuTVEFr7CxcDyuSDFWWU3INDJRl90rgdDQo2/QWDztlKKYA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB4083.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52116002)(6486002)(8676002)(110136005)(6666004)(36756003)(86362001)(38100700002)(508600001)(38350700002)(6506007)(53546011)(186003)(2906002)(31696002)(66946007)(36916002)(26005)(54906003)(4744005)(2616005)(3450700001)(4326008)(316002)(66556008)(5660300002)(8936002)(6512007)(66476007)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aitsZm1GTkNyZXFqY3AzTlhRN3Nya1U2MVdGNlFtTlZ4dnloOXJnc2s0MGlv?= =?utf-8?B?VU9tdFBWTkxaMndPYVdKWE9yZFpKREVPKzhvS1hoSEtudXpxOFFuTzJ1UlNu?= =?utf-8?B?WnJqN1RJbFJaWk1sN0FlcFZaUW5NRlR1Ukwvdm5Sb0pyMm1IOGloMjRTb0tF?= =?utf-8?B?WHNXUSt6dml6NjBpckxkb09xMzFpaGpWbTZsSjVpUmhXTU5oNkxWMWVhbGtl?= =?utf-8?B?VlMvWWFKQ3dTejA3K3I2QkxtRW1BNHhTSzF1djFEdlhTNHdqZXJhOEhLK1RK?= =?utf-8?B?TDRIdkwxQjRoWkhFejExcnkwU1RMUDdlcllXNWJ4UDFKbWpkdHo2UTNuL09x?= =?utf-8?B?MGVVMVRWUHAxQUhCWUJjZ2FTVmllUDgxNlVwYU41aVhjd09rTGFmNXRoMndK?= =?utf-8?B?dXA0RTF3TXRLemZTUjhDRTYvMmRIVytNek0wZHREOXpKUHVRYnlvOEJ5UzFu?= =?utf-8?B?YnRxeGlrSFNIenJnbHdRY21NdGFUdFpDMVNOZmo2Y2pJVHZ4L3hnNzFLc0hP?= =?utf-8?B?NWZXREhiTEc4b0tSeklnZytmbGNkSkpYY0gvL2xYRkF2dHBJYjB4Q1V4ZDYy?= =?utf-8?B?TWFURndPVkdNeVc0VEtDK3EyWmpQbEQ4cVpXVVdiY3BHbW5BellGb3gwMU5P?= =?utf-8?B?RmhsckRsS3BQWEQ3a1hwdnJkY0ZvTjMvQ3d0aitwM1BBZHpnOCt3S09ONXp1?= =?utf-8?B?aTlIWlRRSldZcXJTWEd2Q2pWc2FUOVdyZHRTUDZET0xZZnJRMjh2bFFLOFpo?= =?utf-8?B?UEJBUkdjeVR0WXhaZkxMOStjakc1WDRTMi8rczZVYzhhVU95T2U0ZlR3UWh4?= =?utf-8?B?bmd3RzNaRCtnQ3huclBXUTExNzdIcjN6MFFad1h5b3YvRmlsaTJFcWZQaWVs?= =?utf-8?B?cFFnL3VqSGdQS1gyaGJKOW9BSXM4YUo2NkZKcWh0U1QrUlkvd3NiQTE5Smxs?= =?utf-8?B?UTh1YzNaTEo0Qnd5cWdOM3hVUmUyYURIWElwRUdVTzREdEREelJ6UGpXSFBo?= =?utf-8?B?aTk2K2ppR1N2ZlVBNjcwS2Ruc0x3WDVkVmFzcCtDZkpTT1JPaFBEV2thcHVP?= =?utf-8?B?U2pQZGl0eTVEWjBBUGhPOEJ3N1hDbWMwRXpzN0dHQjVUNWtFNmpucTR0R01h?= =?utf-8?B?c1o5SXF4c3BDd0cvOU5nbm9uQzAyd0o4Z3JVaUQyUUxEU3ovczNsOUdkUHF1?= =?utf-8?B?N0NTWDd4QlFNNEpqSm5MaUZIbjY1Y1AzSk11UTNrSDQ0WnY4RExaYzhJdjYy?= =?utf-8?B?Y3Rlb09PRkZLV0Zub085QktoRWJaeVgxd0R2VmttY2dPU3ozU3U5RklVWXBa?= =?utf-8?B?MzlFYmIwMlhRY29VSnZuNkYwVmR4eHlXK1BmaWVnczF6Qi85WnEvUE5oSzFk?= =?utf-8?B?NHZtclRjdFhMSGpFamx3bjdzZmo5T2FtT09xNWttKzVtWjJobXg2b2RpMGJL?= =?utf-8?B?WHFrUWxaaThyYzJBUmdHT1FySGVXU2grUURpVjdBNmFROXhJOTRhdkRHSXkz?= =?utf-8?B?K2I4NlBuMDB1WHlGTVloc1dQVzVVRW4rRnJDR21TdHJBdGJIYmV6R3dnU0J0?= =?utf-8?B?NVFJTjNJR2Z6QzFRMmJtV2J4TmJzYzNlbTRvWlFraVp6R0FFcm11UDlkUVM0?= =?utf-8?B?WTB6MzJmcG9IRkhPMlIrMVptYnJhL2NJamZYR0IvR2dhUnlDaE1pL0o2OHpY?= =?utf-8?B?WWRiNE93alYzaUxEYlZTT3Jmbk9qbVh6cktGZDNiRk1uODRXZzFqMkdXNUNs?= =?utf-8?B?U1gxZ0cwRHlpdHRDYjMxcUgrM3dLcXRzek9zbzhNSHBKRFJtdmt1UldyaXBS?= =?utf-8?B?aFBlRUlyWEQ0TG1IdnhvcENLZkpRVEZZcGFBNUlBNGJESWR6OWpYUmZjUHRs?= =?utf-8?B?aEV0OU5wTzZnY3ZKSWtqR2dNaU1EY0wxRjB0YXg5RTN6dCtwcUE2eno3T1Zv?= =?utf-8?B?aHd0Rk8yUU5DRjJBdE1ESi9Ta3JZL0xQclhSSmU1dFUxaGFEMnJtWHdHYXFw?= =?utf-8?B?UzcyUjM3bWtnVGk1Y0c1a1IrUFdtQnFJZW1VcjRacy9pMHRFdE9CU1BpUVlS?= =?utf-8?B?b3YzeWJaZExXRkc4TkovanlmUVpuNUlJNUt4Rzc1c3ZFVVNlK2xvbzh6NFdy?= =?utf-8?B?bkVrVWFtdVVuSzVNR25yZU5SaTRsMTUzRWkyUXlrSDR2NlRvbkkrSU95Vjhs?= =?utf-8?B?WVJyMHRYckg1dnJsc3dzVlN0YU5OMk9Id0dnaWdNczk1b09nbEdRQ1lBSU9Q?= =?utf-8?B?b3B4WWxROWZVUS9Fa2tUdVRXeG1BPT0=?= X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f4ca15d-6418-41a0-02ee-08d9dac66470 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4083.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 21:06:27.5577 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nnn3xUXuNlGcuoJXuI6tPK5kL+bE61zYzja9Iu0RQ7IhV92f/8b0Rlyf/UO3VJFZuW0/Ia4WGn3rrtTpmH0TV9boMYk3tzssIRM7gHPcNsI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7744 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: stephend@silicom-usa.com Errors-To: dev-bounces@dpdk.org On 12/22/21 19:55, Wang, Haiyue wrote: > OK, let's see in 2022, happy holidays. ;-) A bit of a slower start to 2022 than I had hoped, but I have a v3 of the hotplug fix in progress. It's now working for the 82599 and C3000 ixgbe devices under Linux, and I'm in the process of getting this built and tested under FreeBSD. Assuming the FreeBSD testing comes together smoothly my plan is to split these patches into three series: 1) The SFP hotplug fix 2) Refactor SDP3 TX_DISABLE 82599 link check stuff 3) Support of additional SFP types under ixgbe My focus right now is on the SFP hotplug fix, so please let me know if there's any additional feedback on that portion of the original series. Right now the feedback I have that impacts the hotplug fix is a cleanup for patch 1, and the general comment that changes to files under ixgbe/base are usually backported from Linux, and so I should refactor my changes to live in ixgbe_ethdev.c Thanks, Steve