From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Qiming Chen <chenqiming_huawei@163.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/pcap: solve pcap resource leakage when port probe
Date: Thu, 9 Sep 2021 14:02:24 +0100 [thread overview]
Message-ID: <0f5a8076-bb24-5d03-1e52-cad9d754e4da@intel.com> (raw)
In-Reply-To: <20210830030108.3367-1-chenqiming_huawei@163.com>
On 8/30/2021 4:01 AM, Qiming Chen wrote:
> When the port is probed, if the eth_from_pcaps function fails, the
> previously opened pcap resources are not released, causing resource
> leakage.
>
> The patch solves the problem of resource leakage caused by abnormal
> branch exit during the port probe process.
>
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
This seems missing from the begging of the PMD, need to following to commit log:
Fixes: 4c173302c307 ("pcap: add new driver")
Cc: stable@dpdk.org
Also we use 'fix' as almost like keyword, so please prefer 'fix' against 'solve'
next time, I will update while merging.
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2021-09-09 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 2:54 [dpdk-dev] [PATCH] " Qiming Chen
2021-08-30 3:01 ` [dpdk-dev] [PATCH v2] " Qiming Chen
2021-09-09 13:02 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f5a8076-bb24-5d03-1e52-cad9d754e4da@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chenqiming_huawei@163.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).