From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42257A0547; Thu, 9 Sep 2021 15:02:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC15740041; Thu, 9 Sep 2021 15:02:37 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 5EF644003E for ; Thu, 9 Sep 2021 15:02:36 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10101"; a="281797524" X-IronPort-AV: E=Sophos;i="5.85,280,1624345200"; d="scan'208";a="281797524" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2021 06:02:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,280,1624345200"; d="scan'208";a="580878725" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga004.jf.intel.com with ESMTP; 09 Sep 2021 06:02:34 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 9 Sep 2021 06:02:32 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 9 Sep 2021 06:02:32 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 9 Sep 2021 06:02:32 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 9 Sep 2021 06:02:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U7k+H1PM2M5ORYM7KMfFUA4cLCC6ouAi0BhK2SUyzZl9jKgL/gRq+LKrJ7cwmtm3Ofcy8NI2wiQT3ktWC9/AdaT8Gsyc6M/aNqAj9Is/sLpWYNtIapt0xn66+vA0vHcPNh0DlEKz+8Osw7GffKFklaPiAH7G5Icp1gF6RZxqbmBgPf/bQ/wyUYzY08IaEcEYslcXoYThXH2U1scvWAl/ep29XzAIT8PDF7e+hQ/1+CVR3CNDNGyRX2vCf5AT1CM0KSObU+SnOpExJzyQS76kAPzkpPrIfYTWQn6s7ey01e9M/iF5s/QipSKh9VM+uD+oHEYmkaLmIQStbYgAxMHU6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eTsV70HiI0xDtQoq3HqriAe3rlXIU2IVAd0HlHEScfo=; b=GvM+k7y9tnZT71/tx343V5Gj+QkvB9VuNHw2ulRLA9WISVT40egagv9gMBBMH0AhhKAChrFd+Y6+R6hGKIFo7rso/hoZH81KHWY+G9ai1Dl8T9I+c1BzcsSA9zYDUKC4Vk3EC3a1mXSMWGv80DrHjLeLO5sxLQdpP6hwhB/5VV2mD/JfnoQ+ZHknoXZ+4nf9igNMsLc5PYC6aaJhnJFk8pax8haO4u/vaSWQCq3gfruG+opEPwGZFmVZTzbvuYR5jGroXrL7dad+elpmTFFaBAOGU4cur2dHdafBEctQm1Cj4GLQvh9h3eiYh8Sj2XH/DrcNgds3PB2WhrrjHJJCYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eTsV70HiI0xDtQoq3HqriAe3rlXIU2IVAd0HlHEScfo=; b=N2BSYH5/yUZUYrMuoloztEPV2RhvL2zJ3DOYS2LQajmDIQZpW+WV5YuAnYZGb9ZxaCc+HtS32t2GmbN1mz63hC9Pi9FbTvs3rU4Q0/fSVMDXA2rQhB62y/Lh5iTD9gHNeD17ia4Ej8bNnW2Ls7I20YiiURgXqmFc3p17CRzcoD4= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5029.namprd11.prod.outlook.com (2603:10b6:510:30::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Thu, 9 Sep 2021 13:02:30 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4478.025; Thu, 9 Sep 2021 13:02:30 +0000 To: Qiming Chen , References: <20210830025442.3310-1-chenqiming_huawei@163.com> <20210830030108.3367-1-chenqiming_huawei@163.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <0f5a8076-bb24-5d03-1e52-cad9d754e4da@intel.com> Date: Thu, 9 Sep 2021 14:02:24 +0100 In-Reply-To: <20210830030108.3367-1-chenqiming_huawei@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR07CA0083.eurprd07.prod.outlook.com (2603:10a6:6:2b::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0083.eurprd07.prod.outlook.com (2603:10a6:6:2b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.9 via Frontend Transport; Thu, 9 Sep 2021 13:02:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e8f0db0-bd50-4855-121c-08d97392150e X-MS-TrafficTypeDiagnostic: PH0PR11MB5029: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XBgiHp6ynfYhU/ut30ssVNS8vRyRWRmJ191wiTNCGg2DR1gens7ShS8oFWcNjCEUkSa+5vOXAieGqTDisL0iVEO3SkT7sbPHI8PTeUVRp7NOoeUnkh8RLNpspGyZMFqkjrxVg0Z4J3G9+UqkeQx6DaIqG4nkF45ZMOZdXl4BgXB7Pfg0jSZtuiECnxRO/tkkNTbJpiL6vrAwFyQ55m7aOhbXAE8IRBlpPxb0PaX8C485T1GwpYtCaCnB3zvcbvoT+7jBDy+3wxmxLB7AOzTwctKuaQdZG9Nj57xo+0SycYjaQEWUOqhi6yVZvy5I14hpxy3ssEpAE3nE2vchKjbkBOcO87KRxoz+TLSH/mWe1zKsERoZ6lP3A9AoaWnbBhi+koYS+QlneKsiO8GGaWIXA2NIO8eceVMZQCCVQCrMOQBkVyC3AndTNy2Nyjgc3j7cx+oLFaJLrcU8f4+wArQns7b/KQG53CI6ewuhl1cOzva07GGrXgrbddkqK4CSECwYfBdofWwtW87s+LMIqNQnMK2Lc7QuHJvayZwqeic/Gl2tI+ave0nOTyM3xv+/bglDqnEnSIaZ6bw3jfcJqhVxCBU91k5493QGUTTuKfyAm+RWrFFS3JB//uwbg7VAkdNDLzGL/ze49CE19HDMx6TgHh9U7jwFqrU51VGwkIC7U2YwFRZRHxR7d7kz1gepCFFe9O0vkWiHezEx7r9xBbfIuA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4744005)(44832011)(8936002)(83380400001)(2906002)(6666004)(8676002)(66556008)(16576012)(26005)(2616005)(31696002)(36756003)(186003)(956004)(86362001)(5660300002)(66476007)(6486002)(508600001)(31686004)(38100700002)(316002)(53546011)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUlaTWZ3bDFCamloaXR3UllJaSs5Wnlzb3NGd003MXBNY282Ym9kNWl1Wk9O?= =?utf-8?B?QnlGclNtWjZTbElLVnExL1BRRGJaNXRKTTIxVFhnSlJpK1lkSzBvVVpCNkR3?= =?utf-8?B?RFpmM1pBZWZveUhZNlNJTGZoOGluUnd1OFhEMUNaaWZORTFrMm5yVEZLM2Zr?= =?utf-8?B?d2tTZE5CTVBhZE1iclRGLzQ0elVaaTdIMmNkSENBekMxS1g1bXI0cGZvS2Js?= =?utf-8?B?RlpqcldnSHcrWHNudTJlUVhsYUJZYlpYWThoZ3pVdWd0WnZmR0pZVzdSZWRL?= =?utf-8?B?b2pCdUNlVXN2Smg1eDZZbmREKy9hVXBCa0FRV2pXQjM0RzlkL2FHQUV6R2N5?= =?utf-8?B?VlJ1M0I3SU1EdVpzY21zRGdlbWdLSmtwanVPdXBlTU1BSjY2MGs3STFmVEhm?= =?utf-8?B?MGZTWmRkd241WUNzcXllZXhBd3N4NHBQWmVyMkdBVUhRUWdLL3J0VUVUdVQ0?= =?utf-8?B?dTR6dUk2OG82eGoxTmxkT0IzaU55RXRLTm1FNTdFaER2K1hiR2crakdESHdo?= =?utf-8?B?UUwvblVyRXpkVGdMamUwMm0xMUR1K1ZQVUttZDBaaHJIMjltVGlkYUpXM0Zt?= =?utf-8?B?TFpGMy9vQkZpNFRZQ0ZvdUpvcGF1N0dBdWJxTEgyclVtWVBGZzNsdk42bzVO?= =?utf-8?B?UC9QbzdGU1Q3UElHdXozdXYyeElPdEp2Q1F1cDdxMENmbmZKaE5wZ0dYWTVk?= =?utf-8?B?b1JxTWdjUi9jdVdHNlF0ckNtSU5LV3dEMElCV2dEc0c0MDBhTlVsM3dCZFFt?= =?utf-8?B?elA0N1hwcHRMNG9FaE1xekVzQVg4ajlVRHdSTStSWmQxcjdpQ3ZIUllpWXRJ?= =?utf-8?B?ZTJGVExFaTZhRTl3b1diQkdOc0VLRVh5KzllM09uTHdzRFRaREFBR2lJS3BR?= =?utf-8?B?bUZ2Z3JpOHB2bHY4ekZDd3BZcmMwdHBuWUNoU282K040TXZCdmJldThtZWlL?= =?utf-8?B?SEp2Y3hhdStqUXVTU2dsak9PS01maEwxd2p5VU9aLyt1MEJ2WU9WajlNVW9P?= =?utf-8?B?R2krYWV5Zis5ZkNGVFBqWFZjSXVHaXZVcGh0ZkZhUE5WeDZCSTNZQ2N1RzMr?= =?utf-8?B?Zyt3SjNBYnBIYWx0RXFKM3FDSnBjN2RzV3gvTmhTZld3Nm82eHdOWW9UalY4?= =?utf-8?B?aVZGSVY3VnY2WFJZaVJlN1VGTU14WlplbWdITU43eSt6NEhNak9XQjJoeVFG?= =?utf-8?B?K1V0aDFyQXJ1Tk03aGZHNkxFYm1CaXlxYUFMejYrN245UisrT25IY2puaTND?= =?utf-8?B?YzRxUG9UMjc4eGp6R0xFMzl5cVdJV3g2ZG5SeVVTR1JSd1JTb0VFTS9Hd3Fa?= =?utf-8?B?cUhMdk1ucVpLd0lSVEVZdFRhTVZoU1kwQWw3ODhJU0lOdU9LdkdBUmhpQUYw?= =?utf-8?B?Tjd4c081UElzL2gzZFdpMWtIbzQ5YzZCbWl4aFdQd3VBWFphSW1zS0tzSUYx?= =?utf-8?B?N1RIWXhzWEJmQWUxVmM4eitwcWR1Y0UrYldlN2tkSlBlRTNKdWQvVUJkMnlj?= =?utf-8?B?RkFHRzlwZXQ0YjdYNG12TjVYbkxqNzBsRmh4QWdsR1J1MjVkUVRpcnp2WlB2?= =?utf-8?B?RHJDdGpNd1NnNWpoc2xLMTV3RjVaTjl4em5ZWXNDZEdzeWcyZjFpL2JJSDYz?= =?utf-8?B?MGo2SXgyM3BZbHNmVkhrOFpjblZmS3lhTFdFWlZHNkFVQmo4NGJzVDFxRm1Q?= =?utf-8?B?eExPSGczNGRTQWMyenhBdFhKRTlnTFdHdXA4RUpFcFFVYnltZm9EaTR5TFVQ?= =?utf-8?Q?8ReuN7PaElKgGMZTTM6KiOp61oTTKLeYbPBjC6h?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8e8f0db0-bd50-4855-121c-08d97392150e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 13:02:30.6264 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KrzA4nEBF+RrwEZtrTO2vNQg/6gH7JXu66MGu4mJHYPiEB9p5G3ltqydMefFO1LJ1/Ujxq8SGQfQfBH39t9Luw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5029 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/pcap: solve pcap resource leakage when port probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/30/2021 4:01 AM, Qiming Chen wrote: > When the port is probed, if the eth_from_pcaps function fails, the > previously opened pcap resources are not released, causing resource > leakage. > > The patch solves the problem of resource leakage caused by abnormal > branch exit during the port probe process. > > Signed-off-by: Qiming Chen Acked-by: Ferruh Yigit This seems missing from the begging of the PMD, need to following to commit log: Fixes: 4c173302c307 ("pcap: add new driver") Cc: stable@dpdk.org Also we use 'fix' as almost like keyword, so please prefer 'fix' against 'solve' next time, I will update while merging. Applied to dpdk-next-net/main, thanks.