From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 45E9E432B9;
	Mon,  6 Nov 2023 11:43:24 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CC123402B4;
	Mon,  6 Nov 2023 11:43:23 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 6B513402AA
 for <dev@dpdk.org>; Mon,  6 Nov 2023 11:43:22 +0100 (CET)
Received: from [192.168.1.38] (unknown [188.170.78.242])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 59D185E;
 Mon,  6 Nov 2023 13:43:21 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 59D185E
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1699267401;
 bh=1fWPM/TaVJkBE8D+OasfonlD3uN5hjYuKDLRqFcIaVk=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=LK3ZDAEossEkjInUT1Dv5Mdj97T+igcQ78H/GDdHdt3MSPZShpF13X0azJYUxAFmI
 tz9EcTBI5rurG1WNjXXdSFbVUIQC0bwr4R4JQx5THI4Fl4qAlUJKnr7P16TGcRdl6f
 /xpYjRW74eAVQ6HSALbvJfN+eumkU5govibCnD/M=
Message-ID: <0f5d4d4c-8a61-4cc4-a4fa-767b13c08298@oktetlabs.ru>
Date: Mon, 6 Nov 2023 13:43:20 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 7/9] ethdev: add API to get RSS algorithm names
Content-Language: en-US
To: Jie Hai <haijie1@huawei.com>, dev@dpdk.org,
 Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang
 <yuying.zhang@intel.com>, Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@amd.com>
Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com
References: <20230315110033.30143-1-liudongdong3@huawei.com>
 <20231102082020.2588392-1-haijie1@huawei.com>
 <20231102082020.2588392-8-haijie1@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20231102082020.2588392-8-haijie1@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 11/2/23 11:20, Jie Hai wrote:
> This patch adds new API rte_eth_dev_rss_algo_name() to get
> name of a RSS algorithm and document it.
> 
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> Acked-by: Huisong Li <lihuisong@huawei.com>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>

<snip>

> @@ -4791,6 +4802,20 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id,
>   	return ret;
>   }
>   
> +const char *
> +rte_eth_dev_rss_algo_name(enum rte_eth_hash_function rss_algo)
> +{
> +	const char *name = "Unknown function";
> +	unsigned int i;
> +
> +	for (i = 0; i < RTE_DIM(rte_eth_dev_rss_algo_names); i++) {
> +		if (rss_algo == rte_eth_dev_rss_algo_names[i].algo)
> +			return rte_eth_dev_rss_algo_names[i].name;
> +	}
> +
> +	return name;

My 2c:

IMHO, usage of name variable here just complicate reading and forces
reader to find out which value 'name' has here. Just return
"Unknown function".