From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A1E791B2B9 for ; Thu, 18 Jan 2018 09:44:45 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB09883F44; Thu, 18 Jan 2018 08:44:44 +0000 (UTC) Received: from [10.36.112.43] (ovpn-112-43.ams2.redhat.com [10.36.112.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 679DB5D97C; Thu, 18 Jan 2018 08:44:43 +0000 (UTC) To: Junjie Chen , jianfen.tan@intel.com, yliu@fridaylinux.org Cc: dev@dpdk.org References: <1516185726-31797-1-git-send-email-junjie.j.chen@intel.com> <1516203953-152604-1-git-send-email-junjie.j.chen@intel.com> From: Maxime Coquelin Message-ID: <0f5ea2ca-5684-8c12-a123-dacab2b071d5@redhat.com> Date: Thu, 18 Jan 2018 09:44:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516203953-152604-1-git-send-email-junjie.j.chen@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 18 Jan 2018 08:44:45 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] vhost: dequeue zero copy should restore mbuf before return to pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 08:44:45 -0000 On 01/17/2018 04:45 PM, Junjie Chen wrote: > dequeue zero copy change buf_addr and buf_iova of mbuf, and return > to mbuf pool without restore them, it breaks vm memory if others allocate > mbuf from same pool since mbuf reset doesn't reset buf_addr and buf_iova. > > Signed-off-by: Junjie Chen > --- > v2 changes: > Remove useless restore > lib/librte_vhost/virtio_net.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > Reviewed-by: Maxime Coquelin Thanks, Maxime