From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CB5A42D8E; Thu, 29 Jun 2023 18:14:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 616A040EDB; Thu, 29 Jun 2023 18:14:45 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2065.outbound.protection.outlook.com [40.107.237.65]) by mails.dpdk.org (Postfix) with ESMTP id 85797406B7 for ; Thu, 29 Jun 2023 18:14:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h6Bh/vOy2Vri34k+jLcRjyyxizA5ZcnkufiQELpK1BBi1P9b6C65LzHhknb/f3FxvZnwYiu6zpJ0a1DsCk9IYyJy170K+TJX0wGQCZ99bmo9S1SN/7Qi0mHBbFYeTGPuP4k+gt2Vs1WTIJLaeAhesprn0fkVmkqbHv82WeRFd8UR7zmA4bWYR+mn8d+NlBuGbTfeWh9VCjndDquUiGitVyL1g9fXH0BBgUVT78HVRpku7YUGJR5azMlSyI04hlwi5QYUuxN2ba1kndvgsKkw7y6ZsxjbVhyzQic4damOsUEJxK/gYwqEIk8ETtFQga5Ec3YCP7bIvkqYOX8GjbbRtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K/pPOG7L3hcqEaKFjKkcRNbAa95jwYomYQee1hZX1do=; b=Hs1Ec8FIqHSoAXkPCkk1lRm1fXOpsWUsr4A1FSonqJexNNWprmfgDW4c5C0+C4L8HoGVYJre6aE1vuH/A0VwPIfF6d0rXPuNQU53hTz30o61wAvrKcWb8iIIDZEthI5SbL7Quw61ccN9+aHIdTy+rQRutgKFiTqCZPtwZS+zwZlpebJVB0ViCLMcws7qUfWWpajq5ij7EV25twV8MQwx2VTyHHkFWTU+fO8RxAeljfQHEnzIE0vmExj8m3wa/nRK0rrJTVZi3Cr5XHNXHtdj4ZX0lVJNNtHWG1JbCojfEajIqlrS4f7O2Hyp7WH4nwME38rGCXzn2L/d7vQj0k8ERQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K/pPOG7L3hcqEaKFjKkcRNbAa95jwYomYQee1hZX1do=; b=gPrfKQIpxUU5qyMMuRLZwAlbHX+QC0bkE+1DHwG9pcdgik+1ZBz8NvSvT6RUxXAUEsP/Zg7syPXi11xeMmEsEZU3Q68lNGEswXwICx4U1KsEjs8yy1eWfjqZku/1DI8Vod4Xihq2lKyJkFJkDWrS8yhIZ3B/rh2zNfeK36ph2Cs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB8645.namprd12.prod.outlook.com (2603:10b6:208:48f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 29 Jun 2023 16:14:39 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6544.012; Thu, 29 Jun 2023 16:14:38 +0000 Message-ID: <0f62a3b9-9884-2892-50a0-e2d01fb37894@amd.com> Date: Thu, 29 Jun 2023 17:14:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Thomas Monjalon , David Marchand , Ori Kam , Andrew Rybchenko Cc: Kiran Kumar K , dev@dpdk.org References: <20230629135839.974700-1-david.marchand@redhat.com> <4981207.a9HWlOh95j@thomas> <2246452.o7ts2hSHzF@thomas> From: Ferruh Yigit Subject: Re: [PATCH] ethdev: fix Tx queue mask endianness In-Reply-To: <2246452.o7ts2hSHzF@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0563.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB8645:EE_ X-MS-Office365-Filtering-Correlation-Id: 44a1f070-cdf1-43df-c94b-08db78bbf02c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2muU6HpdYB+7VTVyJD7gk4DnF9i81rAm0TEw9mMG+Wigr3oNJk7dEzOvhmS+k948HhglpzZH54FDwmTd+J1fjjDkCSFyDGqP5sSzwKShMEb5CVXmvNRc/tQI1tgcnTHEWlloPHG0VGeDxjFzNHImzeKZuIiUcPjXnqFasL2CMTOO3ewMjmzhKTJdig41nxUsK0sDze1sWwxrfxrNOKMOJoLzqk01G7jiCzQiANO4N8ctY98blodUwbf23mbyunLXGvdxkiGfGVuiZ1PIv4WymmYQ4/qJGyLZZM8hAPC5qfDe5E2XuGB0ehPjZQVDyQgpcYH9uXqQ3xygsTEtZJSlNHw2T7CTXX/ym+MX8+XwxRwEKaEBIgGIEwavMXrNp52WgDhT1w2ee4tiFiFpK67KsY77vT8kZF+uDUIq4erCwXCyBOQ6dZ2Sbr7FtdzzWKIagodvyEQU5j4G+yOmb7QerGuaz2zL8Ld0gd+yOTWZpV/43CiOaILqzDRe4wFTqK/DaPvN4YynG8mctdO1Z/f2zM7k76F8OAjye7M2Wej6AatchZ7zFAzGYxWepBRAWvj6Hju8VILz6kjkanReKjHrnePIkhwxvqr0LxSpbxQTpE+7XocxH6KDdrnmTR4n/ApS5n4j97T3+yxVWFHUrL4FWg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(346002)(366004)(39860400002)(376002)(451199021)(316002)(66556008)(66946007)(66476007)(4326008)(478600001)(5660300002)(8676002)(36756003)(8936002)(31686004)(44832011)(6666004)(31696002)(86362001)(41300700001)(110136005)(6486002)(2906002)(53546011)(6506007)(6512007)(186003)(38100700002)(83380400001)(26005)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmVQYTJGY3dhSEt2M291ZDdKZFdETkhKZVAyVTlOUUFFVldkSHpXNk9vR0Ey?= =?utf-8?B?NlY3SjNYN0tsVldvYUxRSnBrNk9hVUhieS9lY3RsbWpzYVFEcEJkMGdySmdq?= =?utf-8?B?VVNydUM4N29OYlY2bUc1UzNoOUNuc0E2dVREUVZkbXRvZW00b3VMWFQ1OGZY?= =?utf-8?B?b2RUZW0zSDNDcVNyOHZDVllKOGxSL1EzWnorclNIVitnREhDbDBYRHR5c0Iw?= =?utf-8?B?N2VmZ1VBT0k5RDJ0VUdtT2dMSzF0VitvamViTC9PZnFQdWh3QURQaXlhK01r?= =?utf-8?B?MUNIV2JYS1VWcURxQWZIdlA5MTdCci8xT0JNTHN1WTJDZU41S1pQbkpVZmoy?= =?utf-8?B?K1lmY0pYbjJhU3ZUaDBnTkkrK0c4eTNyR1k2aFJVdktoNjJIdzBlOEE2bmdk?= =?utf-8?B?SzlmdDdtTWJnVVdBQkZRTCtRQmh4bzYrVVVCVmltaEJDaGdsRHVPUTIrMGxw?= =?utf-8?B?Z1o5a045TnNPc0RMQ0FQRGYybmVzWUFGTG5JY2E4dnY5RVAzLzJzc2FmSEVv?= =?utf-8?B?V2RjVmNIeXk2bGlGL213VURIWlhSS0tHSU8vTURvSVFORVZyVlVuT2VRYWQr?= =?utf-8?B?M3FoZGo1ZUNSNUs1QXpjanpmTTZKQ3N1WXBHUW9SK1EzanhSSisyUUtkM2xN?= =?utf-8?B?eTBKVFF4UVFBdXZ2NG8zeDFXNFhFL2hGeGNIbnFscXZOS05ucjZhbWVtK29h?= =?utf-8?B?VjJDLzZWcTd3SmJTTUtCZWwxalR5RXJzdjJnZGp4M0RrdjZmcE9EWU1FV3A5?= =?utf-8?B?NE9kZEttankxWU5qZDdNUHdaUU5CZjN3QnZVT25HbllESHBPaitMeUE1RDRJ?= =?utf-8?B?b2U4SVhQRkI5U1VNUy9wM0pPemRSRS9TSUhOMVFFeURkQ3VxQURzUGM0aEVX?= =?utf-8?B?V040UjQ1Z2tWejlSRWRsclJ1Y0w3dmhaREw4bU1LSm9yaGVNRlRCSkpxTUQ5?= =?utf-8?B?aHhmNExnaHJJQzhzcTdHVUY2YWJmbnlYKzBUcEpuRWhRVzdIUEhXZU5xNFRj?= =?utf-8?B?dlVjLzAxVU9rY1FlL0JiUlRQZW9iTm1wZjJVT3FRNUQ1aTRidUhCSmJ2ZnJN?= =?utf-8?B?WXh3WXhITEVINmtSTHpRRmZJeldabkk4OURJNkNoY1FsTFkxWUEyQXVTbWJL?= =?utf-8?B?bTRJLzZMOXAycXgyZUJGMmkwUjM5SlUrZ2s3aE01L0piMThMdVhNa29SSUxW?= =?utf-8?B?ZzA1c3JuY2ZxcGM5VUxmc09wc3UvZXpHdi9NUUxHcENiOXBHT2JpM015NjVy?= =?utf-8?B?Y2prbkU0RTViNzgzRzRUT2hsSVFQczRwNmVDb01YeTRXM1ladDNzWnE5cHZm?= =?utf-8?B?cWZXMExQalgxb0pISHVQWVZyM3ljSTB6RU5MWHpDU2FoK1Q2MzhOMG1uSmZM?= =?utf-8?B?TFIvRTc4ZUZWZ21OMFYzdDJVcUtnbWtIU0xMVFlDbTJZaGFNa0FEMXZyVzF6?= =?utf-8?B?cEt6d1R6TkVMazJ5d3VXclgyS0ZCNTB0dWR6enB6NDdPZ2dEekZrcVZwUVBx?= =?utf-8?B?T2JZZDB3dWNFV2wyZEJyNjRwRG4rZlJSZWxmSEQxWFhGaWIyV2dDenVHUStl?= =?utf-8?B?Wm5iYXdrWkcyMTJQQTRMN2FQRGkvUHJHK3YvcHVyc0ZPVnd1Ritwb0Ewalg4?= =?utf-8?B?S09WZ2VwVDVLRU1tMmlvYVVzVnUyTm9ISFhUbWV0Y2tkeGdtK0Z1TXo3YkZN?= =?utf-8?B?cVd0QjJoSXZBSkZQVWIydGUzUVcySExsdm0weG9nMUx3UDlYbDVWd3I1VTJ4?= =?utf-8?B?bnZ4S21DN0czdC82TW02WHpzT3Z2dVNWWFVtQ0puN1JtMW43Q0FQMGdYOU9W?= =?utf-8?B?TjVJcTV6UHNpL0p5SkNTQmFZTVNkUVdIRWhwd0xyaW9KdHphTUp5VW1qa2RF?= =?utf-8?B?cDI0cTFldXBCaFFRZ09OcVhIbDRraEhBZnk4RUUyQkx3QXp6T2VDajRoY21j?= =?utf-8?B?MnFHbkNER1hZTkRrQ2sxcjdiODBJZnB3NVZaTWlmSTJZRjhuSlZ2Vlg1bXpG?= =?utf-8?B?eXd3RFVsYnh1ZlFhOHNmMGRYcGMremdmVUpVVEU2SEF2K2hPOU9uajF0dDdn?= =?utf-8?B?YXRzVisrNEFqVTJwak1UamY5dlJBbDhSbXJ4S1JEajZTZHVRSWlyNm11c0l1?= =?utf-8?Q?xuAYxNGAT68jatVGlU5HVDLtR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44a1f070-cdf1-43df-c94b-08db78bbf02c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 16:14:38.8568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kpQooOr04n4q/sfdXgZKo1EhP5HCKfOdLvcvnEf2NFmXI1gQ1Y0a4U+nJT/n8M5n X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8645 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/29/2023 4:42 PM, Thomas Monjalon wrote: > 29/06/2023 17:40, David Marchand: >> On Thu, Jun 29, 2023 at 5:31 PM Thomas Monjalon wrote: >>> 29/06/2023 15:58, David Marchand: >>>> - .tx_queue = RTE_BE16(0xffff), >>>> + .tx_queue = 0xffff, >>> >>> As I said in an earlier comment about the same issue, >>> UINT16_MAX would be better. >> >> I don't mind updating (or maybe Ferruh can squash this directly ?) but >> there are lots of uint16_t fields initialised with 0xffff in this same >> file. > > It can be made in a separate patch for all occurences. > First I would like to get some comments, what do you prefer > between 0xffff and UINT16_MAX? > Both works, no strong opinion, I am OK with 0xffff, The variable we are setting is '*_mask', and main point of the value used is to have all bits set, and 0xff.. usage highlights it. Not for UINT16_MAX, but for wider variables, it is easier to make mistake and put wrong number of 'f', using 'UINTxx_MAX' macro can prevent this mistake, this is a benefit. And I think consistency matters more, so if you prefer 'UINTxx_MAX', lets stick to it. I can update above in next-net, but as far as I understand we can have a patch to fix all occurrences.