From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1A0057D4A; Mon, 10 Dec 2018 11:49:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Dec 2018 02:49:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,338,1539673200"; d="scan'208";a="99485318" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.93]) ([10.237.220.93]) by orsmga006.jf.intel.com with ESMTP; 10 Dec 2018 02:49:06 -0800 To: Seth Howell Cc: dev@dpdk.org, stable@dpdk.org, Darek Stojaczyk References: <20181204170610.250124-1-seth.howell@intel.com> <20181207201042.372870-1-seth.howell@intel.com> From: "Burakov, Anatoly" Message-ID: <0f7b6cfb-e7d0-b511-b943-7f1b3b3eda2f@intel.com> Date: Mon, 10 Dec 2018 10:49:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2 MIME-Version: 1.0 In-Reply-To: <20181207201042.372870-1-seth.howell@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] malloc: notify primary process about hotplug in secondary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 10:49:09 -0000 On 07-Dec-18 8:10 PM, Seth Howell wrote: > When secondary process hotplugs memory, it sends a request > to primary, which then performs the real mmap() and sends > sync requests to all secondary processes. Upon receiving > such sync request, each secondary process will notify the > upper layers of hotplugged memory (and will call all > locally registered event callbacks). > > In the end we'll end up with memory event callbacks fired > in all the processes except the primary, which is a bug. > > This gets critical if memory is hotplugged while a VFIO > device is attached, as the VFIO memory registration - > which is done from a memory event callback present in the > primary process only - is never called. > > After this patch, a primary process fires memory event > callbacks before secondary processes start their > synchronizations - both for hotplug and hotremove. > > Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") > > Signed-off-by: Seth Howell > Signed-off-by: Darek Stojaczyk > --- Lost my review tag... Reviewed-by: Anatoly Burakov -- Thanks, Anatoly