Re: [dpdk-dev] [dpdk-stable] [PATCH v2 18.11 17.11] doc: in doc-clean removed the folder not containing rst files

[Kevin Traynor <ktraynor@redhat.com>]

On 24/03/2020 12:57, Kevin Traynor wrote:
> On 24/03/2020 07:04, Muhammad Bilal wrote:
>> On Fri, Mar 20, 2020 at 3:02 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>>>
>>> On 20/03/2020 09:53, Muhammad Bilal wrote:
>>>> On Fri, Mar 20, 2020 at 2:39 PM Luca Boccassi <bluca@debian.org> wrote:
>>>>>
>>>>> On Fri, 2020-03-20 at 13:02 +0500, Muhammad Bilal wrote:
>>>>>> in doc-clean removing the folder which contain
>>>>>> the text files and no .rst files,
>>>>>> they cause problem When switching branches and compiling
>>>>>> the documentation for older releases (for example
>>>>>> building a documentation on 18.11 or 17.11, with a
>>>>>> documentation on master branch, built before.
>>>>>>
>>>>>> Bugzilla ID: 364
>>>>>> Cc: Thomas Monjalon <thomas@monjalon.net>
>>>>>> Cc: John McNamara <john.mcnamara@intel.com>
>>>>>> Cc: M: Luca Boccassi <bluca@debian.org>
>>>>>> Cc: dev@dpdk.org
>>>>>> Cc: stable@dpdk.org
>>>>>> Signed-off-by: Muhammad Bilal <m.bilal@emumba.com>
>>>>>> ---
>>>>>> v2:
>>>>>> * Added Details of branches for which patch is used.
>>>>>> * This patch is intended for v18.11 and v17.11 branches
>>>>>
>>>>> Thanks for the patch, but 17.11 is EOL and will no longer receive
>>>>> updates.
>>>>>
>>>> This bug also occurs on 18.11
>>>> So this patch is also valid for 18.11.
>>>
>>> No, This patch is not for dpdk master, it is intended only for 18.11 branch
>>> when we switch to 18.11 branch (after making documentation in master or newer branch ) an error occurs in making documentation on 18.11 branch.
>>> So This patch is intended to solve this problem.
> 
> The line to remove the search dir from commit [1] fixes the api build
> for me.
> 
> My pdf build is not working atm and I'm not sure about the paths. Can
> doc maintainers review this please.
> 

pdf part not fully reviewed. Reworded commit message, removed the
additional tags and applied. Thanks.

> [1]
> commit 92d6c874d33dbbd3ace7c06a3490a61ff6641d61
> Author: Aideen McLoughlin <aideen.mcloughlin@intel.com>
> Date:   Thu Jun 27 14:58:19 2019 +0100
> 
>     doc: add search engine for API
> 
>>>>> --
>>>>> Kind regards,
>>>>> Muhammad Bilal
>>>>
>>>
>>
>