From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by dpdk.org (Postfix) with ESMTP id EDACB1BC10; Fri, 19 Apr 2019 00:50:24 +0200 (CEST) Received: by mail-qk1-f172.google.com with SMTP id j10so2099916qkk.6; Thu, 18 Apr 2019 15:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+whCFHDoQqJYLGbgvE/IajgjZK9fFn00XImiJKeJsi4=; b=qKCrRGbr+lLxSMQwdFuhG/sCq6JnZr5aDfpqUgX9gV68ehmzyQ/1mkN4dxBYrOLsoQ KqcnYoVtg30NStJKJQ/rqJwQ12wvvdovDazmQo8DiCDq8+V7nV5Dpz948mNCv6Yy2D0D ewSEn/MfBy1dh2x1Yv5/NBX80ldMPBLTck7wt59LwXKmfpu2zqypiwxOaU8BNl7pte0I 2iRqjXsc8zAUJEPN0FWs4vsmzUFKFY8/4cLCGVIi83ENi3zgYcViwvOXf1bVDWU433Bg ygjraHz4h54GBkBWiBw/IaWcJGalexdwyRZ01tJaVgOHFG0U7ZA4RnOvKJHQqK0tzs4F OkqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+whCFHDoQqJYLGbgvE/IajgjZK9fFn00XImiJKeJsi4=; b=CmrJ5sG8LKV6XcWu9tlQoKGDXGEEFG2eh4r8Xp5Z4H1qsYrCH22jZS1ABZu/qI6kPV HSuZmrU4MPYQ1yOW/c7tNB0AoZilhbJvDwWa3Oyr8Y8mRLS65aYUEvrApWDSsy7y3veY QhyYdG4JetYOCZ10o3D30COKT1lNPD1+2Z6UY5pd7tTH7Ag0rBMLYvnl1RkzmgtfOcE6 pc1ByHLDBRG/aY1rShGHMNPtHIPKNod/ADG2jbUo53ux/Wf6ZupfT0bqy/DbYfa1aQZ2 paH4OlW4VZgo+hubYJjn2LB46WnFFT30zT7f0RpRmLWMtIzrrQh9bo5L+wkgiBMjUP14 irIw== X-Gm-Message-State: APjAAAW5ByWZTHVAQhDbh7e2daIN/frNjcg+YxB1CDtmHE6ex86CfNmK XLq63EruPxR2eR1hcPP1R1AlZdud X-Google-Smtp-Source: APXvYqzflgzk37R/hA+g5D8oK91COcsARjZx1cQlgKZSP5erzvIsX/ocWx04u5h7wMVJXhxqmPM9cg== X-Received: by 2002:a37:a64b:: with SMTP id p72mr590953qke.144.1555627824130; Thu, 18 Apr 2019 15:50:24 -0700 (PDT) Received: from [192.168.1.10] (pool-96-255-82-34.washdc.fios.verizon.net. [96.255.82.34]) by smtp.gmail.com with ESMTPSA id d21sm2406280qtc.91.2019.04.18.15.50.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 15:50:23 -0700 (PDT) To: David Marchand Cc: dev , =?UTF-8?Q?Przemys=c5=82aw_O=c5=82tarzewski?= , dpdk stable References: <1554900829-16180-1-git-send-email-david.marchand@redhat.com> <1554900829-16180-3-git-send-email-david.marchand@redhat.com> <9a4fa115-0f92-9686-ae89-0f1427ab6d29@gmail.com> From: Chas Williams <3chas3@gmail.com> Message-ID: <0f8dc043-cd47-d677-872a-54fbd4477f64@gmail.com> Date: Thu, 18 Apr 2019 18:50:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 22:50:25 -0000 On 4/18/19 3:11 AM, David Marchand wrote: > Hello Chas, > > On Fri, Apr 12, 2019 at 4:02 PM Chas Williams <3chas3@gmail.com > > wrote: > > I should have some time this weekend to run these patches through our > regression system. > > > Did you manage to run this series through your tests system ? There were some other issues over the weekend. Hopefully this one. > > > On 4/10/19 8:53 AM, David Marchand wrote: > > @@ -357,10 +318,16 @@ > >                       hdr = rte_pktmbuf_mtod(bufs[j], struct > ether_hdr *); > >                       subtype = ((struct slow_protocol_frame > *)hdr)->slow_protocol.subtype; > > > > -                     /* Remove packet from array if it is slow > packet or slave is not > > -                      * in collecting state or bonding interface > is not in promiscuous > > -                      * mode and packet address does not match. */ > > -                     if > (unlikely(is_lacp_packets(hdr->ether_type, subtype, bufs[j]) || > > +                     /* Remove packet from array if: > > +                      * - it is slow packet but no dedicated rxq > is present, > > +                      * - slave is not in collecting state, > > +                      * - bonding interface is not in > promiscuous mode and > > +                      *   packet is not multicast and address > does not match, > > +                      */ > > +                     if (unlikely( > > The coding style checker doesn't like this: > > CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' > > > Yes, I had seen this warning, just found it easier to read this way. > > > > > +                             (!dedicated_rxq && > > +                              is_lacp_packets(hdr->ether_type, > subtype, > > +                                              bufs[j])) || > >                               !collecting || > >                               (!promisc && > > > !is_multicast_ether_addr(&hdr->d_addr) && > > > > -- > David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9EF37A00E6 for ; Fri, 19 Apr 2019 00:50:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58CC31BC7A; Fri, 19 Apr 2019 00:50:26 +0200 (CEST) Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by dpdk.org (Postfix) with ESMTP id EDACB1BC10; Fri, 19 Apr 2019 00:50:24 +0200 (CEST) Received: by mail-qk1-f172.google.com with SMTP id j10so2099916qkk.6; Thu, 18 Apr 2019 15:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+whCFHDoQqJYLGbgvE/IajgjZK9fFn00XImiJKeJsi4=; b=qKCrRGbr+lLxSMQwdFuhG/sCq6JnZr5aDfpqUgX9gV68ehmzyQ/1mkN4dxBYrOLsoQ KqcnYoVtg30NStJKJQ/rqJwQ12wvvdovDazmQo8DiCDq8+V7nV5Dpz948mNCv6Yy2D0D ewSEn/MfBy1dh2x1Yv5/NBX80ldMPBLTck7wt59LwXKmfpu2zqypiwxOaU8BNl7pte0I 2iRqjXsc8zAUJEPN0FWs4vsmzUFKFY8/4cLCGVIi83ENi3zgYcViwvOXf1bVDWU433Bg ygjraHz4h54GBkBWiBw/IaWcJGalexdwyRZ01tJaVgOHFG0U7ZA4RnOvKJHQqK0tzs4F OkqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+whCFHDoQqJYLGbgvE/IajgjZK9fFn00XImiJKeJsi4=; b=CmrJ5sG8LKV6XcWu9tlQoKGDXGEEFG2eh4r8Xp5Z4H1qsYrCH22jZS1ABZu/qI6kPV HSuZmrU4MPYQ1yOW/c7tNB0AoZilhbJvDwWa3Oyr8Y8mRLS65aYUEvrApWDSsy7y3veY QhyYdG4JetYOCZ10o3D30COKT1lNPD1+2Z6UY5pd7tTH7Ag0rBMLYvnl1RkzmgtfOcE6 pc1ByHLDBRG/aY1rShGHMNPtHIPKNod/ADG2jbUo53ux/Wf6ZupfT0bqy/DbYfa1aQZ2 paH4OlW4VZgo+hubYJjn2LB46WnFFT30zT7f0RpRmLWMtIzrrQh9bo5L+wkgiBMjUP14 irIw== X-Gm-Message-State: APjAAAW5ByWZTHVAQhDbh7e2daIN/frNjcg+YxB1CDtmHE6ex86CfNmK XLq63EruPxR2eR1hcPP1R1AlZdud X-Google-Smtp-Source: APXvYqzflgzk37R/hA+g5D8oK91COcsARjZx1cQlgKZSP5erzvIsX/ocWx04u5h7wMVJXhxqmPM9cg== X-Received: by 2002:a37:a64b:: with SMTP id p72mr590953qke.144.1555627824130; Thu, 18 Apr 2019 15:50:24 -0700 (PDT) Received: from [192.168.1.10] (pool-96-255-82-34.washdc.fios.verizon.net. [96.255.82.34]) by smtp.gmail.com with ESMTPSA id d21sm2406280qtc.91.2019.04.18.15.50.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 15:50:23 -0700 (PDT) To: David Marchand Cc: dev , =?UTF-8?Q?Przemys=c5=82aw_O=c5=82tarzewski?= , dpdk stable References: <1554900829-16180-1-git-send-email-david.marchand@redhat.com> <1554900829-16180-3-git-send-email-david.marchand@redhat.com> <9a4fa115-0f92-9686-ae89-0f1427ab6d29@gmail.com> From: Chas Williams <3chas3@gmail.com> Message-ID: <0f8dc043-cd47-d677-872a-54fbd4477f64@gmail.com> Date: Thu, 18 Apr 2019 18:50:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418225022.sN9A9MbibLgMMXcsxPCepDT6Ce1IkZxcovlvYHbZyDs@z> On 4/18/19 3:11 AM, David Marchand wrote: > Hello Chas, > > On Fri, Apr 12, 2019 at 4:02 PM Chas Williams <3chas3@gmail.com > > wrote: > > I should have some time this weekend to run these patches through our > regression system. > > > Did you manage to run this series through your tests system ? There were some other issues over the weekend. Hopefully this one. > > > On 4/10/19 8:53 AM, David Marchand wrote: > > @@ -357,10 +318,16 @@ > >                       hdr = rte_pktmbuf_mtod(bufs[j], struct > ether_hdr *); > >                       subtype = ((struct slow_protocol_frame > *)hdr)->slow_protocol.subtype; > > > > -                     /* Remove packet from array if it is slow > packet or slave is not > > -                      * in collecting state or bonding interface > is not in promiscuous > > -                      * mode and packet address does not match. */ > > -                     if > (unlikely(is_lacp_packets(hdr->ether_type, subtype, bufs[j]) || > > +                     /* Remove packet from array if: > > +                      * - it is slow packet but no dedicated rxq > is present, > > +                      * - slave is not in collecting state, > > +                      * - bonding interface is not in > promiscuous mode and > > +                      *   packet is not multicast and address > does not match, > > +                      */ > > +                     if (unlikely( > > The coding style checker doesn't like this: > > CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' > > > Yes, I had seen this warning, just found it easier to read this way. > > > > > +                             (!dedicated_rxq && > > +                              is_lacp_packets(hdr->ether_type, > subtype, > > +                                              bufs[j])) || > >                               !collecting || > >                               (!promisc && > > > !is_multicast_ether_addr(&hdr->d_addr) && > > > > -- > David Marchand