From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22EC0A0C61; Fri, 5 Nov 2021 10:40:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB4DA410DC; Fri, 5 Nov 2021 10:40:58 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 8DB5340E5A for ; Fri, 5 Nov 2021 10:40:56 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10158"; a="232121843" X-IronPort-AV: E=Sophos;i="5.87,211,1631602800"; d="scan'208";a="232121843" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2021 02:40:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,211,1631602800"; d="scan'208";a="450749083" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 05 Nov 2021 02:40:42 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 5 Nov 2021 02:40:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 5 Nov 2021 02:40:41 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 5 Nov 2021 02:40:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NDrz4qbjrQSUBA1yEvN3cPshpeQ4pUxuKfls+hrBdpFyLFjGfgivir8AP4/sf3sofgn6WGe5e6uRQjsxpywNVyw4y+NKyBOOmAn38KND+c5yIHkFfIE1v+1seEmgWzIaOXNpTsjKbTh41/Da+NebinQotVjgbLq9/6oWTdfSAyuUKhcRFh8qbgqWmiYYoI+NiEaV3Uek0Ea0zHcZKPBkZ5fw5v2+4bWFuBJgQHu7OcaWsfQsvJq0RlTdQ21Bb6MOLqi3nJr3RcDslu000Gu+2hbLTBmirH8f0N2jOlco2drqst5KepPYw5iXf+XrxmAvqIrrgeV7yPfRV34O3hkdZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6qJghdKw/eWrv3JqBOZfXxO9uc5nfzRBulVbzXLWX+w=; b=bHet5SsSlTjAJZ4IVb8O/EskA0etKfH2NWaca29o5hj1U8JJmNs9GEoY4GD1bOcVhjl8ETuECWHhpRSwU6B/0PAHUNNT6kMW6P2E5La37bEH5k42gZnHdiAdgfw/OTXJYlRo77jQCQi0l6QcgcYQuf9KwIEt1T2ESccveJPqrqVAkH0v1Dnlgq6ZiiR4opHsnVK3mLQEDuJ8X6ZHRUODCxuHxsamxAKJ/XPQS+rkU6iePwKH3cqL1rv3JJiTdeE1gjkOZj+shkOSHB/0Tty2lgtBEEmdZGY4/M0PJMJuIKK9vllkggRILNvnz4YuNU3Iw6qePVYYP6jDPqnYoZleVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6qJghdKw/eWrv3JqBOZfXxO9uc5nfzRBulVbzXLWX+w=; b=P3W4iy14t8fLFKnxFgMceA60N4DOT8yRZFHT6aggXK7AeRo7wrzbdqpodrNMJcPLg3FD1aiZmV6NrRCkDraDFuU0+KCE1wo7OT5Ar/ZBz1gyHYy5qe4mBMvJVWWvbxrzIUNUp3mv5SKh/Wcss5N1xney0Ew2vIuWcEbA5uuLAZo= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5109.namprd11.prod.outlook.com (2603:10b6:510:3e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Fri, 5 Nov 2021 09:40:40 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Fri, 5 Nov 2021 09:40:40 +0000 Message-ID: <0f98aa4b-599e-c3ed-6dd4-64ea7d514ff7@intel.com> Date: Fri, 5 Nov 2021 09:40:34 +0000 Content-Language: en-US To: Andrew Rybchenko , Vijay Srivastava , , Hemant Agrawal CC: , , "Vijay Kumar Srivastava" References: <20210706164418.32615-1-vsrivast@xilinx.com> <20211103135754.17411-1-vsrivast@xilinx.com> <20211103135754.17411-2-vsrivast@xilinx.com> <5aae6385-6310-7692-913e-bb4d93ad390d@intel.com> <0d00a43b-33c7-8c46-6930-3f33b360bebb@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <0d00a43b-33c7-8c46-6930-3f33b360bebb@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0085.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::18) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO2P123CA0085.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Fri, 5 Nov 2021 09:40:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2d3d5309-1c1a-4f61-7b22-08d9a04053f8 X-MS-TrafficTypeDiagnostic: PH0PR11MB5109: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3BcR7pqyOCw/mS/3vXz9F09d6IDMgc1V6XgjTV7Kp3IXU1Ex2OjwuT82gxiy6YOMvFv1GbBd1RVy51ntq9Otr0FYCGHUaYSnzBukCzOTgmKGDGDQ3xBI1WHIE4ZSb0bbpE01hMEZqRgMbYHwX9rZPt+MJif6LxG1rquizD5Uxgmw6s0IDeeCPGRI65/5WeonhsuS1qkfd6Hr6NYd6z7W/JlswSYM7Gv8ACRxrz9A68zjQbm3FaR2j4CbiQtsY+xqtI5vWGqRfpciUJm1S+V8yAIAZj52VuyCtde7CqoPYwZB4StY/bnMjLH80rW2wZ+t28CpRCRk8qVNlUsnVL/k4acjg1uqg8vhewIvY6nrNTmuoLSbBgoE9LRnlRewpkcSBVV9WPuwiBJvvn293OpMXEUvSb4SXNZHSLSUnxn8qt3Qc2+W5TSb9hXIU6HDdl6Yt1puH6gLcrWvW3OH0XHapFiKA289QAufiHAHO8u0yrcNhucXy1tHuZTJjXOSAqHDqAPXzh9f3wcmdTrdsbhHWYLXAZbZfErKztfGPefa49ZRKaUWO4nfKux2dzRwNMoam5qLTOv0BMUB2iOmmGkVuI5DDyaOEVqy3x8R5xNzGAx50MguG5Qts9xmDCeOX1wxO/1/6hCi5PZi03G9GX+HD7TN+un0THO7e6dO+m0FRMzRvpUAH9E05kWCo1NimcXyngyqsH2vK5Ggw3zFs+eEQw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(66946007)(66556008)(26005)(38100700002)(66476007)(8936002)(508600001)(53546011)(86362001)(8676002)(316002)(5660300002)(31696002)(36756003)(82960400001)(6486002)(16576012)(956004)(110136005)(4326008)(2616005)(44832011)(6666004)(186003)(31686004)(83380400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0JUZUU4TmZOVGJZSzd5cFR6cjJpTjd5TERkUnBhcGsyYjhSNlpNTC9tNGlF?= =?utf-8?B?SUVEMnVzY3lvMUMyVEZJYU5hUkp0azNTSmFjd055UGsrU1ZMdWFacTJ6TGVN?= =?utf-8?B?ZGY1ZVArblJnbHRPM0M0QU9teVRqbHBMYlJBZndOeGpNWDZXL2htVndzekw4?= =?utf-8?B?cmNYVjA4azdJT1F6anZwRW1MTlpHcURlcFB3d3ZuOFNJMGpPUFdwVVZqQ2F6?= =?utf-8?B?U0QvT2pqSGZ4L1pzclhrbnN6ZCt1Y1RmU0JJa3dkYW5GVDBVZEp5SER4TE1S?= =?utf-8?B?NS9KdjdQM1hoSElFK0pwWjZ5OXJsQlFEb09NeFI1U2ZucGdkY2dFZHRZTFdi?= =?utf-8?B?Y0xUVDR0MllOSFBrV1VWWHFQUjhIVUF4TVpLQmJRMThRUk9vL3JGWU90OXhD?= =?utf-8?B?bkxSQzhVQTJYY3luYUdHN3pKK0pPbkxUMjcxLzMrSG05ZzNUenI5aW1sb3ZY?= =?utf-8?B?bUoyN2RxaDM3a0hYVUZ4MTJOdmxVRTd5SGViWUpoYm5uTUFsK2lEektEekVJ?= =?utf-8?B?bzViaGV2VWRvVDdhZS81UDRmMFM5L0NhT0RQY05DcnhHRVpmWGNnaG9ubDJI?= =?utf-8?B?Vkp4WVFoWTZNNXVLUTN2NnZjN0l2Vzl5NmV1enJSN1lZZ2tJSWQ3WWkzNnE0?= =?utf-8?B?NjVjTDE0Q1JET1RnMGxPVk1kcWhIMmhjeU45d0cvYVFMdDhGMW8rSkdxekZ1?= =?utf-8?B?QU5JcXd5TDJQTjZONkZ0L1Jnd08rRWdkV0V1YlozamFjdHpqWkxwTkdOZjBs?= =?utf-8?B?L0Y4b0VWMzdzdFJGeStPRlNydkdzNkpGMDBEaWRLZ1VYTW4wT1NLMHZXTi9L?= =?utf-8?B?N2UxKzZWZktKeGFXci9LV2pRSk5FbC9WUmU3bEJWL2JxaHB0WUZOOWhqak1K?= =?utf-8?B?R2ZtVGxJN2loOVRDSUMrKzFoS2pGSEhlUVMyYVlRc0Rpa1JQOHJzbzVSYzVr?= =?utf-8?B?c3hKUElMdDFXUzBsakVQYjNFZXJlQ2wvZlJyU1h3aGtiMjdRbGtlV1VxMVFp?= =?utf-8?B?UUgxSlNCQmRCSjd6ek5QRS9xZm9OL0xrTHR3QWVjdGh5NmxoR3pYM3REb3Zo?= =?utf-8?B?ZDUxSm9Ka1lYbWczLzQ5Y0VLb1BpMEZ6dFdCVjdobHZDV0Z1WnFJZXhqTDhK?= =?utf-8?B?ZDdYMzNXMU1vWjRFZnV2TjduUnhVMTFWVVJtVUNNZzJIVWUwS2lhZTk2dUpO?= =?utf-8?B?R1BldEw0RmVkblliU1pNSk10WU9VVUF4cFFwcXlkUDJ0TjI5NWUyRkR6MjZU?= =?utf-8?B?Y2xJYnFpbnR1NFYrRVc2OHJuQmJzZzlNbDJLZ3hQRlFyZzU3TkNBd0NpRWRW?= =?utf-8?B?NmtCeElORzJCL0xxcjgzUnliV2lMdE1WMXNhMHZSQXNHTU5MUGtaYXhyLzBi?= =?utf-8?B?YytiMW1vSjlPVFhKdjM1bEJGQTI5RmtiaWpJM3crWEFCS3FXVngrTzMyODRK?= =?utf-8?B?Ni9zZ2J6U3RKN2cvVHpvZGd2eGQvR1VnVC9rUTJNelJ0bzBmM2VPMG54bnk2?= =?utf-8?B?Qy9oa1pQWGR0R3BGSi96R2JoMHdJOFAxMUpvdUJHUForL3pjejB6MjhHdmE4?= =?utf-8?B?WVhHSEVRNCtzeVI0NG1zYTQ4Y2hpN2wrMWQ3NzNaOGxpN0dpSkhsRjFlTGti?= =?utf-8?B?ZFdIbE1UdUVXVGhsTkZibE4rYmpmamxwdUJWUVhEeWdnbVlQYmRWMHo1aUhi?= =?utf-8?B?MElnbVZ4dnhaNDJSeFRLM1ZOSnhpRW5CUmU3RE9kUlROTSthTFRYSnRjcGEr?= =?utf-8?B?RnZDRVFFc0lxU1J4VjkzUzN6QUpFZmtRa3JSdEtyWEJrVTkwdDczSVh0bk5n?= =?utf-8?B?M3BveGdSSkdvbjFiT2J2b3pTUmh3aUUzZjRCZDJJRVcwOEV0NGFuVGxqbTBK?= =?utf-8?B?TFFjNno2RUlteXlEa3VpdFh0MTdsZVY0SVBTdjBuU053UzJNdHJIMS9MYkFu?= =?utf-8?B?dWNGaE0xaEMxaUhudS9zRjRpS3FVWVFKK0lNZ2Rlb0JNenE2L1krS212UnB1?= =?utf-8?B?QlR6eHRZODRpZW9Za1pXa0x0aUE3WUlWeGtMM2xZRGFSQ0RDQWxaVjQ0SXFt?= =?utf-8?B?TndRWE42dFZEeDdmWEFXZEdRbFNqeFR4a2R4SjVUWHQrbFFLU3FndlVTeXVM?= =?utf-8?B?TmQvSncxRGtHNWtraWFXV0dUWE41ejA3NnFUeGR1M0tCaTZGQjh4Tk0vekpQ?= =?utf-8?Q?e4cx/HP2PYGnZmXFSgCW18I=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2d3d5309-1c1a-4f61-7b22-08d9a04053f8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 09:40:40.1519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E1BASCJq20ngWfpuIeqVbiMIXZ9CvSpNSSHSrlMVThvUr2I2MgsFRCxdUTixqc/4A9JK5Twl/WfcoOziTNCTMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5109 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/5/2021 9:28 AM, Andrew Rybchenko wrote: > On 11/5/21 12:13 PM, Ferruh Yigit wrote: >> On 11/3/2021 1:57 PM, Vijay Srivastava wrote: >>> diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c >>> new file mode 100644 >>> index 0000000..f087944 >>> --- /dev/null >>> +++ b/drivers/vdpa/sfc/sfc_vdpa.c >>> @@ -0,0 +1,282 @@ >>> +/* SPDX-License-Identifier: BSD-3-Clause >>> + * >>> + * Copyright(c) 2020-2021 Xilinx, Inc. >>> + */ >>> + >> >> Only sfc has that blank line between SPDX tag and Copyright, >> is it intentional? > > As far as I remember it is not intentional. Just coincident > and may be definitely fixed in vdpa/sfc. > >> >> +Hemant, not sure if we enforce any specific syntax? >> >> >> If there is no specific reason, I think better to have common syntax, >> that helps to scripts etc.. >> It may be noise to update existing code, but we can fix it in >> new code. > > +1 > If there is not objection, I will remove that empty lines in this set, while merging next-net.