From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D92AC454EF; Tue, 25 Jun 2024 13:22:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC34442F69; Tue, 25 Jun 2024 13:18:06 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id 7E4E642D8C for ; Tue, 25 Jun 2024 13:16:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719314214; x=1750850214; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vha+M0CuM1jrCRCeUS5ZAZ0hkmb8C+zcnx5e8AsTGRk=; b=bC9Hib2GipT2/q9fiCZcUkfiUBq8OP+yn33yrfjQEGmghMq9CFLhGLqm zmRryeqNcRpc41eqUrnU65kLPq5WQJAc1m4+HJEKU2HarmKZGAEuS/4F/ W7MV17bIdo/DimVQPQSojbqyusdC7PVyOQiau+ey1kDpWKM/J1tWqIV6z OIHuYg3BqfaZGAlRQXPIfhrHABQPij3V6DREgGexX+b30PAuT32S4NT+k TJ0tNnx7EU/nsTZy+5j3lSMXCzHVNH8tx46ljh7LSubmB5W1JleIRTZuL mftTsrd94rFza1ik95qjBxm/wBlG3MLNpOqmNSbvT7/qTV1igLI1Y4myF w==; X-CSE-ConnectionGUID: XCQuta7DSuavDsFSO4Wm/w== X-CSE-MsgGUID: QNuspTuESUGuxnwHA+FuZA== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="16080263" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="16080263" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 04:16:30 -0700 X-CSE-ConnectionGUID: yhZitUU5Q3C99uAWPFDy8A== X-CSE-MsgGUID: rhUte3HbTqKAJeTH+iZ65Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="43719230" Received: from unknown (HELO silpixa00401119.ir.intel.com) ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 25 Jun 2024 04:16:29 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Jacob Keller , bruce.richardson@intel.com, ian.stokes@intel.com Subject: [PATCH v3 055/129] net/ice/base: be more verbose when preparing timer sync Date: Tue, 25 Jun 2024 12:13:00 +0100 Message-ID: <0f9f902b4bd0e60ecb698a7b957aa94d374581f2.1719313663.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jacob Keller Add an informative error message when preparing external PHYs for a timer sync fails. Signed-off-by: Jacob Keller Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c index 9a60b5daeb..926cb23cf1 100644 --- a/drivers/net/ice/base/ice_ptp_hw.c +++ b/drivers/net/ice/base/ice_ptp_hw.c @@ -4912,9 +4912,16 @@ int ice_ptp_port_cmd_e810(struct ice_hw *hw, enum ice_ptp_tmr_cmd cmd, bool lock_sbq) { u32 val = ice_ptp_tmr_cmd_to_port_reg(hw, cmd); + int err; - return ice_write_phy_reg_e810_lp(hw, E810_ETH_GLTSYN_CMD, val, - lock_sbq); + err = ice_write_phy_reg_e810_lp(hw, E810_ETH_GLTSYN_CMD, val, + lock_sbq); + if (err) { + ice_debug(hw, ICE_DBG_PTP, "Failed to write back GLTSYN_CMD, err %d\n", err); + return err; + } + + return 0; } /* E810T SMA functions -- 2.43.0