From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB204A00C5; Thu, 15 Sep 2022 12:14:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC05C4021D; Thu, 15 Sep 2022 12:14:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D1A2D40156 for ; Thu, 15 Sep 2022 12:14:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663236850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mBmDjHLhPfvwjb305SPXsO1I9xEdhFhiBnEV6TwWLmw=; b=M/mnBTYCvS0sPDtoczKmLyKBzUxCf0gNS6yUimP8hlyCdy4GR4qHDpngDM2qgn6NTMQZUR 9CRcMvLSd8QzIZJ9G7cInrC7xSVEp8OcggFLpbFlpKPVmt5231xkbdhVPwL5WyoSI4NUB8 27tdQaq7OnFDJw/ukOdmtlozGUSW+VA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-92-NqjmZk4HOMaIjQCihDGCAw-1; Thu, 15 Sep 2022 06:14:05 -0400 X-MC-Unique: NqjmZk4HOMaIjQCihDGCAw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D15071C1B10A; Thu, 15 Sep 2022 10:14:04 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4E46492B04; Thu, 15 Sep 2022 10:14:03 +0000 (UTC) Message-ID: <0fb54305-ae68-b81d-b05e-b57ca091cb96@redhat.com> Date: Thu, 15 Sep 2022 12:14:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 24/37] baseband/acc100: rename ldpc encode function arg To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-25-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-25-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Rename total_enqueued_cbs to total_enqueued_descs in the > enqueue_ldpc_enc_n_op_cb function. No functional impact. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 0389768a6f..a302905c78 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -2967,10 +2967,13 @@ enqueue_enc_one_op_cb(struct acc100_queue *q, struct rte_bbdev_enc_op *op, > return 1; > } > > -/* Enqueue one encode operations for ACC100 device in CB mode */ > + > +/* Enqueue one encode operations for ACC100 device in CB mode > + * multiplexed on the same descriptor > + */ > static inline int > enqueue_ldpc_enc_n_op_cb(struct acc100_queue *q, struct rte_bbdev_enc_op **ops, > - uint16_t total_enqueued_cbs, int16_t num) > + uint16_t total_enqueued_descs, int16_t num) > { > union acc100_dma_desc *desc = NULL; > uint32_t out_length; > @@ -2980,14 +2983,13 @@ enqueue_ldpc_enc_n_op_cb(struct acc100_queue *q, struct rte_bbdev_enc_op **ops, > struct rte_bbdev_op_ldpc_enc *enc = &ops[0]->ldpc_enc; > > #ifndef RTE_LIBRTE_BBDEV_SKIP_VALIDATE > - /* Validate op structure */ > if (validate_ldpc_enc_op(ops[0], q) == -1) { > rte_bbdev_log(ERR, "LDPC encoder validation rejected"); > return -EINVAL; > } > #endif > > - uint16_t desc_idx = ((q->sw_ring_head + total_enqueued_cbs) > + uint16_t desc_idx = ((q->sw_ring_head + total_enqueued_descs) Take the opportunity to move the declaration before the code. > & q->sw_ring_wrap_mask); > desc = q->ring_addr + desc_idx; > acc100_fcw_le_fill(ops[0], &desc->req.fcw_le, num, 0); With this small change handled: Reviewed-by: Maxime Coquelin Thanks, Maxime