From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 2596E2C6B
 for <dev@dpdk.org>; Fri, 13 Jan 2017 15:44:24 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga105.jf.intel.com with ESMTP; 13 Jan 2017 05:17:18 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,221,1477983600"; d="scan'208";a="212956167"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by fmsmga004.fm.intel.com with ESMTP; 13 Jan 2017 05:17:17 -0800
To: Olivier Matz <olivier.matz@6wind.com>
References: <1484226296-540-1-git-send-email-olivier.matz@6wind.com>
 <2c9b018f-bad8-449a-acf7-e2da82bdc464@intel.com>
 <20170113134824.6542fc5e@platinum>
Cc: dev@dpdk.org, alejandro.lucero@netronome.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <0fe55cec-99fe-8f61-9aa9-02cb51e9f990@intel.com>
Date: Fri, 13 Jan 2017 13:17:17 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <20170113134824.6542fc5e@platinum>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2017 14:44:24 -0000

On 1/13/2017 12:48 PM, Olivier Matz wrote:
> On Fri, 13 Jan 2017 12:03:01 +0000, Ferruh Yigit
> <ferruh.yigit@intel.com> wrote:
>> On 1/12/2017 1:04 PM, Olivier Matz wrote:
>>> Fix typo when checking that no Vlan offload flags are passed at port
>>> initialization.
>>>
>>> By the way, also fix a typo in the log.
>>>
>>> Fixes: d4a27a3b092a ("nfp: add basic features")
>>>
>>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>>> ---

<...>

> 
> 
> I'll submit another patch with ETH_VLAN_EXTEND_OFFLOAD.

If this will be the only change, I can update it if you want:

-   (mask & ETH_VLAN_FILTER_OFFLOAD))
-       RTE_LOG(INFO, PMD, "Not support for ETH_VLAN_FILTER_OFFLOAD or"
-                       " ETH_VLAN_FILTER_EXTEND");
+   (mask & ETH_VLAN_EXTEND_OFFLOAD))
+       RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD or"
+                       " ETH_VLAN_EXTEND_OFFLOAD");

> Thanks Ferruh.
> 
> Olivier
>