From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C746A034C; Thu, 20 Jan 2022 15:16:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA592426F8; Thu, 20 Jan 2022 15:16:55 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 4D27240042 for ; Thu, 20 Jan 2022 15:16:54 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 7D2C03200E79; Thu, 20 Jan 2022 09:16:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 20 Jan 2022 09:16:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=TPcMvi56v8EMp7 ofD/rEC6yT799RSal2h/OD/8kmB5c=; b=fRHWPWCMKNIW0ku3PpX6Auerf1iwOS /8zfqYmKAjOht9eDZfVRReYDfRdZ2LxwwjsJ/bn14C6ctSKC74d+uKq6VgPdjPIg gASh5NYsjZHIkUA1ngoku/JVyiibiHVYd8YVK7OCnFv+Nx1+Nt+SvNphUYIajIL9 uFUG4OMDZ/yZ7VpEvGJ5yrGbGmY7hOr5YKwvcOIQx97o/U6t3Q4HaGnLgxVa66oa xxk4geTdEFOxlDg9R2oPvu62owwTjGjsMYYmanfHa8uOzpWZUhNxjUkz5EAlCRPN MgPXIN8WzmrR/HYsiAZoxVA2TO1WJGiMgO3ERg0FRugsgkRjT3qBEr7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=TPcMvi56v8EMp7ofD/rEC6yT799RSal2h/OD/8kmB 5c=; b=oGUuu1ioedwJ9m8uUEeyURlG8hLm54yAGXh3lfhXOIhufEQPS13jCH9O+ EIVvpVeaIaq00uhPGxoF1A0QBo4aFpA6zcySjQslNlNyBmmZ30F6dYiEWCwMHMsf SK5SqQ9JgAG0ppvL1XtP0ukoqdCFZMUsrfgYFSRkixEvuH01ipIhJpr0JTyVajoU rD9fJwCn5l5LjOMQG+nPegU7C/A+KeGD0UTK1+y1ZfeNlLcsRWenca5Iekp87m8n RpqaxlTLqstkP50ray1+90xo8X2eZ8stAXvYFzQC6Yz/yh19rwXwrRo6vYNPNmza b+/yqE6WlLjg9q4KwLuohGZC6H9Ug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekgdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepudeggfdvfeduffdtfeegle fghfeukefgfffhueejtdetuedtjeeuieeivdffgeehnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh gvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Jan 2022 09:16:49 -0500 (EST) From: Thomas Monjalon To: Michael Barker Cc: dev@dpdk.org, Ray Kinsella Subject: Re: [PATCH v2] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if. Date: Thu, 20 Jan 2022 15:16:47 +0100 Message-ID: <10018405.DAOxP5AVGn@thomas> In-Reply-To: <20220117232318.219749-1-mikeb01@gmail.com> References: <20220117231404.219496-1-mikeb01@gmail.com> <20220117232318.219749-1-mikeb01@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/01/2022 00:23, Michael Barker: > When using clang with -Wall the use of diagnose_if kicks up a warning, Please could you copy the warning in the commit log? > requiring all dpdk includes to be wrapped with the pragma. This change > isolates the ignore just the appropriate location and makes it easier > for users to apply -Wall,-Werror Please could you explain how it is related to -Wgcc-compat? [...] > #define __rte_internal \ > +_Pragma("GCC diagnostic push") \ > +_Pragma("GCC diagnostic ignored \"-Wgcc-compat\"") \ > __attribute__((diagnose_if(1, "Symbol is not public ABI", "error"), \ > -section(".text.internal"))) > +section(".text.internal"))) \ > +_Pragma("GCC diagnostic pop")