From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 869F37CFC for ; Fri, 25 Aug 2017 10:55:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 29AEF2139A; Fri, 25 Aug 2017 04:55:47 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 25 Aug 2017 04:55:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Kf6vWBQAdG0tmhK YklxWE0SLJL4YXgOQn+AKmlY/H+k=; b=MTwPXjJnUS9NTOR3URNFiFV9T5OZqS9 1hscB2+TEzU90V8TZslqSfNnpnD5zs5eRs7GA5E0dSAYOAfjQZfeFk9SFlfj8o/y oqpMhg1uWk8LZcJYzrwzxeO44rISTcCwWV+Y0p9AGxzQauK13HBdlxNfKMaL/3Uv hzb36QmgOgGU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=Kf6vWBQAdG0tmhKYklxWE0SLJL4YXgOQn+AKmlY/H+k=; b=nfJNsvvt 9CugaKTNOWlY4+4sgQrXOfEzjiY+rWWLUGGo2HM0VaTY5rfRe6633M3naAtoOaeY MdYPQ/O9zhowju/Jo2WmzkPQMapykXAHaM2ouhywD8kWpp1s6PqhN2CaEpiPr6fz 5/W1smoOq+k+/+QYrtihQ7iX94pVnWcFzqhbPMVvBRZqHs9C91oHD7MFr1NO6gYG Jji4wOOqgzz1B8TI0udDBIWq/KqkhLFnVcf1ObpNB1ebupdfezq2+kznu0Goru3v gwhn7CYZ7nmhrglXoPi3ziyfzf6I6JgYGoRCRiCm+IMgZXsTUo45lVba01recI2I lQEeRY+ILeeawA== X-ME-Sender: X-Sasl-enc: p3cFXShAGby8eaOiqAXmb2lCUd32wgsBu2W+8F9ZUszA 1503651346 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D263D7E1B4; Fri, 25 Aug 2017 04:55:46 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Raslan Darawsheh , jingjing.wu@intel.com, salehals@mellanox.com Date: Fri, 25 Aug 2017 10:55:45 +0200 Message-ID: <100246790.r6DC0kRVUk@xps> In-Reply-To: <20170825075331.GB8124@bidouze.vm.6wind.com> References: <1503499024-12480-1-git-send-email-rasland@mellanox.com> <2302304.eNG2ySBljJ@xps> <20170825075331.GB8124@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 08:55:47 -0000 25/08/2017 09:53, Ga=EBtan Rivet: > On Wed, Aug 23, 2017 at 06:18:34PM +0200, Thomas Monjalon wrote: > > 23/08/2017 17:09, Ga=EBtan Rivet: > > > Hello Raslan, > > >=20 > > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > > > > Added hotplug in testpmd, to be able to test hotplug function > > > > in the PMD's. > > > >=20 > > > > Signed-off-by: Raslan Darawsheh > > [...] > > > > --- a/app/test-pmd/cmdline.c > > > > +++ b/app/test-pmd/cmdline.c > > > > @@ -716,6 +716,9 @@ static void cmd_help_long_parsed(void *parsed_r= esult, > > > > "port config (port_id|all) l2-tunnel E-tag" > > > > " (enable|disable)\n" > > > > " Enable/disable the E-tag support.\n\n" > > > > + > > > > + " device remove (device)\n" > > > > + " Remove a device" > > >=20 > > > I think it should still be a part of the "port" command set (port > > > attach|detach|stop|close, etc). > >=20 > > I tend to disagree. > > As far as I know, we use port for ethdev or cryptodev. > > Here we want to deal with EAL rte_device. > >=20 >=20 > I see, that makes sense. > I will redo the review with that in mind. One option is to reword the command to show that it removes the device associated to the specified port.