From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Alejandro Lucero <alejandro.lucero@netronome.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] nfp: copy pci info from pci to ethdev
Date: Thu, 31 Mar 2016 15:27:44 +0200 [thread overview]
Message-ID: <10027789.FxOxZF7KpY@xps13> (raw)
In-Reply-To: <CAD+H991pJ6GZP93U2B7+vOgJH7NPaqqWBVvsC-54FqCe4kGjiQ@mail.gmail.com>
2016-03-29 08:16, Alejandro Lucero:
> Hi guys,
>
> Sorry for the delay but I was on a Easter break.
>
> That patch is OK for me. In fact, I had one patch ready for upstreaming
> with this change needed for supporting hotplug. I was waiting for some
> feedback from one internal project needing this hotplug functionality
> before submitting.
[...]
> > On Wed, Mar 23, 2016 at 08:51:36AM -0700, Stephen Hemminger wrote:
> > > The NFP driver (unlike other PCI devices) was not copying the pci info
> > > from the pci_dev to the eth_dev. This would make the driver_name be
> > > null (and other unset fields) when application uses dev_info_get.
> > >
> > > This was found by code review; do not have the hardware.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks
prev parent reply other threads:[~2016-03-31 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 15:51 Stephen Hemminger
2016-03-25 12:31 ` Bruce Richardson
2016-03-29 7:16 ` Alejandro Lucero
2016-03-31 13:27 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10027789.FxOxZF7KpY@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=alejandro.lucero@netronome.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).