From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 84DB78D89 for ; Thu, 31 Mar 2016 15:29:38 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id f198so1248461wme.0 for ; Thu, 31 Mar 2016 06:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=0uSXAyAOGmXWhMph/PNkt88tR6Azk0uvwbleqpwhF4A=; b=GZtznb3/JPJCskuhhkobJwwXXu7KtLUcKWJt2xybChPHriX1XJWEn751I3NNqg9vre eHj7Z92i6zlTESQ0wQaevd8u4NT2HvslyyzYeD6WZEi6bk4zsfNL16zAPZ3nknXN/RgV B8Z33WXXcmz1usfIudOUv9YoqsAgwIHc8D0gcAi19BOwTR4diwo73l0K2NbIHDf1VHYs NnoUyuuZAghgWzwpFD/zri/c2awvH/Cafruq+eMuav/s1IYt53Gu95ylKwqEVlq/8c1L 1EqPhHCWGyGvVZb7gs1jwV751z/yqumQa9qj8RegFiGS0tJXoHWrYjmbZaaYaI9e6YfA o9hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=0uSXAyAOGmXWhMph/PNkt88tR6Azk0uvwbleqpwhF4A=; b=EcjB20/x4o3LxUjVIVrUKbClcm0JSHS2JKAhT/WwWK78pHZz+QAOMJy3JVigo6BvcN jP/THhTstEDDwtDJCgIK6kIKnQbdcV6T6oUyCw0ybDtdpRuaLu1xCulJsATw0GIEThA4 wQpAl9JDzKqSHBLnjHwZmTbC7uM/VCbRp1MolgHik0rQR7XA6LmK0d2hPy37+4bMyy7F YCnNZdhVIqduABtqZPl3n3POlQ4sWfqdKld0DGumRt8Mu6+6/ZIeLbLGss4MxmxqWRZs y5GdART/zY8rCR0tHeiwKNHYf1CPpYXj2fOrZLASlG+WeIq3ld8ncv3t47lxXorz/7zJ 8hbA== X-Gm-Message-State: AD7BkJLNp7z6kozNOnhbBos5+X8fv9n9B+LmJoyGHohE4RDUrsD/udBznCZStqJyHVqCFpVh X-Received: by 10.194.61.19 with SMTP id l19mr15381142wjr.4.1459430978395; Thu, 31 Mar 2016 06:29:38 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id ll9sm9085105wjc.29.2016.03.31.06.29.37 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Mar 2016 06:29:37 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Alejandro Lucero , Bruce Richardson Date: Thu, 31 Mar 2016 15:27:44 +0200 Message-ID: <10027789.FxOxZF7KpY@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1458748296-15017-1-git-send-email-stephen@networkplumber.org> <20160325123117.GD18028@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] nfp: copy pci info from pci to ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 13:29:38 -0000 2016-03-29 08:16, Alejandro Lucero: > Hi guys, > > Sorry for the delay but I was on a Easter break. > > That patch is OK for me. In fact, I had one patch ready for upstreaming > with this change needed for supporting hotplug. I was waiting for some > feedback from one internal project needing this hotplug functionality > before submitting. [...] > > On Wed, Mar 23, 2016 at 08:51:36AM -0700, Stephen Hemminger wrote: > > > The NFP driver (unlike other PCI devices) was not copying the pci info > > > from the pci_dev to the eth_dev. This would make the driver_name be > > > null (and other unset fields) when application uses dev_info_get. > > > > > > This was found by code review; do not have the hardware. > > > > > > Signed-off-by: Stephen Hemminger Applied, thanks