From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2AB561B38A for ; Fri, 22 Dec 2017 15:17:47 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A18B420C10; Fri, 22 Dec 2017 09:17:46 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 22 Dec 2017 09:17:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=FDG2lrnUDFimNUx+Whi0kKVwhE rbzgRJi5YC4zTL/8I=; b=Ney9zUmSfYhYV+muBjIN807V7e6oIqQyVY4VZpubHr fVD3oYfg9y37p//0ndsCDG2YR9mvDTLedxGN69m5Kz4XWD4/7TfvbkaXPO5a2Ets MLxVPrKg99hDYbU8nO9q7XP/I88/r5Xf/worct3eIA8i+ro9du6RQRjLR1m5DRCz M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=FDG2lr nUDFimNUx+Whi0kKVwhErbzgRJi5YC4zTL/8I=; b=C+aKFz25CNwBr29HquZvuy cvUcXf2N+D1BkwvaTmu0OpHLrtpJfI4uIy8J39CI0FU16unKpnr5aipjWsPMyB82 1ofGEuT6VGHm8rhds1plDVfl/JNUI0CCMw9ZkOxv3fcn9MQ9Zt/NiabXJTxgAeTY Ypev7Z4fCYayylZhMpT2J65mk4Bi3Xb803iwPe7ippt4NkhL7qYZZ6iS9437+Ts2 ZMR9OBYe+MM7RB0c9+ARFlms49vfhx+vDuhHHCQ/gewNDJECWYvB2i0262k31VsA MifaA4joOmIDV7CAp675oEq3vZsJZX8Jc0kHhpByuAbC5yMArNDu9Kx6fS+DSmlA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 42D7124800; Fri, 22 Dec 2017 09:17:46 -0500 (EST) From: Thomas Monjalon To: "Wiles, Keith" Cc: Hemant Agrawal , dev@dpdk.org, "Yigit, Ferruh" Date: Fri, 22 Dec 2017 15:17:45 +0100 Message-ID: <10030168.6hk24mNXSe@xps> In-Reply-To: References: <1513922231-15554-1-git-send-email-hemant.agrawal@nxp.com> <4919393.KhUSbVM1LT@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] Create kern folder for Linux kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 14:17:47 -0000 22/12/2017 14:59, Wiles, Keith: > > > On Dec 22, 2017, at 5:38 AM, Thomas Monjalon wrote: > > > > 22/12/2017 11:04, Hemant Agrawal: > >> On 12/22/2017 2:13 PM, Thomas Monjalon wrote: > >>> These modules are Linux modules, so they should be in the linuxapp dir. > >> > >> > >> This is a cleaner separation w.r.t userspace/kernel space code. > >> *kern* is a better placefolder for LKMs. > > > > I prefer "kernel" name. > > The name should be related to Linux in some way, like linux_kern or linux_kernel or linux_modules (this is the one I prefer) this way it make it clear which OS they are designed for. If such top-level directory is created, the BSD modules must be moved there too. That's why "kernel/" or "kernel/linux/" is appropriate. > >> Also eal is not getting overloaded. > >> > >> linuxapp is part of librte_eal. KNI is not related to EAL, but still > >> the kni kernel code is added to librte_eal under linuxapp. > > > > Yes it makes sense. > > > > More opinions/votes? > > > >>> There are also some kernel modules in the bsdapp directory. > >> > >> We can move them as well.