DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Srikanth Yalavarthi" <syalavarthi@marvell.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>,
	"David Marchand" <david.marchand@redhat.com>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"Stephen Hemminger" <stephen@networkplumber.org>,
	"Thomas Monjalon" <thomas@monjalon.net>
Cc: dev@dpdk.org, sshankarnara@marvell.com, jerinj@marvell.com
Subject: Re: [PATCH v2 1/1] devtools: update sources in build tags script
Date: Wed, 8 Nov 2023 11:44:23 +0000	[thread overview]
Message-ID: <10045259-6175-45a6-80a8-3c4949c69a4b@amd.com> (raw)
In-Reply-To: <20231108092828.17628-1-syalavarthi@marvell.com>

On 11/8/2023 9:28 AM, Srikanth Yalavarthi wrote:
> As part of deprecating kmods meson option, 'kernel/linux'
> directory is removed from the repository.
> 
> This patch removes non-existing 'kernel/linux' directory
> from linux_sources of build tags script.
> 
> Fixes: a52d472c5c94 ("build: deprecate kmods meson option")
> 

Practically [1] made below removed lines obsolete, and although above
commit actually removes the empty folder, it doesn't tell the full story
(why that folder is empty and not needed for tag creation).

I would go with [1] if there will be a new version.

[1]
Fixes: f78c100bc871 ("remove KNI")


> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
>  devtools/build-tags.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> index bf3b13ebac..e07349a47f 100755
> --- a/devtools/build-tags.sh
> +++ b/devtools/build-tags.sh
> @@ -68,7 +68,6 @@ common_sources()
>  linux_sources()
>  {
>  	find_sources "lib/eal/linux" '*.[chS]'
> -	find_sources "kernel/linux" '*.[chS]'
>  }
>  
>  bsd_sources()


      parent reply	other threads:[~2023-11-08 11:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08  4:44 [PATCH v1 " Srikanth Yalavarthi
2023-11-08  8:48 ` Ferruh Yigit
2023-11-08  9:29   ` [EXT] " Srikanth Yalavarthi
2023-11-08  9:28 ` [PATCH v2 " Srikanth Yalavarthi
2023-11-08  9:31   ` Morten Brørup
2023-11-08 11:24   ` Thomas Monjalon
2023-11-08 14:42     ` [EXT] " Srikanth Yalavarthi
2023-11-08 15:23       ` Thomas Monjalon
2023-11-28 10:57         ` Thomas Monjalon
2023-11-08 11:44   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10045259-6175-45a6-80a8-3c4949c69a4b@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mb@smartsharesystems.com \
    --cc=sshankarnara@marvell.com \
    --cc=stephen@networkplumber.org \
    --cc=syalavarthi@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).