From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79947A034F; Tue, 11 Jan 2022 13:46:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BCD2426F7; Tue, 11 Jan 2022 13:46:17 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 170CB411AE for ; Tue, 11 Jan 2022 13:46:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641905175; x=1673441175; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=BZIaMCPgyAYyRnR2A8qtI+MX0GvlVHRjCUTz0wYkFb0=; b=XN8gOvyiIRR1inc9QD4XkdFDNkIqkkXAcgxa/TBpCoNDg8vTXrqvWfO4 PQoUCzp1EiWpVaUZ7pDIyhXcRXH6goSHZVJ8e7EFXKZCyJFFMplmJQFRB 8iaiBDOjUwZjl+eshXtyfmptpbNQm+aRTofbDcHJ4Jh1GmDJfaETGV2UP A5zQnmmD0uHY7hpP+rjeQnjdyJc6ppElcLLOEk+9r/ejmLj8Ne88DPV5m 7FP+MuXPzuoBGd9//8Q8PvhUlOLH+/5dSr4KEKwf5AG1HK2VYo+upYftS CWykb+fkdVJQmHHmehHP5FZ+ja7FdZcp71XfH7Mpj/IJE6gAb02OUuuDj Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10223"; a="243430289" X-IronPort-AV: E=Sophos;i="5.88,279,1635231600"; d="scan'208";a="243430289" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2022 04:46:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,279,1635231600"; d="scan'208";a="515081907" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 11 Jan 2022 04:46:13 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 11 Jan 2022 04:46:13 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 11 Jan 2022 04:46:12 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 11 Jan 2022 04:46:12 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 11 Jan 2022 04:46:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CB6ydHUgfo5nmUJE4DTsIp1YeB5OVK2GigTV7g7LnfQdlYMHD7F+6z7b6H+3WktSQ6ri3AHGAZG8lX2oAHYimGTL1JN6YxwXIFr/KNOIoGICNKR4B79IjbKEvQCFxb4x1CB3zKKsDHoeaJfmTAJV1TGk4ry34fhn04V8XIYUsS4rjSX34pvpDsPFhQ5f1GOrTVdPCifreV2SNlygq4LLnUnmogt4fyyw1U3abeqjB1FX1NFi2wS968dyTl+FIp4wRX3ci3IukiskbnGGSNttuTweu6mvOmO+vDtmSoKv8Tqk2NDftwbHBHKmGpMBhyWt02rhZybYdrOZlbkC0KNYog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A2tefm5S7fj4PomFBVR7iuBk8KNXvd2S6Q76TrNDEj4=; b=R0FChp7dI5qbRrpB5Mt6poI/HLtcW07vyB4vI+jBnIOoDg2d1ov1omSXrp4FTRtQKrpKX7nJelxBGoLGoSqnkUmY+8vr9SCFqUQCRg02QZcz8QxMSdego0bLmsvwFGb2gm0ffHCot271ZHNe/JWxNI7yTYa+FspT1U4tqsS79WATf2jF1kufPzXwFyu1qDFhDRjiMw7Ne34ss1WIXwwh/oYN8VxrIDqm874Tcx+TWmFedREDEzcR8nZThHNy7jVUqSjxExeeD+gB1XnIXiMmh226B5v9Wfeci3FVPHfhQLHWRnHiYDaueqqMjcTer16qZPQwvCt5ouV5VTihW/9suQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5830.namprd11.prod.outlook.com (2603:10b6:510:129::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Tue, 11 Jan 2022 12:46:11 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4867.012; Tue, 11 Jan 2022 12:46:11 +0000 Message-ID: <1014f09c-762b-079f-c28b-2d3c57415111@intel.com> Date: Tue, 11 Jan 2022 12:46:05 +0000 Content-Language: en-US To: Rakesh Kudurumalla , Nithin Dabilpuram , Kiran Kumar K , "Sunil Kumar Kori" , Satha Rao CC: References: <20211130064147.1023321-1-rkudurumalla@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH 1/2] net/cnxk: update meter bpf ID in rq X-User: ferruhy In-Reply-To: <20211130064147.1023321-1-rkudurumalla@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0434.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::7) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6971be0f-4fe4-4ccf-e42c-08d9d50058a4 X-MS-TrafficTypeDiagnostic: PH0PR11MB5830:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N/hwjY1Prn3EAk0ewzil+v0WszauoI6X5b5b/y2NQ2GJRKls2hBr0RoWCqUkC15N1U5RUm11Yq0EtuJ6HSRHIvbdgFC2eIp1CwAyUboPusdoOjId+d+Sw9oFuIEpkw6EfYH3Cdez0g89VsTMUSJiiQexNbFLoTFD/1nm7njIdm2t8C4RX+V4eCWCmjzQNSBa2kq0sX8n7ZsdG9W0XIzF9Q7qlz5DVBK7VPtFbswrVPCl7//WpwzGwdh1bfNu06Q0Q4eV1DcC8pAEu/AbD10DPRaN8vezuba941Hv4YseG7V1CZ+YMMKOES8Wpc8051rvA2NQYYInbHM93lh9mYf/brX8YBhdgjHaUiYHRmKmJpGCtmdxqEGk1J/iUBoTqRpcem9UAd9jxzvhaEPHBcrE+ugBYrA7eRHajD5cqKCv61adVByHn4hf4n9yRbO6D85Tfd4NPFMnUSSWJFxZ7ixyeWaXC7tr0MGKUCAFhZqsNWKaR81KQ2LYfgWDIYXs/h17KL5IHhMUgy9b8NDvw+6Gbc+g+jETuW0Pyvy/qBnpIcbBQU+HRCUoXxJ1sfa2KZAgMp7uCX+5kRCoqLvoaSSRO1VrBZNT7XcVXoM3EJ+Lghx9xAAVrLlY77rMmUo4fTjbHjkNklgFUD8WHf/CmiW/7BoxIt1gscxPe8Zn98P5IZTH5Oj5T17suRLZ5GuFnWLwfm0SvZJhZlLP3Dx6nOhSHQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(110136005)(6486002)(5660300002)(508600001)(66476007)(66556008)(316002)(2616005)(36756003)(4326008)(86362001)(15650500001)(38100700002)(53546011)(6666004)(31696002)(8676002)(8936002)(26005)(83380400001)(44832011)(31686004)(66946007)(82960400001)(6512007)(6506007)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUZneEpLcEFmUlo4RlI3QklhVHZiUzRXVnVRa0Y2U2lkRmZBNWdKKzBFalhp?= =?utf-8?B?RjFqTUgyTWtKYUtITVErcHpEaThJejVMNTVwZnh3bWdRZ3diQjQwc1RsTFo2?= =?utf-8?B?Sm1MejFSaTh2SEFQNmVVU0lDK0hXQ05TVmtsZWg4ejlzWThBZWlDNzE5Z2R0?= =?utf-8?B?blBiY2NSTHZsZ0lSc214aTM5RnNQNkxlN3l6N2pLSEJaTkFzQktwczlxSzFM?= =?utf-8?B?dG5XZEFmdmVYVTlZQ05oZDNCVUx5WS82YTE5ZVVMaEpzWVd4eFJqMVQvQ3JY?= =?utf-8?B?TUFSZ0pyZ2VxcUlZaTMxRDRaQzJCVDg2UDhyWDIvNUZUa3pHRFczZ3lDMGhW?= =?utf-8?B?TGkrZ3IwNzBvcVQwQ1N0b01tTndla2JQMUZVdTAyUmwyWlpqdTlDb2xBN29X?= =?utf-8?B?eSs1KzVlNHBwcnk0TlpoVjZKYjQ4ck1lRFY0OENCa01iRjR4M0EvcjVLUW1C?= =?utf-8?B?U0d3VUVveW1PUjdoanhmWmIwalluYWt2UldON2R3YnBWRytrV2Nsc3RhRm9T?= =?utf-8?B?dlJqczZ5M2cyb0dKNm5wRitpR0hrWExndi9VK3NYK0ZqSjJaTHY2bDQzUUpW?= =?utf-8?B?OWZyZGdhVmVxSVlFd3VJYVlLSDBFblhPRFhtQnMrYStXQVZybzRXOUhzbXl6?= =?utf-8?B?eXkzcXFuSEViOS9NSGRUVmRWRFB1ZWpFTkNwdTVuVmwzc05jbXAzQmVPWHB6?= =?utf-8?B?QjhMYjZhYmZORlg4cXMyTzVTRnY3VWdsL0pEN2MxM1FPMUFnbkxoZ3JsT2Zv?= =?utf-8?B?djYvMGJqWFp3aUdGZFE4T3RLZXpmZDlLSTVLcGg2RzZkQnNvZTB6N3RpZ1VP?= =?utf-8?B?M24vbGlVeHUvK3lsd05OcFBHM2RSbXhSYW9JVnF0YzVKS2JpdUg1ejQwcyto?= =?utf-8?B?ZjVIR2Y5TGdCOGRHUWh6aEJOanpqcWRaSStCYndwN1pyYUxqcndCVzhJejR2?= =?utf-8?B?VjRKTGxxeCthUjNLOXg5cEhhYUIwYnNLclMxbEZCcU03UlRJN1JWOVFZTVJk?= =?utf-8?B?Y0ZIK0dmSHZvVmNzRmRudzRZdnRNUjQ4UFBwYmMvc1lnaE5xSmo2R1lXbmNV?= =?utf-8?B?YWc3ZFJXUndPOFUxUE5RaGRsOElHbTRIcDBFY0c2NXJ5WUJuRmtWdDNyOE1T?= =?utf-8?B?dG1JV1lnT2t0ei9Qc2hzRElZNFErQTJibHBXb2MwSENrNEQxbVE2N2VpN2Jk?= =?utf-8?B?bFFxZkFObFVmRExUWWJheXJ1a2h3WitlN0hEQ3daMnI3Qm9qVHNCVHdERG1n?= =?utf-8?B?NUVSRFcwUDg4WHE2a3FML0ZyQjlnZ2dleDV0WTJMMnhBNkZSYmp1WS9jdGpD?= =?utf-8?B?R0JoQkZ0NmR3K2Z2TDluazdFOU5hbGZzVDhvR3MxR1I3aHJUVkhvVWdxTTJD?= =?utf-8?B?SFJYUzJ5b3paSERaSEZ1UmhzSVBBZnhIK0U3TmFsVjRMVVp0bERJcUNxand2?= =?utf-8?B?Sy80RzZCWFA2MTV3eFBtYTVBb1BoV1FUdUFJZlVYVnMrWXhXUWQrM2s3aUNI?= =?utf-8?B?dVN6aVhPdGx4VEV3c2tGenc3R2diOFNMTEVyajVaRk42cTl5MGlWM1BxcGQx?= =?utf-8?B?bkh5d0hYNzJHclBHb2xET3YzanJ3S0NsMkpuNnZaY3NVaE56Z0ZBdEdFN01O?= =?utf-8?B?bTYwQ0syZEx5bGFFY1VXQ1ZBM080NHRGR2xuRHNGaEdzSmxOVm1BdXZ5L3BI?= =?utf-8?B?OEJHazNwWVlObmQxMGZ2RDRla0dkaHhLdnVUelcvZm5nRTRxeTFmcW5pWGVu?= =?utf-8?B?Zi9pS0ZEbmFCVUlEeXFEZmpUcEg3WHVzRy8vTmFTT09vdXVNdjRNdzJsUTJ1?= =?utf-8?B?anRUdlI3RzVzNmFPQVRxOWJyaGFRVk84K1ZCT09qL2ZDbE5kOFBjendLQ3ht?= =?utf-8?B?aDlQbUxESFMvYTMzT3hOR1k3Q3dKMmJuL3NqclhuV0U4VTFCMTZYWXVadVhT?= =?utf-8?B?UlZXbzZJQkpsMjRIL1pBWUIrMDcvd29yckMzZWwyb090VERXTVlnd2VzWVpF?= =?utf-8?B?Um0ySVR0cWtYamR1NWVZbFVIbUhjZVdBUitkdkdwNDY1QU1TS0NPNHRvbUxR?= =?utf-8?B?NkVBSVh2UG8zSFgyV0xnRWdWZzlVSWFBVURBanhTcDdneTBoazFqOERHanZ1?= =?utf-8?B?Um11K1ZBQVovTUJpckdYZG9ONklyS0E2TGlUckVJb3Rxa29QOC9JYkVrZng1?= =?utf-8?Q?sAt3JjIlo3V8DDSmMQ0vVUc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6971be0f-4fe4-4ccf-e42c-08d9d50058a4 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 12:46:11.5752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A44+HtpxI6heQB4d2t9GEl3EmwFmm6OxWvPPykGK0dEBzb9CTAjc42LCyJWZMmRNe7bS/7nVDEjmUhDWPTWMXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5830 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/30/2021 6:41 AM, Rakesh Kudurumalla wrote: > Patch updates configured meter bpf is in rq context > during meter creation RQ is receive queue, right? Can you please use the long version for clarification? > > Signed-off-by: Rakesh Kudurumalla > --- > drivers/net/cnxk/cn10k_rte_flow.c | 9 ++++----- > drivers/net/cnxk/cnxk_ethdev_mtr.c | 25 ++++++++++++++++++------- > 2 files changed, 22 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/cnxk/cn10k_rte_flow.c b/drivers/net/cnxk/cn10k_rte_flow.c > index b830abe63e..402bb1c72f 100644 > --- a/drivers/net/cnxk/cn10k_rte_flow.c > +++ b/drivers/net/cnxk/cn10k_rte_flow.c > @@ -36,20 +36,20 @@ cn10k_mtr_configure(struct rte_eth_dev *eth_dev, > for (i = 0; actions[i].type != RTE_FLOW_ACTION_TYPE_END; i++) { > if (actions[i].type == RTE_FLOW_ACTION_TYPE_METER) { > mtr_conf = (const struct rte_flow_action_meter > - *)(actions->conf); > + *)(actions[i].conf); > mtr_id = mtr_conf->mtr_id; > is_mtr_act = true; > } > if (actions[i].type == RTE_FLOW_ACTION_TYPE_QUEUE) { > q_conf = (const struct rte_flow_action_queue > - *)(actions->conf); > + *)(actions[i].conf); > if (is_mtr_act) > nix_mtr_rq_update(eth_dev, mtr_id, 1, > &q_conf->index); > } > if (actions[i].type == RTE_FLOW_ACTION_TYPE_RSS) { > rss_conf = (const struct rte_flow_action_rss > - *)(actions->conf); > + *)(actions[i].conf); > if (is_mtr_act) > nix_mtr_rq_update(eth_dev, mtr_id, > rss_conf->queue_num, > @@ -98,7 +98,7 @@ cn10k_rss_action_validate(struct rte_eth_dev *eth_dev, > return -EINVAL; > } > > - if (eth_dev->data->dev_conf.rxmode.mq_mode != RTE_ETH_MQ_RX_RSS) { > + if (eth_dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) { This change seems unintended. Please keep the original value. <...> > if (!capa) > return -rte_mtr_error_set(error, EINVAL, > - RTE_MTR_ERROR_TYPE_MTR_PARAMS, NULL, > - "NULL input parameter"); > + RTE_MTR_ERROR_TYPE_MTR_PARAMS, NULL, > + "NULL input parameter"); > Previous indentation looks more consistent with DPDK coding guide.