* [dpdk-dev] [PATCH] devtools: disable coloring of git-log output
@ 2018-10-23 8:52 Ali Alnubani
2018-11-18 23:01 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Ali Alnubani @ 2018-10-23 8:52 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon
Colored git-log outputs will have escape characters
appended to hashes, causing check-git-log.sh to fail
with `error: malformed object name ?[33m<hash>?[m` when doing
`git tag -l --contains <colored_hash>`.
Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
---
devtools/git-log-fixes.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
index e37ee2260..464b0a41a 100755
--- a/devtools/git-log-fixes.sh
+++ b/devtools/git-log-fixes.sh
@@ -94,7 +94,7 @@ stable_tag () # <hash>
fi
}
-git log --oneline --reverse $range |
+git log --no-color --oneline --reverse $range |
while read id headline ; do
origins=$(origin_filter $id)
stable=$(stable_tag $id)
--
2.19.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: disable coloring of git-log output
2018-10-23 8:52 [dpdk-dev] [PATCH] devtools: disable coloring of git-log output Ali Alnubani
@ 2018-11-18 23:01 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-11-18 23:01 UTC (permalink / raw)
To: Ali Alnubani; +Cc: dev
23/10/2018 10:52, Ali Alnubani:
> Colored git-log outputs will have escape characters
> appended to hashes, causing check-git-log.sh to fail
> with `error: malformed object name ?[33m<hash>?[m` when doing
> `git tag -l --contains <colored_hash>`.
I guess it is due to a config specifying to color "always".
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> -git log --oneline --reverse $range |
> +git log --no-color --oneline --reverse $range |
There are a lot more "git log" calls in this script.
I wonder whether we should add this option everywhere.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-18 23:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23 8:52 [dpdk-dev] [PATCH] devtools: disable coloring of git-log output Ali Alnubani
2018-11-18 23:01 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).