From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id DD0D32B83
 for <dev@dpdk.org>; Mon, 19 Nov 2018 00:01:46 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 6D2E921F17;
 Sun, 18 Nov 2018 18:01:46 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sun, 18 Nov 2018 18:01:46 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=ALRV5BvdamHYMzVay0ce6b+4Dum1bO/SO2izxMaGh00=; b=j7Tt3YoPeEmw
 ipOxAzt2cPK2pZdTizedECpPLBBpjw09u3vET6FdmU2Wbrn2tulJqr7UwjJcPj79
 E145p5Al+al9dMhPNLzsKIfyfk5EH8IwayQMGNNIoZ2SBF21IJ4dXXTOVaZr33ce
 qc5dw94Cipc9gvc20atZEEbzvcuUS4A=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=ALRV5BvdamHYMzVay0ce6b+4Dum1bO/SO2izxMaGh
 00=; b=RkfQ6SysKhDNNRzy/2ZO/LdMIVm9DVlSiCyKhT4H/uoxGyzYFJruVwuZM
 OkUk3voSfa2FeLcjg8A+gLMJcaS9alW0CE71t1yrg4oVNUSl6VmMKYnY5VmQIdol
 T2UXpQoLJRaDI9gL6MSQ6Z/sI7XhcZ6vWCmmu7/Q8YI8pl3+hjwaC7eQ24vIc89u
 CEdH9q+AIdKjSAVcjoBn17nmKt1y2iBgkoGbrhvMEta2/kiBLsuUhLuacVMb14kO
 f6ZZv2vPmGLIqTO8tdPCXubM057UqqTMHMsnqn5yBQEHGox154B/6jAf/gqv5kRZ
 Fzl5ZKcGyRPj7SYHWOyDo7gkKW0TQ==
X-ME-Sender: <xms:We_xW1datg5Q0aSqCTdZG2CWV2VpHYcc1sNbH7KiO32TfT-NVMd1rg>
X-ME-Proxy: <xmx:We_xW1qSKZIUMvmZdetnbye6OfVEgEtj37nf3IrwzYIGWw-tZI-6Dw>
 <xmx:We_xW990kR-SQ1wobQ3CkS1WSJDD7yRZOnzz_RzlEhdcmp0oFoKC1w>
 <xmx:We_xW4OSDzFhbB83Hi8VFwrne4Xy7W1P6PUIbY9APU-lz2ft6hgT-w>
 <xmx:We_xW-O0A-uPYdMuXlYaw8XAskph3lH9nX8Cp8hCj_sKJojCrHVphA>
 <xmx:We_xW7eLvD41QD8lttXXqKmKKmFAAB5DtZqRpuM8u9M0Pq0iiOd6Pw>
 <xmx:Wu_xW8vlYoFC-JjCVft1EIdB3mAr7aJHYSQReT6fi7mYDYNJHCXdSw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 82F34E482E;
 Sun, 18 Nov 2018 18:01:45 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: dev@dpdk.org
Date: Mon, 19 Nov 2018 00:01:44 +0100
Message-ID: <10150003.XpIquesuWC@xps>
In-Reply-To: <20181023085217.18548-1-alialnu@mellanox.com>
References: <20181023085217.18548-1-alialnu@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] devtools: disable coloring of git-log output
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Nov 2018 23:01:47 -0000

23/10/2018 10:52, Ali Alnubani:
> Colored git-log outputs will have escape characters
> appended to hashes, causing check-git-log.sh to fail
> with `error: malformed object name ?[33m<hash>?[m` when doing
> `git tag -l --contains <colored_hash>`.

I guess it is due to a config specifying to color "always".

> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> ---
> --- a/devtools/git-log-fixes.sh
> +++ b/devtools/git-log-fixes.sh
> -git log --oneline --reverse $range |
> +git log --no-color --oneline --reverse $range |

There are a lot more "git log" calls in this script.
I wonder whether we should add this option everywhere.