From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D421A0C46; Fri, 23 Jul 2021 15:19:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFE524014D; Fri, 23 Jul 2021 15:19:25 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 96BB840040 for ; Fri, 23 Jul 2021 15:19:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 412B65C00E6; Fri, 23 Jul 2021 09:19:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 23 Jul 2021 09:19:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= k7EQzVKn+8d9GYto3S5DeNWJ6Gfk00tFL4hgoX+zCo4=; b=A8xu5zEQmgkNlvh+ 516AqWUG5SgkaFI9aF22wnzrTZDMqpQ9os09voJ+NYlQL6ixWBTEG74dpcFhQqXv lwGR/WYF4ux41UzXebxTOGlA9XabTDD23MqV3amFrJD6G5zMW7MLqMhD4vDCtmhw RuRPk9FDbTd+nsFDheIxW/7cMyCsfsKZIj9cGqXYxM10nBv65AITQ3G54hnXIWgu 9UesPNf19+CjA4lX8QE3Z+8cVUMwNwO0/LWDeIVVaZjTnaRhpVPbJjXSe8iAlYz8 5MobCqqoJuZ7yTgnW41pnCZ9CdvIenHh7hn2ma/pSLQJ92xdMOiV6xnM47+ylM3X NnYDyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=k7EQzVKn+8d9GYto3S5DeNWJ6Gfk00tFL4hgoX+zC o4=; b=Gyt6xwthCGE9h/h+NEf2DnNHeSrNO8ethNwuA2gp5Ix5/HELvXxU3fbtM S2ArhG3QNjht8L71uNiXCYlBz1ingzJvZPotgF16THSy0zfiv+LDzqItgJaLWqbV QsuVjEPiEsZH3jgI53WcJYx4qOsa7YXCns7tI+B3lw1ysxKNQF0zqeu6ruF9C59P 9DbAIB+UP5n5qDzaxxriNlTjz14grnS17szMYKnRkM/KPIiN/UY7oa+mt5HeyEUA z6LJ5YZqdzqxJoXYHN3AeBAA/Edfbx/ayC05zboCJSxlbl497QnUgzq5t5gKLuHU WkU3GWcP5gTn/yrEwQSfss5uVgsOw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeekgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Jul 2021 09:19:21 -0400 (EDT) From: Thomas Monjalon To: =?utf-8?B?TWljaGHFgg==?= Krawczyk , Ferruh Yigit , andrew.rybchenko@oktetlabs.ru Cc: dev , "Dagan, Noam" , "Brandes, Shai" , upstream@semihalf.com, Shay Agroskin , Amit Bernstein , David Marchand Date: Fri, 23 Jul 2021 15:19:43 +0200 Message-ID: <10234991.2QsWa68MMy@thomas> In-Reply-To: <1861470.fCPsIMDXia@thomas> References: <20210714103435.3388-1-mk@semihalf.com> <1861470.fCPsIMDXia@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/07/2021 13:52, Thomas Monjalon: > 23/07/2021 11:49, Micha=C5=82 Krawczyk: > > pt., 23 lip 2021 o 11:43 Thomas Monjalon napisa= =C5=82(a): > > > 23/07/2021 11:39, Micha=C5=82 Krawczyk: > > > > pt., 23 lip 2021 o 11:22 Thomas Monjalon napi= sa=C5=82(a): > > > > > 14/07/2021 12:43, Michal Krawczyk: > > > > > > + PMD_DRV_LOG(WARNING, > > > > > > + "Setting RSS hash fields is not support= ed. Using default values: 0x%llx\n", > > > > > > + ENA_ALL_RSS_HF); > > > > > > > > > > > > > > > > checkpatch is returning this warning: > > > > > Using %l format, prefer %PRI*64 if type is [u]int64_t > > > > > > > > > > Indeed rss_hf is uint64_t. > >=20 > > Yeah, sure, casting ENA_RSS_HF to uint64_t in this log should do the > > trick - I'll fix that in the v4. >=20 > I think you should declare ENA_RSS_HF with UINT64_C() The real fix is probably to declare all ETH_RSS_* and other bits in ethdev with the right RTE_BIT* macro. Call for volunteers to fix that API in DPDK 21.11...