From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B1DE31B454 for ; Thu, 4 Oct 2018 00:05:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 54DB821DF0; Wed, 3 Oct 2018 18:05:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 03 Oct 2018 18:05:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=u9JU1aSntArX+MySQaUSzeDk4L3Qv2Tl1oDvOQLS2ZI=; b=lfQgNImdzGaE 1LeCStPp7iKnffVLq0EvYY+WyAeif/YuN/FvfWIe2PWKLNn/CzzBkoCghmnOqehC plJ3FHw3KReT6KkF+uwu08/mXYP8YvTXMEuOw7XoboAYMiXaGEdoYtcUJRY/T9XX sEQLpWIHJy+KpCz2RuKj/oaBL5IgaL0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=u9JU1aSntArX+MySQaUSzeDk4L3Qv2Tl1oDvOQLS2 ZI=; b=bV+xyIpEieXhmd/eLNgWAtN1FzZBPCrO8jGt3/mLxEld5Q5iJKRpj2TDg P4Slk7MDnFp4P2gyohBl52zvh88Tya9NxUXgLlogrQlTeQPjh+1H0OFW1bbw5kCi Zs+8Ajf8roWOogU49CCdGO8as5+xicU3pica+Niy175mVxUYRHRuuzdRvW+wNIst 69dPA0HXHyzC0mBeDgXBT7jpVKDHnEDTtxoVKYrRcLzHVyOirA/rai4NhLj9juz4 DXGDdAZ8j+TlsK6z3gwhqGko3buTgVo1HioBxggB/APztECRipIouIswnF4OesWY pGyLCr/1NGbcjlS4moofAqQMeT5vw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 01CDEE49AD; Wed, 3 Oct 2018 18:05:24 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, John McNamara , Marko Kovacevic Date: Thu, 04 Oct 2018 00:05:23 +0200 Message-ID: <102589449.7KdqRJ0jb8@xps> In-Reply-To: References: <98f283ce5bcf8973c5c08d13f4fbfe375ded6ebf.1535368896.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mem: store memory mode flags in shared config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 22:05:27 -0000 20/09/2018 17:41, Anatoly Burakov: > Currently, command-line switches for legacy mem mode or single-file > segments mode are only stored in internal config. This leads to a > situation where these flags have to always match between primary > and secondary, which is bad for usability. > > Fix this by storing these flags in the shared config as well, so > that secondary process can know if the primary was launched in > single-file segments or legacy mem mode. > > This bumps the EAL ABI, however there's an EAL deprecation notice > already in place[1] for a different feature, so that's OK. > > [1] http://patches.dpdk.org/patch/43502/ > > Signed-off-by: Anatoly Burakov > --- > > Notes: > v2: > - Added documentation on ABI break > > doc/guides/rel_notes/rel_description.rst | 5 +++++ Removed change in this file (dup of release note). > doc/guides/rel_notes/release_18_11.rst | 6 +++++- > .../common/include/rte_eal_memconfig.h | 4 ++++ > lib/librte_eal/linuxapp/eal/Makefile | 2 +- > lib/librte_eal/linuxapp/eal/eal.c | 20 +++++++++++++++++++ > lib/librte_eal/meson.build | 2 +- > 6 files changed, 36 insertions(+), 3 deletions(-) Applied (without extra note), thanks.