From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3D3EA04A4; Mon, 25 May 2020 00:02:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6354E1D596; Mon, 25 May 2020 00:02:14 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1DCB71D592; Mon, 25 May 2020 00:02:13 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 79F775C0060; Sun, 24 May 2020 18:02:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 24 May 2020 18:02:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= eM0frcV2AmJJFjlmREGcWJmZIR9KSHCemRTt9zPhqso=; b=GB3Vvx8zzzdeqMoZ ubLool8225kiBrFM+KXJgToxBv63ASVOZ996Y7Oi+JGSdyWQSN9b0RNfsF+yvpwB WXIpuPrFHZvceU85nSMv+uI06/MVs/ylaiatqa/refAfmk+YLsghPaTj/KLhWqfM NusOg/KXErWru11IUkfZTnNsWt9CcBQ08Yd5OfS4haACvBtyzeI9xMOzEkeODAvK 34VaxyMYiv4EPs/XfyaGH2dUVATc9HWqtbjj1Iod2pDjISq2ZLaKTckmFKya8hab rSXUWVT0gCdxeg7aI73HywdKRxi4W852HmcPjAS/07Uw4jkc5VESiUyPLkgNcpg3 b0wzdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=eM0frcV2AmJJFjlmREGcWJmZIR9KSHCemRTt9zPhq so=; b=lgAEk9OkhtWF1XpPS2mvotipmOdyK9RiLcVTlpRnLwXxDsoHzscVfoae2 XVnKrYZzYtlo+4GFjP+ScXKoeXVAaZJzfTCtfk5YkTRx/+fo0L2tq/jDfAj/Xmyg A/XPSM+cTYx2qrCDeQewbwY4UCk70VxdwJ2yOlgp5QsfTakTGYII+vfUq7iLBKly yIl2932tYWFoGmLm/A+HlUhTDxDkgFTH9VFA+ULhT65JYVFC+nXJdBW7gMW4yeLJ oZOJnFy/mQPOVmV78/ljtdzfvmGZontBpL4zzAewpVX4Kdg0c0kdOBMSxHetyYqH 5TUBQkUZYeY01bOIYGCtQlaeb1xGQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudduledgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 478913280067; Sun, 24 May 2020 18:02:11 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: olivier.matz@6wind.com, stable@dpdk.org, Ali Alnubani , David Marchand Date: Mon, 25 May 2020 00:02:10 +0200 Message-ID: <10261573.qCmUbjIAlI@thomas> In-Reply-To: <20191216191553.1997116-1-thomas@monjalon.net> References: <20191216162242.1898285-1-thomas@monjalon.net> <20191216191553.1997116-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] devtools: remove config backup after test build setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/12/2019 20:15, Thomas Monjalon: > The config options are updated with sed and the short in-place option. > In order to avoid creating a backup file when using sed in-place, > the argument was tentatively set as an empty suffix. > On Linux, the suffix argument is optional, without space or equal before. > On FreeBSD, the suffix argument of the in-place option is mandatory. > This argument cannot be an empty string if no space before. > > In GNU sed, the short option '-i' does not expect '=' before the suffix > argument, so it understands '=' as the file suffix. > As a consequence, a backup file named '.config=' was created > on Linux in the build directory. > > There is no common solution (without creating a function) > to skip the backup file with GNU sed and BSD sed. > It is solved by always creating a .config.tmp backup file > which is removed at the end of the configuration. > > Fixes: 4a4a20c4775b ("devtools: support FreeBSD") > Cc: olivier.matz@6wind.com > Cc: stable@dpdk.org > > Reported-by: Ali Alnubani > Signed-off-by: Thomas Monjalon > > --- > > v1: try removing = sign > v2: do not skip backup file > > --- > devtools/test-build.sh | 78 ++++++++++++++++++++++-------------------- > 1 file changed, 40 insertions(+), 38 deletions(-) This file should be removed in 20.11 when dropping make support. No need for this short-live half-fix. Marked as rejected.