From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 132F142EC3; Thu, 20 Jul 2023 06:05:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A3F640E2D; Thu, 20 Jul 2023 06:05:18 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 7931940DF5 for ; Thu, 20 Jul 2023 06:05:17 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 10C513202373; Thu, 20 Jul 2023 00:05:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 20 Jul 2023 00:05:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1689825915; x=1689912315; bh=IV1CGEnNVNlKakMOVthPCM7/pSXKH9Hqyh5 kycohBr8=; b=gAcCRIk6aHyt4kzgje9UHzJeKUQmRjlTjAEEH0WsNN6JyqRLJxe fSt3WyFKi+7mcgowktdkReZs0DXHOf25uZFd4xfZcA+1ov+kXLdblNV6E7YXdrnL fqY7XEjEYXzvzVDYP4ppDrYqCAJaqRiZhp2w1p2iZPTvZmybatNGAS5fAWLAtbRN yuZualcjrJnGpQif/ImpmnM/qQ+k5xP7ZhAPEqUmNXsQo0NHk9+YH9jv+REwlDkJ 9h0qGr3vcafzvMAjNbpgdA68dbwBNF2K1kXhdFXKjpHb51vBrgzlGE2TFda4MVoJ KxNnSPKx074uw4eU12IdQVsYkNJBpCgp5nQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1689825915; x=1689912315; bh=IV1CGEnNVNlKakMOVthPCM7/pSXKH9Hqyh5 kycohBr8=; b=YYJU00P4sLA0Y19NCnOfpKoctpPQvLCoOi8Fa9luwppnzfmzSRv 73b+P+eukjZ/yn/NL2I5YNbyXdW9FUPw9d0IPP6iBdSP9fFcHE1ur+5dN7UG/MMG 3cYDCAFSh7q0KPeNsmmbdcmnK2SKUxHHduTD42H3sjh9WpvvvtxyySZRgnAZqvpB CizgOYEQpEi7KZXZBvoaNzbO0oxZt4UXA1OTuFl6ZtUFIlMyGIfRbyQryYRheLYF Er9qmUTaVPFDwOkjfcv89Szh7q7TxifLXNF5lO3JXZBE4WQPMkqQlhllyVfXg47A Zu3EWFvjjOM0mOCFrDGPwqmcRI2+ln7s3Ew== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrgeelgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgeejiedvleehudfhuefgfeevgfehieetgeeigffggfffffeiuefg ueektdeffeevnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Jul 2023 00:05:14 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Bruce Richardson , Morten =?ISO-8859-1?Q?Br=F8rup?= , dev@dpdk.org, David Marchand , Tyler Retzlaff Subject: Re: [PATCH v2] devtools: allow variable declaration inside for loop Date: Thu, 20 Jul 2023 06:05:12 +0200 Message-ID: <10350121.ag9G3TJQzC@thomas> In-Reply-To: <20230503150613.GA7537@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230503095018.1710769-1-ferruh.yigit@amd.com> <2878762.e9J7NaK4W3@thomas> <20230503150613.GA7537@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > > Declaring variable inside for loop is not supported via C89 and i= t was > > > > > checked in checkpatch.sh via commit [1]. > > > > > But as DPDK supported C standard is becoming C99/C11 [2], declari= ng > > > > > variable inside loop can be allowed. > > > > > > > > > > [1] > > > > > Commit 43e73483a4b8 ("devtools: forbid variable declaration inside > > > > for") > > > > > > > > > > [2] > > > > > https://dpdk.org/patch/121912 > > > > > > > > > > Signed-off-by: Ferruh Yigit > > > > > --- > > > > > Cc: Bruce Richardson > > > > > Cc: David Marchand > > > > > > > > > > v2: > > > > > * Update coding convention too > > > > > --- > > > >=20 > > > > Acked-by: Bruce Richardson > > >=20 > > > Acked-by: Morten Br=F8rup >=20 > Acked-by: Tyler Retzlaff Applied, thanks.