From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ilya Maximets <i.maximets@samsung.com>,
dev@dpdk.org, Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: Heetae Ahn <heetae82.ahn@samsung.com>, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: change log levels in client mode
Date: Thu, 2 Mar 2017 14:33:27 +0100 [thread overview]
Message-ID: <1035fba0-89c1-1db5-2e1e-02c691633785@redhat.com> (raw)
In-Reply-To: <1488447574-6266-1-git-send-email-i.maximets@samsung.com>
On 03/02/2017 10:39 AM, Ilya Maximets wrote:
> Inability to connect to socket is a normal situation
> in client mode because, in common case, server isn't
> started yet. RTE_LOG_WARNING should be suitable for
> the case of some unusual errors.
> Message about reconnection is not an error at all.
>
> CC: stable@dpdk.org
> Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")
>
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
> lib/librte_vhost/socket.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index aaa9c27..6a30a31 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -448,7 +448,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
> return 0;
> }
>
> - RTE_LOG(ERR, VHOST_CONFIG,
> + RTE_LOG(WARNING, VHOST_CONFIG,
> "failed to connect to %s: %s\n",
> path, strerror(errno));
>
> @@ -457,7 +457,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
> return -1;
> }
>
> - RTE_LOG(ERR, VHOST_CONFIG, "%s: reconnecting...\n", path);
> + RTE_LOG(INFO, VHOST_CONFIG, "%s: reconnecting...\n", path);
> reconn = malloc(sizeof(*reconn));
> if (reconn == NULL) {
> RTE_LOG(ERR, VHOST_CONFIG,
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks!
Maxime
next prev parent reply other threads:[~2017-03-02 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170302093942eucas1p1f0cf693364fdfb09c87ec8f72415d775@eucas1p1.samsung.com>
2017-03-02 9:39 ` Ilya Maximets
2017-03-02 13:33 ` Maxime Coquelin [this message]
2017-03-03 2:07 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1035fba0-89c1-1db5-2e1e-02c691633785@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=heetae82.ahn@samsung.com \
--cc=i.maximets@samsung.com \
--cc=stable@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).