From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 777EC2B93; Thu, 2 Mar 2017 14:33:36 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8DB1261BAD; Thu, 2 Mar 2017 13:33:36 +0000 (UTC) Received: from [10.36.117.139] (ovpn-117-139.ams2.redhat.com [10.36.117.139]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v22DXT99018518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 2 Mar 2017 08:33:33 -0500 To: Ilya Maximets , dev@dpdk.org, Yuanhan Liu References: <1488447574-6266-1-git-send-email-i.maximets@samsung.com> Cc: Heetae Ahn , stable@dpdk.org From: Maxime Coquelin Message-ID: <1035fba0-89c1-1db5-2e1e-02c691633785@redhat.com> Date: Thu, 2 Mar 2017 14:33:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1488447574-6266-1-git-send-email-i.maximets@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 02 Mar 2017 13:33:36 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: change log levels in client mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 13:33:36 -0000 On 03/02/2017 10:39 AM, Ilya Maximets wrote: > Inability to connect to socket is a normal situation > in client mode because, in common case, server isn't > started yet. RTE_LOG_WARNING should be suitable for > the case of some unusual errors. > Message about reconnection is not an error at all. > > CC: stable@dpdk.org > Fixes: e623e0c6d8a5 ("vhost: add reconnect ability") > > Signed-off-by: Ilya Maximets > --- > lib/librte_vhost/socket.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c > index aaa9c27..6a30a31 100644 > --- a/lib/librte_vhost/socket.c > +++ b/lib/librte_vhost/socket.c > @@ -448,7 +448,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket) > return 0; > } > > - RTE_LOG(ERR, VHOST_CONFIG, > + RTE_LOG(WARNING, VHOST_CONFIG, > "failed to connect to %s: %s\n", > path, strerror(errno)); > > @@ -457,7 +457,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket) > return -1; > } > > - RTE_LOG(ERR, VHOST_CONFIG, "%s: reconnecting...\n", path); > + RTE_LOG(INFO, VHOST_CONFIG, "%s: reconnecting...\n", path); > reconn = malloc(sizeof(*reconn)); > if (reconn == NULL) { > RTE_LOG(ERR, VHOST_CONFIG, > Reviewed-by: Maxime Coquelin Thanks! Maxime