DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Viacheslav Galaktionov <Viacheslav.Galaktionov@arknetworks.am>
Cc: Denis Pryazhennikov <Denis.Pryazhennikov@arknetworks.am>, dev@dpdk.org
Subject: Re: CRC offload from application's POV
Date: Tue, 11 Oct 2022 12:36:36 +0100	[thread overview]
Message-ID: <103627bd-d704-84a2-9f3e-5e4a7341e6a7@amd.com> (raw)
In-Reply-To: <11b33bf3-413a-6955-423a-cc47a73e2202@arknetworks.am>

On 10/11/2022 11:48 AM, Viacheslav Galaktionov wrote:
> Hi!
> 
> We're looking to implement CRC offload in our driver and we're having 
> difficulties understanding what
> the feature changes from the application's point of view. If we enable 
> the KEEP_CRC offload, then the
> NIC is supposed to preserve the CRC in the packet, that much is clear. 
> But we checked other drivers
> and it seems common for PMDs to remove the CRC from the final mbufs. Why 
> is that?
> 
> We couldn't find any place where the CRC would be stored after removal, 
> so it looks like the application
> doesn't have access to this piece of data. And if so, what's the point 
> of having this feature if the CRC
> is discarded either way?
> 
> We're probably missing something and would really appreciate any help 
> with this.
> 

Hi Viacheslav,

As you said default behavior is to strip the CRC from packet, even some 
devices doesn't support having CRC in the packet it is removed by HW 
automatically. In this case application can't access to the CRC.

For the devices that has capability to keep CRC, KEEP_CRC offload should 
enable having CRC as part of the packet. There is no special field to 
store the CRC.



  reply	other threads:[~2022-10-11 11:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11 10:48 Viacheslav Galaktionov
2022-10-11 11:36 ` Ferruh Yigit [this message]
2022-10-11 11:54   ` Viacheslav Galaktionov
2022-10-11 13:46     ` Ferruh Yigit
2022-10-12  2:29       ` Wu, Wenjun1
2022-10-12  8:06         ` Ferruh Yigit
2022-10-12  8:18           ` Wu, Wenjun1
2022-10-12  8:21             ` Ferruh Yigit
2022-10-12  8:49               ` Viacheslav Galaktionov
2022-10-12  9:10               ` Wu, Wenjun1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=103627bd-d704-84a2-9f3e-5e4a7341e6a7@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=Denis.Pryazhennikov@arknetworks.am \
    --cc=Viacheslav.Galaktionov@arknetworks.am \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).