From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id C3CAB6904 for ; Tue, 23 Apr 2019 19:13:27 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 20FDD40021 for ; Tue, 23 Apr 2019 19:13:27 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 0B71A40020; Tue, 23 Apr 2019 19:13:26 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.1 X-Spam-Score: -1.0 Received: from [192.168.1.59] (host-95-192-230-180.mobileonline.telia.com [95.192.230.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 490A140016; Tue, 23 Apr 2019 19:13:24 +0200 (CEST) To: Neil Horman Cc: dev@dpdk.org, stephen@networkplumber.org References: <20190419212138.17422-2-mattias.ronnblom@ericsson.com> <20190422113420.GA22056@hmswarspite.think-freely.org> <5a7b8741-da7f-7322-e57f-59d00d7bcde2@ericsson.com> <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> <20190423113347.GB30923@hmswarspite.think-freely.org> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: <104362bb-689f-23cb-9cf7-1a2022ea68f2@ericsson.com> Date: Tue, 23 Apr 2019 19:13:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190423113347.GB30923@hmswarspite.think-freely.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 17:13:27 -0000 On 2019-04-23 13:33, Neil Horman wrote: > On Mon, Apr 22, 2019 at 07:44:39PM +0200, Mattias Rönnblom wrote: >> On 2019-04-22 17:52, Mattias Rönnblom wrote: >>> On 2019-04-22 13:34, Neil Horman wrote: >>> >>>>> +uint64_t __rte_experimental >>>>> +rte_rand(void) >>>> Do you really want to mark this as experimental?  I know it will >>>> trigger the >>>> symbol checker with a warning if you don't, but this function >>>> already existed >>>> previously and was accepted as part of the ABI.  Given that the >>>> prototype hasn't >>>> changed, I think you just need to accept it as a non-experimental >>>> function >>>> >>> >>> I'll remove the experimental tag and move it into the 19_05 section >>> (without suggesting it should go into 19.05). That maneuver seems not to >>> trigger any build warnings/errors. >>> >> >> OK, so that wasn't true. It does trigger a build error, courtesy of >> buildtools/check-experimental-syms.sh. >> >> I can't see any obvious way around it. Ideas, anyone? >> > No, we would have to waive it. I don't understand. What do you mean? > But its pretty clear that This function has been > around forever, so I think it would be worse to demote it to an experimental > symbol. The only thing you're doing here is moving it from an inline function > (which is arguably part of the ABI, even if it never appeared as a symbol in the > ELF file), to a fully fleged symbol with a new implementation. > I agree it shouldn't be marked experimental. The reason for doing so was to avoid triggering a build error. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4F96CA05D3 for ; Tue, 23 Apr 2019 19:13:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 680BD69D4; Tue, 23 Apr 2019 19:13:28 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id C3CAB6904 for ; Tue, 23 Apr 2019 19:13:27 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 20FDD40021 for ; Tue, 23 Apr 2019 19:13:27 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 0B71A40020; Tue, 23 Apr 2019 19:13:26 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.1 X-Spam-Score: -1.0 Received: from [192.168.1.59] (host-95-192-230-180.mobileonline.telia.com [95.192.230.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 490A140016; Tue, 23 Apr 2019 19:13:24 +0200 (CEST) To: Neil Horman Cc: dev@dpdk.org, stephen@networkplumber.org References: <20190419212138.17422-2-mattias.ronnblom@ericsson.com> <20190422113420.GA22056@hmswarspite.think-freely.org> <5a7b8741-da7f-7322-e57f-59d00d7bcde2@ericsson.com> <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> <20190423113347.GB30923@hmswarspite.think-freely.org> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: <104362bb-689f-23cb-9cf7-1a2022ea68f2@ericsson.com> Date: Tue, 23 Apr 2019 19:13:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190423113347.GB30923@hmswarspite.think-freely.org> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423171324.qB3hGa6U7P44UD4OAeprCamvDUucWuPIOL3MBbh37gk@z> On 2019-04-23 13:33, Neil Horman wrote: > On Mon, Apr 22, 2019 at 07:44:39PM +0200, Mattias Rönnblom wrote: >> On 2019-04-22 17:52, Mattias Rönnblom wrote: >>> On 2019-04-22 13:34, Neil Horman wrote: >>> >>>>> +uint64_t __rte_experimental >>>>> +rte_rand(void) >>>> Do you really want to mark this as experimental?  I know it will >>>> trigger the >>>> symbol checker with a warning if you don't, but this function >>>> already existed >>>> previously and was accepted as part of the ABI.  Given that the >>>> prototype hasn't >>>> changed, I think you just need to accept it as a non-experimental >>>> function >>>> >>> >>> I'll remove the experimental tag and move it into the 19_05 section >>> (without suggesting it should go into 19.05). That maneuver seems not to >>> trigger any build warnings/errors. >>> >> >> OK, so that wasn't true. It does trigger a build error, courtesy of >> buildtools/check-experimental-syms.sh. >> >> I can't see any obvious way around it. Ideas, anyone? >> > No, we would have to waive it. I don't understand. What do you mean? > But its pretty clear that This function has been > around forever, so I think it would be worse to demote it to an experimental > symbol. The only thing you're doing here is moving it from an inline function > (which is arguably part of the ABI, even if it never appeared as a symbol in the > ELF file), to a fully fleged symbol with a new implementation. > I agree it shouldn't be marked experimental. The reason for doing so was to avoid triggering a build error.