From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 45B6A1B3DB; Wed, 8 Nov 2017 00:57:19 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E1FC220BE7; Tue, 7 Nov 2017 18:57:18 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 07 Nov 2017 18:57:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Y9jhroq0rlrxJpDAZy4ZOSLnZJ hjMPsdocP7lbM8WMU=; b=i2KD3kaa0kelDWiycfQlBisxz9Sypw2nOwSblHUcE2 nn9dkkTv2AHTPJI9W6MUiO+CHX55EBOb0GcTpV0FQJSNk5nUXhCnWDTAvuiM8Bdt qY3QWs2Wt200fsG4YTUxMFNTfNV0/VoZv9eyAC/ECKkso+90ISIt9TSphLrO3r5T c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Y9jhro q0rlrxJpDAZy4ZOSLnZJhjMPsdocP7lbM8WMU=; b=pVrt0Dv9iFg7BgKU3wscUR slOpxMcGJkrrumE6epg4Oj7cE5RBFCwDOtwTnjdO5fSI/s500xu1DAv3h7rXdnxD 1neCoIjniDtB8lEDSCD7JB6CGt80sWBIEsm/5a6EegUgcuJkQbIzIzfAr8eBK7Tm vXF8pnlsN+kBeztFA+vBrXwyeFlE4Jl0z5eVuu4qdWPqFYwXRilXCEh/hIzqvOgM nuKsL2m497QjCqGPBhaQEasoFrlZb/Li0nTotcZyox6tRymrekHWrqmYeTq3GyoR mCGSKd0nrxF8mlrpUi5HkYaz71Wnaub+tKDCJMn05IuOgjeOnyJNetVaUZ1kbB+w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9872E242CF; Tue, 7 Nov 2017 18:57:18 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org, Jianfeng Tan , Jingjing Wu , Shijith Thotton , Gregory Etelson , Harish Patil , George Prekas , Sergio Gonzalez Monroy , Rasesh Mody , Lee Roberts , Stephen Hemminger , Chas Williams Date: Wed, 08 Nov 2017 00:57:17 +0100 Message-ID: <10440492.mlt1TGbLnU@xps> In-Reply-To: <20171107222913.65295-1-ferruh.yigit@intel.com> References: <20171107193217.56357-1-ferruh.yigit@intel.com> <20171107222913.65295-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: remove device reset in release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 23:57:19 -0000 07/11/2017 23:29, Ferruh Yigit: > More error reported for device reset in release() [1], > when device pass-through to the guest, host kernel crash on guest exit. > > Removing the reset completely. > > This is close to reverting commit b58eedfc7dd5 [2], taking into account > previous fix to remove reset in open as well [3], but not exactly same. > > With latest code, interrupts are enabled in uio open() callback and > disabled in uio release() callback, so when a DPDK application exit > device interrupts are disabled. Previously interrupts were only enabled > once in igb_uio module insert and disabled in module removal. > > Also with latest code device set as bus master in open() and master > cleared in release(), clearing bus master should prevent further DMA > which was one of the target of the initial patch. > > The initial intention was also to reset the device to be sure it has > been left in proper state, but currently that part is missing because of > reported problem(s). > > Still igb_uio should be safer comparing to the pre b58eedfc7dd5 state. > > [1] > http://dpdk.org/ml/archives/dev/2017-November/081459.html > > [2] > b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") > > [3] > f73b38e9245d ("igb_uio: remove device reset in open") > > Fixes: e3a64deae2d5 ("igb_uio: prevent reset for bnx2x devices") > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit We can say you tried hard to make igb_uio cleaner and safer :) Applied, thanks for the detailed explanations.